Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Andreas Färber]

Am 16.03.2016 um 13:09 schrieb Robin Murphy:
> On 16/03/16 11:39, Marc Zyngier wrote:
>> On 16/03/16 11:19, Bert Lindner wrote:
>>> Hopefully this is the correct place and way to report this.

The main discussion is on netdev list actually, CC'ed.

>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a problem
>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
>>>
>>> root@lime2-079f:~# ip a l eth0
>>> 2: eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group
>>> default qlen 1000
>>>       link/ether 02:c9:05:02:07:9f brd ff:ff:ff:ff:ff:ff
>>>
>>>    Difference reported in dmesg:
>>>
>>> 4.5.0-rc7:
>>> [    9.379279] NET: Registered protocol family 10
>>> [   10.217148]  RX IPC Checksum Offload disabled
>>> [   10.217195]  No MAC Management Counters available
>>> [   10.217627] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>> [   15.206250] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>> 1Gbps/Full - flow control off
>>> [   15.206360] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>
>>> 4.5.0:
>>> [    9.767125] NET: Registered protocol family 10
>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>> [   10.362382] eth0: Could not attach to PHY
>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
>>>
>>> .config is identical for both, also after make oldconfig, apart from
>>> comment with version number. DTB file is also identical between the two
>>> versions.
>>>
>>> Kernels are compiled on the board itself. /proc/version string:
>>> Linux version 4.5.0-rc7 (root@lime2-079f) (gcc version 4.9.1
>>> (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Mon Mar 7 11:57:25 UTC 2016
>>> Linux version 4.5.0 (root@lime2-079f) (gcc version 4.9.1 (Ubuntu/Linaro
>>> 4.9.1-16ubuntu6) ) #1 SMP Tue Mar 15 11:39:01 UTC 2016
>>>
>>> Please let me know if more info is needed, if I should post complete
>>> .config, test compile with a particular config or patch, etc. Part of
>>> .config below.
>>
>> Can you please try reverting 88f8b1b ("stmmac: Fix 'eth0: No PHY found'
>> regression") and report whether or not this changes anything? This seems
>> to be the only stmac patch between -rc7 and release...
> 
> Sounds like the same thing as the giant ongoing discussion thread here:
> 
> http://thread.gmane.org/gmane.linux.drivers.devicetree/159007/focus=402830

v4 fixes for 4.5 are here:

https://patchwork.ozlabs.org/patch/598195/ (revert)
https://patchwork.ozlabs.org/patch/598196/

v2 fixes for linux-next here:

https://patchwork.ozlabs.org/patch/598331/ (revert)
https://patchwork.ozlabs.org/patch/598332/

Please let Peppe know whether they work for you guys.

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Bert Lindner]

On 2016-03-16 14:10, Andreas Färber wrote:
> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>> On 16/03/16 11:39, Marc Zyngier wrote:
>>> On 16/03/16 11:19, Bert Lindner wrote:
>>>> Hopefully this is the correct place and way to report this.
>
> The main discussion is on netdev list actually, CC'ed.
>
>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a problem
>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
>>>>
>>>> root@lime2-079f:~# ip a l eth0
>>>> 2: eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group
>>>> default qlen 1000
>>>>        link/ether 02:c9:05:02:07:9f brd ff:ff:ff:ff:ff:ff
>>>>
>>>>     Difference reported in dmesg:
>>>>
>>>> 4.5.0-rc7:
>>>> [    9.379279] NET: Registered protocol family 10
>>>> [   10.217148]  RX IPC Checksum Offload disabled
>>>> [   10.217195]  No MAC Management Counters available
>>>> [   10.217627] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>>> [   15.206250] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>>> 1Gbps/Full - flow control off
>>>> [   15.206360] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>>
>>>> 4.5.0:
>>>> [    9.767125] NET: Registered protocol family 10
>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>>> [   10.362382] eth0: Could not attach to PHY
>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
>>>>
>>>> .config is identical for both, also after make oldconfig, apart from
>>>> comment with version number. DTB file is also identical between the two
>>>> versions.
>>>>
>>>> Kernels are compiled on the board itself. /proc/version string:
>>>> Linux version 4.5.0-rc7 (root@lime2-079f) (gcc version 4.9.1
>>>> (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Mon Mar 7 11:57:25 UTC 2016
>>>> Linux version 4.5.0 (root@lime2-079f) (gcc version 4.9.1 (Ubuntu/Linaro
>>>> 4.9.1-16ubuntu6) ) #1 SMP Tue Mar 15 11:39:01 UTC 2016
>>>>
>>>> Please let me know if more info is needed, if I should post complete
>>>> .config, test compile with a particular config or patch, etc. Part of
>>>> .config below.
>>>
>>> Can you please try reverting 88f8b1b ("stmmac: Fix 'eth0: No PHY found'
>>> regression") and report whether or not this changes anything? This seems
>>> to be the only stmac patch between -rc7 and release...
>>
>> Sounds like the same thing as the giant ongoing discussion thread here:
>>
>> http://thread.gmane.org/gmane.linux.drivers.devicetree/159007/focus=402830
>
> v4 fixes for 4.5 are here:
>
> https://patchwork.ozlabs.org/patch/598195/ (revert)
> https://patchwork.ozlabs.org/patch/598196/
>
> v2 fixes for linux-next here:
>
> https://patchwork.ozlabs.org/patch/598331/ (revert)
> https://patchwork.ozlabs.org/patch/598332/
>
> Please let Peppe know whether they work for you guys.

Hi guys - I can confirm 4.5.0 minus 88f8b1b works for me:

root@lime2-079f:~# cat /proc/version
Linux version 4.5.0-minus-88f8b1b (root@lime2-079f) (gcc version 4.9.1 
(Ubuntu/Linaro 4.9.1-16ubuntu6) ) #2 SMP Wed Mar 16 12:50:03 UTC 2016

 From dmesg output:
[    9.731730] NET: Registered protocol family 10
[   10.516893]  RX IPC Checksum Offload disabled
[   10.516948]  No MAC Management Counters available
[   10.517374] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
[   15.505548] sun7i-dwmac 1c50000.ethernet eth0: Link is Up - 
1Gbps/Full - flow control off
[   15.505660] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready

.. and connected over ethernet.

Thanks, best,

	-bert

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Marc Zyngier]

On 16/03/16 15:10, Bert Lindner wrote:
> On 2016-03-16 14:10, Andreas Färber wrote:
>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>>> On 16/03/16 11:39, Marc Zyngier wrote:
>>>> On 16/03/16 11:19, Bert Lindner wrote:
>>>>> Hopefully this is the correct place and way to report this.
>>
>> The main discussion is on netdev list actually, CC'ed.
>>
>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a problem
>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
>>>>>
>>>>> root@lime2-079f:~# ip a l eth0
>>>>> 2: eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group
>>>>> default qlen 1000
>>>>>        link/ether 02:c9:05:02:07:9f brd ff:ff:ff:ff:ff:ff
>>>>>
>>>>>     Difference reported in dmesg:
>>>>>
>>>>> 4.5.0-rc7:
>>>>> [    9.379279] NET: Registered protocol family 10
>>>>> [   10.217148]  RX IPC Checksum Offload disabled
>>>>> [   10.217195]  No MAC Management Counters available
>>>>> [   10.217627] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>>>> [   15.206250] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>>>> 1Gbps/Full - flow control off
>>>>> [   15.206360] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>>>
>>>>> 4.5.0:
>>>>> [    9.767125] NET: Registered protocol family 10
>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>>>> [   10.362382] eth0: Could not attach to PHY
>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
>>>>>
>>>>> .config is identical for both, also after make oldconfig, apart from
>>>>> comment with version number. DTB file is also identical between the two
>>>>> versions.
>>>>>
>>>>> Kernels are compiled on the board itself. /proc/version string:
>>>>> Linux version 4.5.0-rc7 (root@lime2-079f) (gcc version 4.9.1
>>>>> (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Mon Mar 7 11:57:25 UTC 2016
>>>>> Linux version 4.5.0 (root@lime2-079f) (gcc version 4.9.1 (Ubuntu/Linaro
>>>>> 4.9.1-16ubuntu6) ) #1 SMP Tue Mar 15 11:39:01 UTC 2016
>>>>>
>>>>> Please let me know if more info is needed, if I should post complete
>>>>> .config, test compile with a particular config or patch, etc. Part of
>>>>> .config below.
>>>>
>>>> Can you please try reverting 88f8b1b ("stmmac: Fix 'eth0: No PHY found'
>>>> regression") and report whether or not this changes anything? This seems
>>>> to be the only stmac patch between -rc7 and release...
>>>
>>> Sounds like the same thing as the giant ongoing discussion thread here:
>>>
>>> http://thread.gmane.org/gmane.linux.drivers.devicetree/159007/focus=402830
>>
>> v4 fixes for 4.5 are here:
>>
>> https://patchwork.ozlabs.org/patch/598195/ (revert)
>> https://patchwork.ozlabs.org/patch/598196/
>>
>> v2 fixes for linux-next here:
>>
>> https://patchwork.ozlabs.org/patch/598331/ (revert)
>> https://patchwork.ozlabs.org/patch/598332/
>>
>> Please let Peppe know whether they work for you guys.
> 
> Hi guys - I can confirm 4.5.0 minus 88f8b1b works for me:
> 
> root@lime2-079f:~# cat /proc/version
> Linux version 4.5.0-minus-88f8b1b (root@lime2-079f) (gcc version 4.9.1 
> (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #2 SMP Wed Mar 16 12:50:03 UTC 2016
> 
>  From dmesg output:
> [    9.731730] NET: Registered protocol family 10
> [   10.516893]  RX IPC Checksum Offload disabled
> [   10.516948]  No MAC Management Counters available
> [   10.517374] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> [   15.505548] sun7i-dwmac 1c50000.ethernet eth0: Link is Up - 
> 1Gbps/Full - flow control off
> [   15.505660] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
> 
> .. and connected over ethernet.

Good to know, thanks. Could you also give the potential fix a go (as
mentioned by Andreas)? Just to make sure that whatever gets merged next
will actually fix the issue.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Bert Lindner]

On 2016-03-16 18:42, Marc Zyngier wrote:
> On 16/03/16 15:10, Bert Lindner wrote:
>> On 2016-03-16 14:10, Andreas Färber wrote:
>>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>>>> On 16/03/16 11:39, Marc Zyngier wrote:
>>>>> On 16/03/16 11:19, Bert Lindner wrote:
>>>>>> Hopefully this is the correct place and way to report this.
>>>
>>> The main discussion is on netdev list actually, CC'ed.
>>>
>>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a problem
>>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
>>>>>>
>>>>>> root@lime2-079f:~# ip a l eth0
>>>>>> 2: eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group
>>>>>> default qlen 1000
>>>>>>         link/ether 02:c9:05:02:07:9f brd ff:ff:ff:ff:ff:ff
>>>>>>
>>>>>>      Difference reported in dmesg:
>>>>>>
>>>>>> 4.5.0-rc7:
>>>>>> [    9.379279] NET: Registered protocol family 10
>>>>>> [   10.217148]  RX IPC Checksum Offload disabled
>>>>>> [   10.217195]  No MAC Management Counters available
>>>>>> [   10.217627] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>>>>> [   15.206250] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>>>>> 1Gbps/Full - flow control off
>>>>>> [   15.206360] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>>>>
>>>>>> 4.5.0:
>>>>>> [    9.767125] NET: Registered protocol family 10
>>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>>>>> [   10.362382] eth0: Could not attach to PHY
>>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
>>>>>>
>>>>>> .config is identical for both, also after make oldconfig, apart from
>>>>>> comment with version number. DTB file is also identical between the two
>>>>>> versions.
>>>>>>
>>>>>> Kernels are compiled on the board itself. /proc/version string:
>>>>>> Linux version 4.5.0-rc7 (root@lime2-079f) (gcc version 4.9.1
>>>>>> (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Mon Mar 7 11:57:25 UTC 2016
>>>>>> Linux version 4.5.0 (root@lime2-079f) (gcc version 4.9.1 (Ubuntu/Linaro
>>>>>> 4.9.1-16ubuntu6) ) #1 SMP Tue Mar 15 11:39:01 UTC 2016
>>>>>>
>>>>>> Please let me know if more info is needed, if I should post complete
>>>>>> .config, test compile with a particular config or patch, etc. Part of
>>>>>> .config below.
>>>>>
>>>>> Can you please try reverting 88f8b1b ("stmmac: Fix 'eth0: No PHY found'
>>>>> regression") and report whether or not this changes anything? This seems
>>>>> to be the only stmac patch between -rc7 and release...
>>>>
>>>> Sounds like the same thing as the giant ongoing discussion thread here:
>>>>
>>>> http://thread.gmane.org/gmane.linux.drivers.devicetree/159007/focus=402830
>>>
>>> v4 fixes for 4.5 are here:
>>>
>>> https://patchwork.ozlabs.org/patch/598195/ (revert)
>>> https://patchwork.ozlabs.org/patch/598196/
>>>
>>> v2 fixes for linux-next here:
>>>
>>> https://patchwork.ozlabs.org/patch/598331/ (revert)
>>> https://patchwork.ozlabs.org/patch/598332/
>>>
>>> Please let Peppe know whether they work for you guys.
>>
>> Hi guys - I can confirm 4.5.0 minus 88f8b1b works for me:
>>
>> root@lime2-079f:~# cat /proc/version
>> Linux version 4.5.0-minus-88f8b1b (root@lime2-079f) (gcc version 4.9.1
>> (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #2 SMP Wed Mar 16 12:50:03 UTC 2016
>>
>>   From dmesg output:
>> [    9.731730] NET: Registered protocol family 10
>> [   10.516893]  RX IPC Checksum Offload disabled
>> [   10.516948]  No MAC Management Counters available
>> [   10.517374] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>> [   15.505548] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>> 1Gbps/Full - flow control off
>> [   15.505660] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>
>> .. and connected over ethernet.
>
> Good to know, thanks. Could you also give the potential fix a go (as
> mentioned by Andreas)? Just to make sure that whatever gets merged next
> will actually fix the issue.

Yes sure, it took a while because I had to travel. Confirmed, the 
v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:

root@lime2-079f:~# cat /proc/version
Linux version 4.5.0-598195-598196-v4 (root@lime2-079f) (gcc version 
4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC 2016

dmesg:
[    8.245273] NET: Registered protocol family 10
[    9.297406]  RX IPC Checksum Offload disabled
[    9.297460]  No MAC Management Counters available
[    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
[   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up - 
1Gbps/Full - flow control rx/tx
[   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready

The board is connected to my laptop rather than to a switch, so that 
might be where the flow control message comes from (not sure). Anyway 
ethernet works.

I'm less familiar with linux-next - not sure what base to test against, 
I understand it is being redefined almost daily.

Thanks!

	-Bert

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Marc Zyngier]

On Thu, 17 Mar 2016 00:56:40 +0100
Bert Lindner <bert-phGP8mJ4Mqk@public.gmane.org> wrote:

> On 2016-03-16 18:42, Marc Zyngier wrote:
> > On 16/03/16 15:10, Bert Lindner wrote:
> >> On 2016-03-16 14:10, Andreas Färber wrote:
> >>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
> >>>> On 16/03/16 11:39, Marc Zyngier wrote:
> >>>>> On 16/03/16 11:19, Bert Lindner wrote:
> >>>>>> Hopefully this is the correct place and way to report this.
> >>>
> >>> The main discussion is on netdev list actually, CC'ed.
> >>>
> >>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a problem
> >>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
> >>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
> >>>>>>
> >>>>>> root@lime2-079f:~# ip a l eth0
> >>>>>> 2: eth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group
> >>>>>> default qlen 1000
> >>>>>>         link/ether 02:c9:05:02:07:9f brd ff:ff:ff:ff:ff:ff
> >>>>>>
> >>>>>>      Difference reported in dmesg:
> >>>>>>
> >>>>>> 4.5.0-rc7:
> >>>>>> [    9.379279] NET: Registered protocol family 10
> >>>>>> [   10.217148]  RX IPC Checksum Offload disabled
> >>>>>> [   10.217195]  No MAC Management Counters available
> >>>>>> [   10.217627] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> >>>>>> [   15.206250] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
> >>>>>> 1Gbps/Full - flow control off
> >>>>>> [   15.206360] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
> >>>>>>
> >>>>>> 4.5.0:
> >>>>>> [    9.767125] NET: Registered protocol family 10
> >>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
> >>>>>> [   10.362382] eth0: Could not attach to PHY
> >>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
> >>>>>>
> >>>>>> .config is identical for both, also after make oldconfig, apart from
> >>>>>> comment with version number. DTB file is also identical between the two
> >>>>>> versions.
> >>>>>>
> >>>>>> Kernels are compiled on the board itself. /proc/version string:
> >>>>>> Linux version 4.5.0-rc7 (root@lime2-079f) (gcc version 4.9.1
> >>>>>> (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Mon Mar 7 11:57:25 UTC 2016
> >>>>>> Linux version 4.5.0 (root@lime2-079f) (gcc version 4.9.1 (Ubuntu/Linaro
> >>>>>> 4.9.1-16ubuntu6) ) #1 SMP Tue Mar 15 11:39:01 UTC 2016
> >>>>>>
> >>>>>> Please let me know if more info is needed, if I should post complete
> >>>>>> .config, test compile with a particular config or patch, etc. Part of
> >>>>>> .config below.
> >>>>>
> >>>>> Can you please try reverting 88f8b1b ("stmmac: Fix 'eth0: No PHY found'
> >>>>> regression") and report whether or not this changes anything? This seems
> >>>>> to be the only stmac patch between -rc7 and release...
> >>>>
> >>>> Sounds like the same thing as the giant ongoing discussion thread here:
> >>>>
> >>>> http://thread.gmane.org/gmane.linux.drivers.devicetree/159007/focus=402830
> >>>
> >>> v4 fixes for 4.5 are here:
> >>>
> >>> https://patchwork.ozlabs.org/patch/598195/ (revert)
> >>> https://patchwork.ozlabs.org/patch/598196/
> >>>
> >>> v2 fixes for linux-next here:
> >>>
> >>> https://patchwork.ozlabs.org/patch/598331/ (revert)
> >>> https://patchwork.ozlabs.org/patch/598332/
> >>>
> >>> Please let Peppe know whether they work for you guys.
> >>
> >> Hi guys - I can confirm 4.5.0 minus 88f8b1b works for me:
> >>
> >> root@lime2-079f:~# cat /proc/version
> >> Linux version 4.5.0-minus-88f8b1b (root@lime2-079f) (gcc version 4.9.1
> >> (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #2 SMP Wed Mar 16 12:50:03 UTC 2016
> >>
> >>   From dmesg output:
> >> [    9.731730] NET: Registered protocol family 10
> >> [   10.516893]  RX IPC Checksum Offload disabled
> >> [   10.516948]  No MAC Management Counters available
> >> [   10.517374] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> >> [   15.505548] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
> >> 1Gbps/Full - flow control off
> >> [   15.505660] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
> >>
> >> .. and connected over ethernet.
> >
> > Good to know, thanks. Could you also give the potential fix a go (as
> > mentioned by Andreas)? Just to make sure that whatever gets merged next
> > will actually fix the issue.
> 
> Yes sure, it took a while because I had to travel. Confirmed, the 
> v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:
> 
> root@lime2-079f:~# cat /proc/version
> Linux version 4.5.0-598195-598196-v4 (root@lime2-079f) (gcc version 
> 4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC 2016
> 
> dmesg:
> [    8.245273] NET: Registered protocol family 10
> [    9.297406]  RX IPC Checksum Offload disabled
> [    9.297460]  No MAC Management Counters available
> [    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> [   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up - 
> 1Gbps/Full - flow control rx/tx
> [   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
> 
> The board is connected to my laptop rather than to a switch, so that 
> might be where the flow control message comes from (not sure). Anyway 
> ethernet works.

Cool, many thanks for taking the time to test and report.

Hopefully Giuseppe will get this merged quickly enough in mainline, and
it should then trickle into a 4.5-stable release (cc-ing stable on
these patches would probably be a good idea, BTW).

> I'm less familiar with linux-next - not sure what base to test against, 
> I understand it is being redefined almost daily.

You can consider -next as a daily view of what mainline could become.
An over-sized crystal ball, in a way... ;-) Given that the regression
exists in mainline, there was no real point testing with -next.

Thanks again,

	M.
-- 
Jazz is not dead. It just smells funny.

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Andre Heider]

Giuseppe, Alexandre, et al.,

On Thu, Mar 17, 2016 at 8:52 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> On Thu, 17 Mar 2016 00:56:40 +0100
> Bert Lindner <bert@a20.net> wrote:
>> On 2016-03-16 18:42, Marc Zyngier wrote:
>> > On 16/03/16 15:10, Bert Lindner wrote:
>> >> On 2016-03-16 14:10, Andreas Färber wrote:
>> >>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>> >>>> On 16/03/16 11:39, Marc Zyngier wrote:
>> >>>>> On 16/03/16 11:19, Bert Lindner wrote:
...
>> >>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a problem
>> >>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>> >>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
...
>> >>>>>> [    9.767125] NET: Registered protocol family 10
>> >>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>> >>>>>> [   10.362382] eth0: Could not attach to PHY
>> >>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
...
>> >>> v4 fixes for 4.5 are here:
>> >>>
>> >>> https://patchwork.ozlabs.org/patch/598195/ (revert)
>> >>> https://patchwork.ozlabs.org/patch/598196/
...
>> > Good to know, thanks. Could you also give the potential fix a go (as
>> > mentioned by Andreas)? Just to make sure that whatever gets merged next
>> > will actually fix the issue.
>>
>> Yes sure, it took a while because I had to travel. Confirmed, the
>> v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:
>>
>> root@lime2-079f:~# cat /proc/version
>> Linux version 4.5.0-598195-598196-v4 (root@lime2-079f) (gcc version
>> 4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC 2016
>>
>> dmesg:
>> [    8.245273] NET: Registered protocol family 10
>> [    9.297406]  RX IPC Checksum Offload disabled
>> [    9.297460]  No MAC Management Counters available
>> [    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>> [   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>> 1Gbps/Full - flow control rx/tx
>> [   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>
>> The board is connected to my laptop rather than to a switch, so that
>> might be where the flow control message comes from (not sure). Anyway
>> ethernet works.
>
> Cool, many thanks for taking the time to test and report.
>
> Hopefully Giuseppe will get this merged quickly enough in mainline, and
> it should then trickle into a 4.5-stable release (cc-ing stable on
> these patches would probably be a good idea, BTW).

stmmac is broken on at least Lime2, BananaPi and Cubieboard2 since
v4.5 [0], including all five stable releases :(
The v4.5 patches quoted above are already +4 weeks old, could we
please get them into stable?

Thanks!
Andre

[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823493

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Marc Zyngier]

On 20/05/16 06:44, Andre Heider wrote:
> Giuseppe, Alexandre, et al.,
> 
> On Thu, Mar 17, 2016 at 8:52 AM, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org> wrote:
>> On Thu, 17 Mar 2016 00:56:40 +0100
>> Bert Lindner <bert-phGP8mJ4Mqk@public.gmane.org> wrote:
>>> On 2016-03-16 18:42, Marc Zyngier wrote:
>>>> On 16/03/16 15:10, Bert Lindner wrote:
>>>>> On 2016-03-16 14:10, Andreas Färber wrote:
>>>>>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>>>>>>> On 16/03/16 11:39, Marc Zyngier wrote:
>>>>>>>> On 16/03/16 11:19, Bert Lindner wrote:
> ...
>>>>>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a problem
>>>>>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>>>>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
> ...
>>>>>>>>> [    9.767125] NET: Registered protocol family 10
>>>>>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>>>>>>>> [   10.362382] eth0: Could not attach to PHY
>>>>>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
> ...
>>>>>> v4 fixes for 4.5 are here:
>>>>>>
>>>>>> https://patchwork.ozlabs.org/patch/598195/ (revert)
>>>>>> https://patchwork.ozlabs.org/patch/598196/
> ...
>>>> Good to know, thanks. Could you also give the potential fix a go (as
>>>> mentioned by Andreas)? Just to make sure that whatever gets merged next
>>>> will actually fix the issue.
>>>
>>> Yes sure, it took a while because I had to travel. Confirmed, the
>>> v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:
>>>
>>> root@lime2-079f:~# cat /proc/version
>>> Linux version 4.5.0-598195-598196-v4 (root@lime2-079f) (gcc version
>>> 4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC 2016
>>>
>>> dmesg:
>>> [    8.245273] NET: Registered protocol family 10
>>> [    9.297406]  RX IPC Checksum Offload disabled
>>> [    9.297460]  No MAC Management Counters available
>>> [    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>> [   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>> 1Gbps/Full - flow control rx/tx
>>> [   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>
>>> The board is connected to my laptop rather than to a switch, so that
>>> might be where the flow control message comes from (not sure). Anyway
>>> ethernet works.
>>
>> Cool, many thanks for taking the time to test and report.
>>
>> Hopefully Giuseppe will get this merged quickly enough in mainline, and
>> it should then trickle into a 4.5-stable release (cc-ing stable on
>> these patches would probably be a good idea, BTW).
> 
> stmmac is broken on at least Lime2, BananaPi and Cubieboard2 since
> v4.5 [0], including all five stable releases :(

All the A20 platforms are dead, actually.

> The v4.5 patches quoted above are already +4 weeks old, could we
> please get them into stable?

For that, the maintainer would have needed to CC stable, which he
didn't. I'd expect someone who cares to send these patches to stable.
It'd be better if the maintainer would do it himself though.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Giuseppe CAVALLARO]

Hello

On 5/20/2016 9:56 AM, Marc Zyngier wrote:
> On 20/05/16 06:44, Andre Heider wrote:
>> Giuseppe, Alexandre, et al.,
>>
>> On Thu, Mar 17, 2016 at 8:52 AM, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org> wrote:
>>> On Thu, 17 Mar 2016 00:56:40 +0100
>>> Bert Lindner <bert-phGP8mJ4Mqk@public.gmane.org> wrote:
>>>> On 2016-03-16 18:42, Marc Zyngier wrote:
>>>>> On 16/03/16 15:10, Bert Lindner wrote:
>>>>>> On 2016-03-16 14:10, Andreas Färber wrote:
>>>>>>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>>>>>>>> On 16/03/16 11:39, Marc Zyngier wrote:
>>>>>>>>> On 16/03/16 11:19, Bert Lindner wrote:
>> ...
>>>>>>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a problem
>>>>>>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>>>>>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
>> ...
>>>>>>>>>> [    9.767125] NET: Registered protocol family 10
>>>>>>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>>>>>>>>> [   10.362382] eth0: Could not attach to PHY
>>>>>>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
>> ...
>>>>>>> v4 fixes for 4.5 are here:
>>>>>>>
>>>>>>> https://patchwork.ozlabs.org/patch/598195/ (revert)
>>>>>>> https://patchwork.ozlabs.org/patch/598196/
>> ...
>>>>> Good to know, thanks. Could you also give the potential fix a go (as
>>>>> mentioned by Andreas)? Just to make sure that whatever gets merged next
>>>>> will actually fix the issue.
>>>>
>>>> Yes sure, it took a while because I had to travel. Confirmed, the
>>>> v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:
>>>>
>>>> root@lime2-079f:~# cat /proc/version
>>>> Linux version 4.5.0-598195-598196-v4 (root@lime2-079f) (gcc version
>>>> 4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC 2016
>>>>
>>>> dmesg:
>>>> [    8.245273] NET: Registered protocol family 10
>>>> [    9.297406]  RX IPC Checksum Offload disabled
>>>> [    9.297460]  No MAC Management Counters available
>>>> [    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>>> [   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>>> 1Gbps/Full - flow control rx/tx
>>>> [   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>>
>>>> The board is connected to my laptop rather than to a switch, so that
>>>> might be where the flow control message comes from (not sure). Anyway
>>>> ethernet works.
>>>
>>> Cool, many thanks for taking the time to test and report.
>>>
>>> Hopefully Giuseppe will get this merged quickly enough in mainline, and
>>> it should then trickle into a 4.5-stable release (cc-ing stable on
>>> these patches would probably be a good idea, BTW).
>>
>> stmmac is broken on at least Lime2, BananaPi and Cubieboard2 since
>> v4.5 [0], including all five stable releases :(
>
> All the A20 platforms are dead, actually.
>
>> The v4.5 patches quoted above are already +4 weeks old, could we
>> please get them into stable?
>
> For that, the maintainer would have needed to CC stable, which he
> didn't. I'd expect someone who cares to send these patches to stable.
> It'd be better if the maintainer would do it himself though.

sure, I can send the patches to stable (sorry if I missed to add
stable ML on CC).

Andre, I have not clear if the train of patches actually fix the
issue or if you need my support to fix something else. In that case
I need some input for debugging (e.g. kernel log).

let me know, is it enough to re-send the patches only?

Regards
Peppe

>
> Thanks,
>
> 	M.
>

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Andre Heider]

Hi,

On Fri, May 20, 2016 at 10:14 AM, Giuseppe CAVALLARO
<peppe.cavallaro-qxv4g6HH51o@public.gmane.org> wrote:
> On 5/20/2016 9:56 AM, Marc Zyngier wrote:
>>
>> On 20/05/16 06:44, Andre Heider wrote:
>>>
>>> Giuseppe, Alexandre, et al.,
>>>
>>> On Thu, Mar 17, 2016 at 8:52 AM, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
>>> wrote:
>>>>
>>>> On Thu, 17 Mar 2016 00:56:40 +0100
>>>> Bert Lindner <bert-phGP8mJ4Mqk@public.gmane.org> wrote:
>>>>>
>>>>> On 2016-03-16 18:42, Marc Zyngier wrote:
>>>>>>
>>>>>> On 16/03/16 15:10, Bert Lindner wrote:
>>>>>>>
>>>>>>> On 2016-03-16 14:10, Andreas Färber wrote:
>>>>>>>>
>>>>>>>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>>>>>>>>>
>>>>>>>>> On 16/03/16 11:39, Marc Zyngier wrote:
>>>>>>>>>>
>>>>>>>>>> On 16/03/16 11:19, Bert Lindner wrote:
>>>
>>> ...
>>>>>>>>>>>
>>>>>>>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a
>>>>>>>>>>> problem
>>>>>>>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>>>>>>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
>>>
>>> ...
>>>>>>>>>>>
>>>>>>>>>>> [    9.767125] NET: Registered protocol family 10
>>>>>>>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>>>>>>>>>> [   10.362382] eth0: Could not attach to PHY
>>>>>>>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
>>>
>>> ...
>>>>>>>>
>>>>>>>> v4 fixes for 4.5 are here:
>>>>>>>>
>>>>>>>> https://patchwork.ozlabs.org/patch/598195/ (revert)
>>>>>>>> https://patchwork.ozlabs.org/patch/598196/
>>>
>>> ...
>>>>>>
>>>>>> Good to know, thanks. Could you also give the potential fix a go (as
>>>>>> mentioned by Andreas)? Just to make sure that whatever gets merged
>>>>>> next
>>>>>> will actually fix the issue.
>>>>>
>>>>>
>>>>> Yes sure, it took a while because I had to travel. Confirmed, the
>>>>> v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:
>>>>>
>>>>> root@lime2-079f:~# cat /proc/version
>>>>> Linux version 4.5.0-598195-598196-v4 (root@lime2-079f) (gcc version
>>>>> 4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC
>>>>> 2016
>>>>>
>>>>> dmesg:
>>>>> [    8.245273] NET: Registered protocol family 10
>>>>> [    9.297406]  RX IPC Checksum Offload disabled
>>>>> [    9.297460]  No MAC Management Counters available
>>>>> [    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>>>> [   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>>>> 1Gbps/Full - flow control rx/tx
>>>>> [   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>>>
>>>>> The board is connected to my laptop rather than to a switch, so that
>>>>> might be where the flow control message comes from (not sure). Anyway
>>>>> ethernet works.
>>>>
>>>>
>>>> Cool, many thanks for taking the time to test and report.
>>>>
>>>> Hopefully Giuseppe will get this merged quickly enough in mainline, and
>>>> it should then trickle into a 4.5-stable release (cc-ing stable on
>>>> these patches would probably be a good idea, BTW).
>>>
>>>
>>> stmmac is broken on at least Lime2, BananaPi and Cubieboard2 since
>>> v4.5 [0], including all five stable releases :(
>>
>>
>> All the A20 platforms are dead, actually.
>>
>>> The v4.5 patches quoted above are already +4 weeks old, could we
>>> please get them into stable?
>>
>>
>> For that, the maintainer would have needed to CC stable, which he
>> didn't. I'd expect someone who cares to send these patches to stable.
>> It'd be better if the maintainer would do it himself though.
>
>
> sure, I can send the patches to stable (sorry if I missed to add
> stable ML on CC).
>
> Andre, I have not clear if the train of patches actually fix the
> issue or if you need my support to fix something else. In that case
> I need some input for debugging (e.g. kernel log).

Bert already confirmed that those two patches fixes stmmac on his
Lime2, so I assume that it fixes the issue for all A20 platforms.

> let me know, is it enough to re-send the patches only?

Just a resend with cc:stable :)

Thanks!
Andre

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Marc Zyngier]

On 20/05/16 11:30, Andre Heider wrote:
> Hi,
> 
> On Fri, May 20, 2016 at 10:14 AM, Giuseppe CAVALLARO
> <peppe.cavallaro@st.com> wrote:
>> On 5/20/2016 9:56 AM, Marc Zyngier wrote:
>>>
>>> On 20/05/16 06:44, Andre Heider wrote:
>>>>
>>>> Giuseppe, Alexandre, et al.,
>>>>
>>>> On Thu, Mar 17, 2016 at 8:52 AM, Marc Zyngier <marc.zyngier@arm.com>
>>>> wrote:
>>>>>
>>>>> On Thu, 17 Mar 2016 00:56:40 +0100
>>>>> Bert Lindner <bert@a20.net> wrote:
>>>>>>
>>>>>> On 2016-03-16 18:42, Marc Zyngier wrote:
>>>>>>>
>>>>>>> On 16/03/16 15:10, Bert Lindner wrote:
>>>>>>>>
>>>>>>>> On 2016-03-16 14:10, Andreas Färber wrote:
>>>>>>>>>
>>>>>>>>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>>>>>>>>>>
>>>>>>>>>> On 16/03/16 11:39, Marc Zyngier wrote:
>>>>>>>>>>>
>>>>>>>>>>> On 16/03/16 11:19, Bert Lindner wrote:
>>>>
>>>> ...
>>>>>>>>>>>>
>>>>>>>>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a
>>>>>>>>>>>> problem
>>>>>>>>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>>>>>>>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
>>>>
>>>> ...
>>>>>>>>>>>>
>>>>>>>>>>>> [    9.767125] NET: Registered protocol family 10
>>>>>>>>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>>>>>>>>>>> [   10.362382] eth0: Could not attach to PHY
>>>>>>>>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
>>>>
>>>> ...
>>>>>>>>>
>>>>>>>>> v4 fixes for 4.5 are here:
>>>>>>>>>
>>>>>>>>> https://patchwork.ozlabs.org/patch/598195/ (revert)
>>>>>>>>> https://patchwork.ozlabs.org/patch/598196/
>>>>
>>>> ...
>>>>>>>
>>>>>>> Good to know, thanks. Could you also give the potential fix a go (as
>>>>>>> mentioned by Andreas)? Just to make sure that whatever gets merged
>>>>>>> next
>>>>>>> will actually fix the issue.
>>>>>>
>>>>>>
>>>>>> Yes sure, it took a while because I had to travel. Confirmed, the
>>>>>> v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:
>>>>>>
>>>>>> root@lime2-079f:~# cat /proc/version
>>>>>> Linux version 4.5.0-598195-598196-v4 (root@lime2-079f) (gcc version
>>>>>> 4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC
>>>>>> 2016
>>>>>>
>>>>>> dmesg:
>>>>>> [    8.245273] NET: Registered protocol family 10
>>>>>> [    9.297406]  RX IPC Checksum Offload disabled
>>>>>> [    9.297460]  No MAC Management Counters available
>>>>>> [    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>>>>> [   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>>>>> 1Gbps/Full - flow control rx/tx
>>>>>> [   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>>>>
>>>>>> The board is connected to my laptop rather than to a switch, so that
>>>>>> might be where the flow control message comes from (not sure). Anyway
>>>>>> ethernet works.
>>>>>
>>>>>
>>>>> Cool, many thanks for taking the time to test and report.
>>>>>
>>>>> Hopefully Giuseppe will get this merged quickly enough in mainline, and
>>>>> it should then trickle into a 4.5-stable release (cc-ing stable on
>>>>> these patches would probably be a good idea, BTW).
>>>>
>>>>
>>>> stmmac is broken on at least Lime2, BananaPi and Cubieboard2 since
>>>> v4.5 [0], including all five stable releases :(
>>>
>>>
>>> All the A20 platforms are dead, actually.
>>>
>>>> The v4.5 patches quoted above are already +4 weeks old, could we
>>>> please get them into stable?
>>>
>>>
>>> For that, the maintainer would have needed to CC stable, which he
>>> didn't. I'd expect someone who cares to send these patches to stable.
>>> It'd be better if the maintainer would do it himself though.
>>
>>
>> sure, I can send the patches to stable (sorry if I missed to add
>> stable ML on CC).
>>
>> Andre, I have not clear if the train of patches actually fix the
>> issue or if you need my support to fix something else. In that case
>> I need some input for debugging (e.g. kernel log).
> 
> Bert already confirmed that those two patches fixes stmmac on his
> Lime2, so I assume that it fixes the issue for all A20 platforms.
> 
>> let me know, is it enough to re-send the patches only?
> 
> Just a resend with cc:stable :)

Not quite. Please read Documentation/stable_kernel_rules.txt, and the
section that concerns networking patches (and then consult
Documentation/networking/netdev-FAQ.txt which has all the details).

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Andre Heider]

Hi,

On Fri, May 20, 2016 at 12:36 PM, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org> wrote:
> On 20/05/16 11:30, Andre Heider wrote:
>> Hi,
>>
>> On Fri, May 20, 2016 at 10:14 AM, Giuseppe CAVALLARO
>> <peppe.cavallaro-qxv4g6HH51o@public.gmane.org> wrote:
>>> On 5/20/2016 9:56 AM, Marc Zyngier wrote:
>>>>
>>>> On 20/05/16 06:44, Andre Heider wrote:
>>>>>
>>>>> Giuseppe, Alexandre, et al.,
>>>>>
>>>>> On Thu, Mar 17, 2016 at 8:52 AM, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
>>>>> wrote:
>>>>>>
>>>>>> On Thu, 17 Mar 2016 00:56:40 +0100
>>>>>> Bert Lindner <bert-phGP8mJ4Mqk@public.gmane.org> wrote:
>>>>>>>
>>>>>>> On 2016-03-16 18:42, Marc Zyngier wrote:
>>>>>>>>
>>>>>>>> On 16/03/16 15:10, Bert Lindner wrote:
>>>>>>>>>
>>>>>>>>> On 2016-03-16 14:10, Andreas Färber wrote:
>>>>>>>>>>
>>>>>>>>>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>>>>>>>>>>>
>>>>>>>>>>> On 16/03/16 11:39, Marc Zyngier wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> On 16/03/16 11:19, Bert Lindner wrote:
>>>>>
>>>>> ...
>>>>>>>>>>>>>
>>>>>>>>>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a
>>>>>>>>>>>>> problem
>>>>>>>>>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>>>>>>>>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
>>>>>
>>>>> ...
>>>>>>>>>>>>>
>>>>>>>>>>>>> [    9.767125] NET: Registered protocol family 10
>>>>>>>>>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>>>>>>>>>>>> [   10.362382] eth0: Could not attach to PHY
>>>>>>>>>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
>>>>>
>>>>> ...
>>>>>>>>>>
>>>>>>>>>> v4 fixes for 4.5 are here:
>>>>>>>>>>
>>>>>>>>>> https://patchwork.ozlabs.org/patch/598195/ (revert)
>>>>>>>>>> https://patchwork.ozlabs.org/patch/598196/
>>>>>
>>>>> ...
>>>>>>>>
>>>>>>>> Good to know, thanks. Could you also give the potential fix a go (as
>>>>>>>> mentioned by Andreas)? Just to make sure that whatever gets merged
>>>>>>>> next
>>>>>>>> will actually fix the issue.
>>>>>>>
>>>>>>>
>>>>>>> Yes sure, it took a while because I had to travel. Confirmed, the
>>>>>>> v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:
>>>>>>>
>>>>>>> root@lime2-079f:~# cat /proc/version
>>>>>>> Linux version 4.5.0-598195-598196-v4 (root@lime2-079f) (gcc version
>>>>>>> 4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC
>>>>>>> 2016
>>>>>>>
>>>>>>> dmesg:
>>>>>>> [    8.245273] NET: Registered protocol family 10
>>>>>>> [    9.297406]  RX IPC Checksum Offload disabled
>>>>>>> [    9.297460]  No MAC Management Counters available
>>>>>>> [    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>>>>>> [   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>>>>>> 1Gbps/Full - flow control rx/tx
>>>>>>> [   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>>>>>
>>>>>>> The board is connected to my laptop rather than to a switch, so that
>>>>>>> might be where the flow control message comes from (not sure). Anyway
>>>>>>> ethernet works.
>>>>>>
>>>>>>
>>>>>> Cool, many thanks for taking the time to test and report.
>>>>>>
>>>>>> Hopefully Giuseppe will get this merged quickly enough in mainline, and
>>>>>> it should then trickle into a 4.5-stable release (cc-ing stable on
>>>>>> these patches would probably be a good idea, BTW).
>>>>>
>>>>>
>>>>> stmmac is broken on at least Lime2, BananaPi and Cubieboard2 since
>>>>> v4.5 [0], including all five stable releases :(
>>>>
>>>>
>>>> All the A20 platforms are dead, actually.
>>>>
>>>>> The v4.5 patches quoted above are already +4 weeks old, could we
>>>>> please get them into stable?
>>>>
>>>>
>>>> For that, the maintainer would have needed to CC stable, which he
>>>> didn't. I'd expect someone who cares to send these patches to stable.
>>>> It'd be better if the maintainer would do it himself though.
>>>
>>>
>>> sure, I can send the patches to stable (sorry if I missed to add
>>> stable ML on CC).
>>>
>>> Andre, I have not clear if the train of patches actually fix the
>>> issue or if you need my support to fix something else. In that case
>>> I need some input for debugging (e.g. kernel log).
>>
>> Bert already confirmed that those two patches fixes stmmac on his
>> Lime2, so I assume that it fixes the issue for all A20 platforms.
>>
>>> let me know, is it enough to re-send the patches only?
>>
>> Just a resend with cc:stable :)
>
> Not quite. Please read Documentation/stable_kernel_rules.txt, and the
> section that concerns networking patches (and then consult
> Documentation/networking/netdev-FAQ.txt which has all the details).

Right, it's just been a while since I sent a patch.
What I really meant was "do what's neccessary for -stable inclusion" :)

Regards,
Andre

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Bert Lindner]

Hi,

On 2016-05-20 12:36, Marc Zyngier wrote:
> On 20/05/16 11:30, Andre Heider wrote:
>> Hi,
>>
>> On Fri, May 20, 2016 at 10:14 AM, Giuseppe CAVALLARO
>> <peppe.cavallaro-qxv4g6HH51o@public.gmane.org> wrote:
>>> On 5/20/2016 9:56 AM, Marc Zyngier wrote:
>>>>
>>>> On 20/05/16 06:44, Andre Heider wrote:
>>>>>
>>>>> Giuseppe, Alexandre, et al.,
>>>>>
>>>>> On Thu, Mar 17, 2016 at 8:52 AM, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
>>>>> wrote:
>>>>>>
>>>>>> On Thu, 17 Mar 2016 00:56:40 +0100
>>>>>> Bert Lindner <bert-phGP8mJ4Mqk@public.gmane.org> wrote:
>>>>>>>
>>>>>>> On 2016-03-16 18:42, Marc Zyngier wrote:
>>>>>>>>
>>>>>>>> On 16/03/16 15:10, Bert Lindner wrote:
>>>>>>>>>
>>>>>>>>> On 2016-03-16 14:10, Andreas Färber wrote:
>>>>>>>>>>
>>>>>>>>>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>>>>>>>>>>>
>>>>>>>>>>> On 16/03/16 11:39, Marc Zyngier wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> On 16/03/16 11:19, Bert Lindner wrote:
>>>>>
>>>>> ...
>>>>>>>>>>>>>
>>>>>>>>>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a
>>>>>>>>>>>>> problem
>>>>>>>>>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>>>>>>>>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
>>>>>
>>>>> ...
>>>>>>>>>>>>>
>>>>>>>>>>>>> [    9.767125] NET: Registered protocol family 10
>>>>>>>>>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>>>>>>>>>>>> [   10.362382] eth0: Could not attach to PHY
>>>>>>>>>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
>>>>>
>>>>> ...
>>>>>>>>>>
>>>>>>>>>> v4 fixes for 4.5 are here:
>>>>>>>>>>
>>>>>>>>>> https://patchwork.ozlabs.org/patch/598195/ (revert)
>>>>>>>>>> https://patchwork.ozlabs.org/patch/598196/
>>>>>
>>>>> ...
>>>>>>>>
>>>>>>>> Good to know, thanks. Could you also give the potential fix a go (as
>>>>>>>> mentioned by Andreas)? Just to make sure that whatever gets merged
>>>>>>>> next
>>>>>>>> will actually fix the issue.
>>>>>>>
>>>>>>>
>>>>>>> Yes sure, it took a while because I had to travel. Confirmed, the
>>>>>>> v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:
>>>>>>>
>>>>>>> root@lime2-079f:~# cat /proc/version
>>>>>>> Linux version 4.5.0-598195-598196-v4 (root@lime2-079f) (gcc version
>>>>>>> 4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC
>>>>>>> 2016
>>>>>>>
>>>>>>> dmesg:
>>>>>>> [    8.245273] NET: Registered protocol family 10
>>>>>>> [    9.297406]  RX IPC Checksum Offload disabled
>>>>>>> [    9.297460]  No MAC Management Counters available
>>>>>>> [    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>>>>>> [   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>>>>>> 1Gbps/Full - flow control rx/tx
>>>>>>> [   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>>>>>
>>>>>>> The board is connected to my laptop rather than to a switch, so that
>>>>>>> might be where the flow control message comes from (not sure). Anyway
>>>>>>> ethernet works.
>>>>>>
>>>>>>
>>>>>> Cool, many thanks for taking the time to test and report.
>>>>>>
>>>>>> Hopefully Giuseppe will get this merged quickly enough in mainline, and
>>>>>> it should then trickle into a 4.5-stable release (cc-ing stable on
>>>>>> these patches would probably be a good idea, BTW).
>>>>>
>>>>>
>>>>> stmmac is broken on at least Lime2, BananaPi and Cubieboard2 since
>>>>> v4.5 [0], including all five stable releases :(
>>>>
>>>>
>>>> All the A20 platforms are dead, actually.
>>>>
>>>>> The v4.5 patches quoted above are already +4 weeks old, could we
>>>>> please get them into stable?
>>>>
>>>>
>>>> For that, the maintainer would have needed to CC stable, which he
>>>> didn't. I'd expect someone who cares to send these patches to stable.
>>>> It'd be better if the maintainer would do it himself though.
>>>
>>>
>>> sure, I can send the patches to stable (sorry if I missed to add
>>> stable ML on CC).
>>>
>>> Andre, I have not clear if the train of patches actually fix the
>>> issue or if you need my support to fix something else. In that case
>>> I need some input for debugging (e.g. kernel log).
>>
>> Bert already confirmed that those two patches fixes stmmac on his
>> Lime2, so I assume that it fixes the issue for all A20 platforms.
>>
>>> let me know, is it enough to re-send the patches only?
>>
>> Just a resend with cc:stable :)
>
> Not quite. Please read Documentation/stable_kernel_rules.txt, and the
> section that concerns networking patches (and then consult
> Documentation/networking/netdev-FAQ.txt which has all the details).

FWIW, recent 4.6-rc series and 4.6.0 have worked fine for me and the 
lime2. Had not tried 4.5.x again.

Best,

	-bert


-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Marc Zyngier]

On Sat, 21 May 2016 17:47:05 +0200
Bert Lindner <bert-phGP8mJ4Mqk@public.gmane.org> wrote:

> Hi,
> 
> On 2016-05-20 12:36, Marc Zyngier wrote:
> > On 20/05/16 11:30, Andre Heider wrote:
> >> Hi,
> >>
> >> On Fri, May 20, 2016 at 10:14 AM, Giuseppe CAVALLARO
> >> <peppe.cavallaro-qxv4g6HH51o@public.gmane.org> wrote:
> >>> On 5/20/2016 9:56 AM, Marc Zyngier wrote:
> >>>>
> >>>> On 20/05/16 06:44, Andre Heider wrote:
> >>>>>
> >>>>> Giuseppe, Alexandre, et al.,
> >>>>>
> >>>>> On Thu, Mar 17, 2016 at 8:52 AM, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
> >>>>> wrote:
> >>>>>>
> >>>>>> On Thu, 17 Mar 2016 00:56:40 +0100
> >>>>>> Bert Lindner <bert-phGP8mJ4Mqk@public.gmane.org> wrote:
> >>>>>>>
> >>>>>>> On 2016-03-16 18:42, Marc Zyngier wrote:
> >>>>>>>>
> >>>>>>>> On 16/03/16 15:10, Bert Lindner wrote:
> >>>>>>>>>
> >>>>>>>>> On 2016-03-16 14:10, Andreas Färber wrote:
> >>>>>>>>>>
> >>>>>>>>>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
> >>>>>>>>>>>
> >>>>>>>>>>> On 16/03/16 11:39, Marc Zyngier wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>> On 16/03/16 11:19, Bert Lindner wrote:
> >>>>>
> >>>>> ...
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a
> >>>>>>>>>>>>> problem
> >>>>>>>>>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
> >>>>>>>>>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
> >>>>>
> >>>>> ...
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> [    9.767125] NET: Registered protocol family 10
> >>>>>>>>>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
> >>>>>>>>>>>>> [   10.362382] eth0: Could not attach to PHY
> >>>>>>>>>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
> >>>>>
> >>>>> ...
> >>>>>>>>>>
> >>>>>>>>>> v4 fixes for 4.5 are here:
> >>>>>>>>>>
> >>>>>>>>>> https://patchwork.ozlabs.org/patch/598195/ (revert)
> >>>>>>>>>> https://patchwork.ozlabs.org/patch/598196/
> >>>>>
> >>>>> ...
> >>>>>>>>
> >>>>>>>> Good to know, thanks. Could you also give the potential fix a go (as
> >>>>>>>> mentioned by Andreas)? Just to make sure that whatever gets merged
> >>>>>>>> next
> >>>>>>>> will actually fix the issue.
> >>>>>>>
> >>>>>>>
> >>>>>>> Yes sure, it took a while because I had to travel. Confirmed, the
> >>>>>>> v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:
> >>>>>>>
> >>>>>>> root@lime2-079f:~# cat /proc/version
> >>>>>>> Linux version 4.5.0-598195-598196-v4 (root@lime2-079f) (gcc version
> >>>>>>> 4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC
> >>>>>>> 2016
> >>>>>>>
> >>>>>>> dmesg:
> >>>>>>> [    8.245273] NET: Registered protocol family 10
> >>>>>>> [    9.297406]  RX IPC Checksum Offload disabled
> >>>>>>> [    9.297460]  No MAC Management Counters available
> >>>>>>> [    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
> >>>>>>> [   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
> >>>>>>> 1Gbps/Full - flow control rx/tx
> >>>>>>> [   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
> >>>>>>>
> >>>>>>> The board is connected to my laptop rather than to a switch, so that
> >>>>>>> might be where the flow control message comes from (not sure). Anyway
> >>>>>>> ethernet works.
> >>>>>>
> >>>>>>
> >>>>>> Cool, many thanks for taking the time to test and report.
> >>>>>>
> >>>>>> Hopefully Giuseppe will get this merged quickly enough in mainline, and
> >>>>>> it should then trickle into a 4.5-stable release (cc-ing stable on
> >>>>>> these patches would probably be a good idea, BTW).
> >>>>>
> >>>>>
> >>>>> stmmac is broken on at least Lime2, BananaPi and Cubieboard2 since
> >>>>> v4.5 [0], including all five stable releases :(
> >>>>
> >>>>
> >>>> All the A20 platforms are dead, actually.
> >>>>
> >>>>> The v4.5 patches quoted above are already +4 weeks old, could we
> >>>>> please get them into stable?
> >>>>
> >>>>
> >>>> For that, the maintainer would have needed to CC stable, which he
> >>>> didn't. I'd expect someone who cares to send these patches to stable.
> >>>> It'd be better if the maintainer would do it himself though.
> >>>
> >>>
> >>> sure, I can send the patches to stable (sorry if I missed to add
> >>> stable ML on CC).
> >>>
> >>> Andre, I have not clear if the train of patches actually fix the
> >>> issue or if you need my support to fix something else. In that case
> >>> I need some input for debugging (e.g. kernel log).
> >>
> >> Bert already confirmed that those two patches fixes stmmac on his
> >> Lime2, so I assume that it fixes the issue for all A20 platforms.
> >>
> >>> let me know, is it enough to re-send the patches only?
> >>
> >> Just a resend with cc:stable :)
> >
> > Not quite. Please read Documentation/stable_kernel_rules.txt, and the
> > section that concerns networking patches (and then consult
> > Documentation/networking/netdev-FAQ.txt which has all the details).
> 
> FWIW, recent 4.6-rc series and 4.6.0 have worked fine for me and the 
> lime2. Had not tried 4.5.x again.

We've already established this. This is a 4.5-specific regression (both
4.4 and 4.6 are fine). One major issue is that Debian Stretch is
currently shipping with 4.5, and upgrading to it results in a system
without networking. Should this patch make it into stable, the fix would
quickly percolate into distro kernels, and we could forget about it.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

[Giuseppe CAVALLARO]

Hello

On 5/22/2016 11:30 AM, Marc Zyngier wrote:
> On Sat, 21 May 2016 17:47:05 +0200
> Bert Lindner <bert-phGP8mJ4Mqk@public.gmane.org> wrote:
>
>> Hi,
>>
>> On 2016-05-20 12:36, Marc Zyngier wrote:
>>> On 20/05/16 11:30, Andre Heider wrote:
>>>> Hi,
>>>>
>>>> On Fri, May 20, 2016 at 10:14 AM, Giuseppe CAVALLARO
>>>> <peppe.cavallaro-qxv4g6HH51o@public.gmane.org> wrote:
>>>>> On 5/20/2016 9:56 AM, Marc Zyngier wrote:
>>>>>>
>>>>>> On 20/05/16 06:44, Andre Heider wrote:
>>>>>>>
>>>>>>> Giuseppe, Alexandre, et al.,
>>>>>>>
>>>>>>> On Thu, Mar 17, 2016 at 8:52 AM, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>> On Thu, 17 Mar 2016 00:56:40 +0100
>>>>>>>> Bert Lindner <bert-phGP8mJ4Mqk@public.gmane.org> wrote:
>>>>>>>>>
>>>>>>>>> On 2016-03-16 18:42, Marc Zyngier wrote:
>>>>>>>>>>
>>>>>>>>>> On 16/03/16 15:10, Bert Lindner wrote:
>>>>>>>>>>>
>>>>>>>>>>> On 2016-03-16 14:10, Andreas Färber wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 16/03/16 11:39, Marc Zyngier wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On 16/03/16 11:19, Bert Lindner wrote:
>>>>>>>
>>>>>>> ...
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a
>>>>>>>>>>>>>>> problem
>>>>>>>>>>>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>>>>>>>>>>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
>>>>>>>
>>>>>>> ...
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> [    9.767125] NET: Registered protocol family 10
>>>>>>>>>>>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>>>>>>>>>>>>>> [   10.362382] eth0: Could not attach to PHY
>>>>>>>>>>>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
>>>>>>>
>>>>>>> ...
>>>>>>>>>>>>
>>>>>>>>>>>> v4 fixes for 4.5 are here:
>>>>>>>>>>>>
>>>>>>>>>>>> https://patchwork.ozlabs.org/patch/598195/ (revert)
>>>>>>>>>>>> https://patchwork.ozlabs.org/patch/598196/
>>>>>>>
>>>>>>> ...
>>>>>>>>>>
>>>>>>>>>> Good to know, thanks. Could you also give the potential fix a go (as
>>>>>>>>>> mentioned by Andreas)? Just to make sure that whatever gets merged
>>>>>>>>>> next
>>>>>>>>>> will actually fix the issue.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Yes sure, it took a while because I had to travel. Confirmed, the
>>>>>>>>> v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:
>>>>>>>>>
>>>>>>>>> root@lime2-079f:~# cat /proc/version
>>>>>>>>> Linux version 4.5.0-598195-598196-v4 (root@lime2-079f) (gcc version
>>>>>>>>> 4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC
>>>>>>>>> 2016
>>>>>>>>>
>>>>>>>>> dmesg:
>>>>>>>>> [    8.245273] NET: Registered protocol family 10
>>>>>>>>> [    9.297406]  RX IPC Checksum Offload disabled
>>>>>>>>> [    9.297460]  No MAC Management Counters available
>>>>>>>>> [    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>>>>>>>> [   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>>>>>>>> 1Gbps/Full - flow control rx/tx
>>>>>>>>> [   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>>>>>>>
>>>>>>>>> The board is connected to my laptop rather than to a switch, so that
>>>>>>>>> might be where the flow control message comes from (not sure). Anyway
>>>>>>>>> ethernet works.
>>>>>>>>
>>>>>>>>
>>>>>>>> Cool, many thanks for taking the time to test and report.
>>>>>>>>
>>>>>>>> Hopefully Giuseppe will get this merged quickly enough in mainline, and
>>>>>>>> it should then trickle into a 4.5-stable release (cc-ing stable on
>>>>>>>> these patches would probably be a good idea, BTW).
>>>>>>>
>>>>>>>
>>>>>>> stmmac is broken on at least Lime2, BananaPi and Cubieboard2 since
>>>>>>> v4.5 [0], including all five stable releases :(
>>>>>>
>>>>>>
>>>>>> All the A20 platforms are dead, actually.
>>>>>>
>>>>>>> The v4.5 patches quoted above are already +4 weeks old, could we
>>>>>>> please get them into stable?
>>>>>>
>>>>>>
>>>>>> For that, the maintainer would have needed to CC stable, which he
>>>>>> didn't. I'd expect someone who cares to send these patches to stable.
>>>>>> It'd be better if the maintainer would do it himself though.
>>>>>
>>>>>
>>>>> sure, I can send the patches to stable (sorry if I missed to add
>>>>> stable ML on CC).
>>>>>
>>>>> Andre, I have not clear if the train of patches actually fix the
>>>>> issue or if you need my support to fix something else. In that case
>>>>> I need some input for debugging (e.g. kernel log).
>>>>
>>>> Bert already confirmed that those two patches fixes stmmac on his
>>>> Lime2, so I assume that it fixes the issue for all A20 platforms.
>>>>
>>>>> let me know, is it enough to re-send the patches only?
>>>>
>>>> Just a resend with cc:stable :)
>>>
>>> Not quite. Please read Documentation/stable_kernel_rules.txt, and the
>>> section that concerns networking patches (and then consult
>>> Documentation/networking/netdev-FAQ.txt which has all the details).
>>
>> FWIW, recent 4.6-rc series and 4.6.0 have worked fine for me and the
>> lime2. Had not tried 4.5.x again.
>
> We've already established this. This is a 4.5-specific regression (both
> 4.4 and 4.6 are fine). One major issue is that Debian Stretch is
> currently shipping with 4.5, and upgrading to it results in a system
> without networking. Should this patch make it into stable, the fix would
> quickly percolate into distro kernels, and we could forget about it.

I have just ported and sent the patches to stable list.

   [PATCH 0/2 (linux-stable-4.5.y)] net: stmmac: MDIO fixes

Please, let me know if it is ok for you.

Peppe



> Thanks,
>
> 	M.
>

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.