* [iproute2 PATCH v2 1/1] tc simple action: bug fix
@ 2016-05-24 11:52 Jamal Hadi Salim
2016-05-24 11:52 ` [iproute2 PATCH v2 1/1] vv4.6.0 Jamal Hadi Salim
0 siblings, 1 reply; 3+ messages in thread
From: Jamal Hadi Salim @ 2016-05-24 11:52 UTC (permalink / raw)
To: stephen; +Cc: netdev, daniel, Jamal Hadi Salim
From: Jamal Hadi Salim <jhs@mojatatu.com>
Failed compile
m_simple.c: In function ‘parse_simple’:
m_simple.c:154:6: warning: too many arguments for format [-Wformat-extra-args]
*argv);
^
m_simple.c:103:14: warning: unused variable ‘maybe_bind’ [-Wunused-variable]
Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
tc/m_simple.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tc/m_simple.c b/tc/m_simple.c
index feba61b..27b3e5e 100644
--- a/tc/m_simple.c
+++ b/tc/m_simple.c
@@ -100,7 +100,7 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
struct tc_defact sel = {};
int argc = *argc_p;
char **argv = *argv_p;
- int ok = 0, maybe_bind = 0;
+ int ok = 0;
struct rtattr *tail;
char *simpdata = NULL;
@@ -150,7 +150,7 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
if (matches(*argv, "index") == 0) {
NEXT_ARG();
if (get_u32(&sel.index, *argv, 10)) {
- fprintf(stderr, "simple: Illegal \"index\"\n",
+ fprintf(stderr, "simple: Illegal \"index\" (%s)\n",
*argv);
return -1;
}
@@ -171,7 +171,6 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
return -1;
}
-
sel.action = TC_ACT_PIPE;
tail = NLMSG_TAIL(n);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [iproute2 PATCH v2 1/1] vv4.6.0
2016-05-24 11:52 [iproute2 PATCH v2 1/1] tc simple action: bug fix Jamal Hadi Salim
@ 2016-05-24 11:52 ` Jamal Hadi Salim
2016-05-24 12:16 ` Jamal Hadi Salim
0 siblings, 1 reply; 3+ messages in thread
From: Jamal Hadi Salim @ 2016-05-24 11:52 UTC (permalink / raw)
To: stephen; +Cc: netdev, daniel, Stephen Hemminger
From: Stephen Hemminger <shemming@brocade.com>
---
include/SNAPSHOT.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/SNAPSHOT.h b/include/SNAPSHOT.h
index 9220f77..cc67058 100644
--- a/include/SNAPSHOT.h
+++ b/include/SNAPSHOT.h
@@ -1 +1 @@
-static const char SNAPSHOT[] = "160314";
+static const char SNAPSHOT[] = "160518";
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [iproute2 PATCH v2 1/1] vv4.6.0
2016-05-24 11:52 ` [iproute2 PATCH v2 1/1] vv4.6.0 Jamal Hadi Salim
@ 2016-05-24 12:16 ` Jamal Hadi Salim
0 siblings, 0 replies; 3+ messages in thread
From: Jamal Hadi Salim @ 2016-05-24 12:16 UTC (permalink / raw)
To: stephen; +Cc: netdev, daniel, Stephen Hemminger
More git foo. I have no idea how this went out ;->
Please ignore this but not the other.
cheers,
jamal
On 16-05-24 07:52 AM, Jamal Hadi Salim wrote:
> From: Stephen Hemminger <shemming@brocade.com>
>
> ---
> include/SNAPSHOT.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/SNAPSHOT.h b/include/SNAPSHOT.h
> index 9220f77..cc67058 100644
> --- a/include/SNAPSHOT.h
> +++ b/include/SNAPSHOT.h
> @@ -1 +1 @@
> -static const char SNAPSHOT[] = "160314";
> +static const char SNAPSHOT[] = "160518";
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-24 12:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-24 11:52 [iproute2 PATCH v2 1/1] tc simple action: bug fix Jamal Hadi Salim
2016-05-24 11:52 ` [iproute2 PATCH v2 1/1] vv4.6.0 Jamal Hadi Salim
2016-05-24 12:16 ` Jamal Hadi Salim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox