From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Vincent Bernat <vincent@bernat.im>
Cc: "David S. Miller" <davem@davemloft.net>,
Vijay Pandurangan <vijayp@vijayp.ca>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [net v3] veth: advertise peer link once both links are tied together
Date: Tue, 31 May 2016 11:17:20 +0200 [thread overview]
Message-ID: <574D56A0.3090606@6wind.com> (raw)
In-Reply-To: <m3fusyg2pi.fsf@neo.luffy.cx>
Le 31/05/2016 08:29, Vincent Bernat a écrit :
> ❦ 30 mai 2016 18:27 CEST, Nicolas Dichtel <nicolas.dichtel@6wind.com> :
>
>>>> +
>>>> + rtmsg_ifinfo(RTM_NEWLINK, peer, IFF_SLAVE, GFP_KERNEL);
>>>
>>> Maybe ~0U would be better than hijacking IFF_SLAVE?
>> IFF_SLAVE is wrong. It's a flag here, that will be put in the ifi_change field
>> not an attribute number.
>
> There are some use of IFF_SLAVE (in bonding/bond_main.c). But, I'll
> update the patch nonetheless.
Sorry, I read it too quickly, IFF_SLAVE is a flag, not an attribute.
But this field indicates to the userland which flags has changed and this flag
does not change here ;-)
next prev parent reply other threads:[~2016-05-31 9:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 11:17 [PATCH] veth: delay peer link configuration after interfaces are tied Vincent Bernat
2016-05-30 9:23 ` Nicolas Dichtel
2016-05-30 10:11 ` Vincent Bernat
2016-05-30 15:19 ` Nicolas Dichtel
2016-05-30 15:26 ` Vincent Bernat
2016-05-30 15:47 ` Nicolas Dichtel
2016-05-30 15:58 ` [net v3] veth: advertise peer link once both links are tied together Vincent Bernat
2016-05-30 16:01 ` Vincent Bernat
2016-05-30 16:27 ` Nicolas Dichtel
2016-05-31 6:29 ` Vincent Bernat
2016-05-31 9:17 ` Nicolas Dichtel [this message]
2016-06-08 20:30 ` Lance Richardson
2016-06-10 13:15 ` Nicolas Dichtel
2016-06-10 13:20 ` Lance Richardson
2016-05-31 6:30 ` [net v4] " Vincent Bernat
2016-05-31 6:54 ` Vincent Bernat
2016-05-30 10:12 ` [PATCH] veth: delay peer link configuration after interfaces are tied Vincent Bernat
2016-05-30 10:14 ` Vincent Bernat
2016-05-30 10:13 ` Vincent Bernat
2016-05-30 15:19 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574D56A0.3090606@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vijayp@vijayp.ca \
--cc=vincent@bernat.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).