From: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>, netdev@vger.kernel.org
Cc: hideaki.yoshifuji@miraclelinux.com
Subject: Re: [PATCH iputils 5/6] tftpd: fix syslog setup
Date: Thu, 2 Jun 2016 17:31:50 +0900 [thread overview]
Message-ID: <574FEEF6.1080109@miraclelinux.com> (raw)
In-Reply-To: <20160602043308.GM7717@vapier.lan>
Hi,
Mike Frysinger wrote:
> On 02 Jun 2016 11:10, YOSHIFUJI Hideaki wrote:
>> Mike Frysinger wrote:
>>> Commit d81a44625b04d487c895473aa77af13420b7afdd added support for checking
>>> the set*id calls, but would call syslog() before it had called openlog().
>>> Move the call up earlier to fix that.
>>
>> Please describe what it really fixes.
>
> i already did: you need to call openlog before calling syslog, but the
> code here very clearly doesn't. if you read the commit i referenced,
> and the all <25 lines of context here, it should be pretty obvious the
> code is wrong.
> -mike
>
OK, applied. Thank you.
--
Hideaki Yoshifuji <hideaki.yoshifuji@miraclelinux.com>
Technical Division, MIRACLE LINUX CORPORATION
next prev parent reply other threads:[~2016-06-02 8:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 3:48 [PATCH iputils 1/6] start gitignore files Mike Frysinger
2016-06-01 3:48 ` [PATCH iputils 2/6] doc: fix parallel build of html/man pages Mike Frysinger
2016-06-02 2:39 ` YOSHIFUJI Hideaki
2016-06-01 3:48 ` [PATCH iputils 3/6] ping6: allow disabling of openssl support Mike Frysinger
2016-06-02 2:04 ` YOSHIFUJI Hideaki
2016-06-02 4:59 ` [PATCH iputils v2] ping6: allow disabling of openssl/libgcrypt support Mike Frysinger
2016-06-02 8:49 ` YOSHIFUJI Hideaki
2016-06-02 13:38 ` Mike Frysinger
2016-06-02 17:16 ` [PATCH iputils v3] " Mike Frysinger
2016-06-01 3:48 ` [PATCH iputils 4/6] fix handling of CFLAGS Mike Frysinger
2016-06-02 2:35 ` YOSHIFUJI Hideaki
2016-06-01 3:48 ` [PATCH iputils 5/6] tftpd: fix syslog setup Mike Frysinger
2016-06-02 2:10 ` YOSHIFUJI Hideaki
2016-06-02 4:33 ` Mike Frysinger
2016-06-02 8:31 ` YOSHIFUJI Hideaki [this message]
2016-06-01 3:48 ` [PATCH iputils 6/6] ping: fix -i number parsing in locales Mike Frysinger
2016-06-02 2:08 ` YOSHIFUJI Hideaki
2016-06-02 4:46 ` [PATCH iputils v2] ping: always accept . delimiter with -i number parsing Mike Frysinger
2016-06-02 8:28 ` YOSHIFUJI Hideaki
2016-06-02 2:06 ` [PATCH iputils 1/6] start gitignore files YOSHIFUJI Hideaki
2016-06-02 4:42 ` Mike Frysinger
2016-06-02 8:57 ` YOSHIFUJI Hideaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574FEEF6.1080109@miraclelinux.com \
--to=hideaki.yoshifuji@miraclelinux.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).