From: Heiner Kallweit <hkallweit1@gmail.com>
To: David Miller <davem@davemloft.net>, shawn.lin@rock-chips.com
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org
Subject: Re: [PATCH] r8169: Add new device ID support
Date: Wed, 24 Oct 2018 23:44:10 +0200 [thread overview]
Message-ID: <574ea4d9-6095-ecd9-e12b-e5801fdcf343@gmail.com> (raw)
In-Reply-To: <20181024.142234.2286757776208469261.davem@davemloft.net>
On 24.10.2018 23:22, David Miller wrote:
> From: Shawn Lin <shawn.lin@rock-chips.com>
> Date: Wed, 24 Oct 2018 09:46:47 +0800
>
>> It's found my r8169 ethernet card at hand has a device ID
>> of 0x0000 which wasn't on the list of rtl8169_pci_tbl. Add
>> a new entry to make it work:
>>
>> [2.165785] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
>> [2.165863] r8169 0000:01:00.0: enabling device (0000 -> 0003)
>> [2.167110] r8169 0000:01:00.0 eth0: RTL8168c/8111c at 0xffffff80089be000,
>> 00:e0:4c:21:00:17, XID 1c4000c0 IRQ 208
>> [2.167128] r8169 0000:01:00.0 eth0: jumbo features [frames: 6128
>> bytes, tx checksumming: ko]
>>
>> [root@rk1808:/]# lspci
>> 00:00.0 Class 0604: 1d87:1808
>> 01:00.0 Class 0200: 10ec:0000
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> I'm stil not terribly confident in this change, a device ID of zero is
> really unusual.
>
> Heiner, what do you think?
>
A PCI device ID of zero definitely is a mistake of the card vendor.
Or maybe the card was just a sample and not meant to retail?
If some vendor of cards with a different Realtek network chip makes
the same mistake, then we're in trouble. I don't think we should
accept this risk just to support a broken ancient card.
This card most likely is at least 10 years old, and that we get the
first report only now seems to indicate that it's not something
affecting a lot of people.
The reporter found a way to make the card work on his system,
so I don't see a need for any further action.
prev parent reply other threads:[~2018-10-25 6:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1540345607-110155-1-git-send-email-shawn.lin@rock-chips.com>
2018-10-24 2:19 ` [PATCH] r8169: Add new device ID support David Miller
2018-10-24 5:48 ` Shawn Lin
2018-10-24 5:54 ` David Miller
2018-10-24 6:29 ` Shawn Lin
2018-10-24 15:47 ` Stephen Hemminger
2018-10-24 21:22 ` David Miller
2018-10-24 21:44 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574ea4d9-6095-ecd9-e12b-e5801fdcf343@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).