* Re: [PATCH] r8169: Add new device ID support [not found] <1540345607-110155-1-git-send-email-shawn.lin@rock-chips.com> @ 2018-10-24 2:19 ` David Miller 2018-10-24 5:48 ` Shawn Lin 2018-10-24 21:22 ` David Miller 1 sibling, 1 reply; 7+ messages in thread From: David Miller @ 2018-10-24 2:19 UTC (permalink / raw) To: shawn.lin; +Cc: nic_swsd, netdev From: Shawn Lin <shawn.lin@rock-chips.com> Date: Wed, 24 Oct 2018 09:46:47 +0800 > It's found my r8169 ethernet card at hand has a device ID > of 0x0000 which wasn't on the list of rtl8169_pci_tbl. Add > a new entry to make it work: ... > 01:00.0 Class 0200: 10ec:0000 I don't know about this. A value of zero could mean the device is mis-responding to PCI config space requests or something like that. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] r8169: Add new device ID support 2018-10-24 2:19 ` [PATCH] r8169: Add new device ID support David Miller @ 2018-10-24 5:48 ` Shawn Lin 2018-10-24 5:54 ` David Miller 0 siblings, 1 reply; 7+ messages in thread From: Shawn Lin @ 2018-10-24 5:48 UTC (permalink / raw) To: David Miller; +Cc: shawn.lin, nic_swsd, netdev Hi David, On 2018/10/24 10:19, David Miller wrote: > From: Shawn Lin <shawn.lin@rock-chips.com> > Date: Wed, 24 Oct 2018 09:46:47 +0800 > >> It's found my r8169 ethernet card at hand has a device ID >> of 0x0000 which wasn't on the list of rtl8169_pci_tbl. Add >> a new entry to make it work: > ... >> 01:00.0 Class 0200: 10ec:0000 > > I don't know about this. > > A value of zero could mean the device is mis-responding to > PCI config space requests or something like that. It was working fine on my retired Windows XP home PC with same devcice ID listed, so I guess r8169 driver for windows system knows 0x0000 is also valid. > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] r8169: Add new device ID support 2018-10-24 5:48 ` Shawn Lin @ 2018-10-24 5:54 ` David Miller 2018-10-24 6:29 ` Shawn Lin 0 siblings, 1 reply; 7+ messages in thread From: David Miller @ 2018-10-24 5:54 UTC (permalink / raw) To: shawn.lin; +Cc: nic_swsd, netdev From: Shawn Lin <shawn.lin@rock-chips.com> Date: Wed, 24 Oct 2018 13:48:55 +0800 > Hi David, > > On 2018/10/24 10:19, David Miller wrote: >> From: Shawn Lin <shawn.lin@rock-chips.com> >> Date: Wed, 24 Oct 2018 09:46:47 +0800 >> >>> It's found my r8169 ethernet card at hand has a device ID >>> of 0x0000 which wasn't on the list of rtl8169_pci_tbl. Add >>> a new entry to make it work: >> ... >>> 01:00.0 Class 0200: 10ec:0000 >> I don't know about this. >> A value of zero could mean the device is mis-responding to >> PCI config space requests or something like that. > > It was working fine on my retired Windows XP home PC with same devcice > ID listed, so I guess r8169 driver for windows system knows 0x0000 is > also valid. It is also possible the device comes up in a different state. Under windows does it show with that device ID of zero? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] r8169: Add new device ID support 2018-10-24 5:54 ` David Miller @ 2018-10-24 6:29 ` Shawn Lin 2018-10-24 15:47 ` Stephen Hemminger 0 siblings, 1 reply; 7+ messages in thread From: Shawn Lin @ 2018-10-24 6:29 UTC (permalink / raw) To: David Miller; +Cc: shawn.lin, nic_swsd, netdev On 2018/10/24 13:54, David Miller wrote: > From: Shawn Lin <shawn.lin@rock-chips.com> > Date: Wed, 24 Oct 2018 13:48:55 +0800 > >> Hi David, >> >> On 2018/10/24 10:19, David Miller wrote: >>> From: Shawn Lin <shawn.lin@rock-chips.com> >>> Date: Wed, 24 Oct 2018 09:46:47 +0800 >>> >>>> It's found my r8169 ethernet card at hand has a device ID >>>> of 0x0000 which wasn't on the list of rtl8169_pci_tbl. Add >>>> a new entry to make it work: >>> ... >>>> 01:00.0 Class 0200: 10ec:0000 >>> I don't know about this. >>> A value of zero could mean the device is mis-responding to >>> PCI config space requests or something like that. >> >> It was working fine on my retired Windows XP home PC with same devcice >> ID listed, so I guess r8169 driver for windows system knows 0x0000 is >> also valid. > > It is also possible the device comes up in a different state. > > Under windows does it show with that device ID of zero? yup. More precisely, I checked how BIOS enumerate it by PCIe analyzer and see it does report 0x0000 as device ID. > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] r8169: Add new device ID support 2018-10-24 6:29 ` Shawn Lin @ 2018-10-24 15:47 ` Stephen Hemminger 0 siblings, 0 replies; 7+ messages in thread From: Stephen Hemminger @ 2018-10-24 15:47 UTC (permalink / raw) To: Shawn Lin; +Cc: David Miller, nic_swsd, netdev On Wed, 24 Oct 2018 14:29:34 +0800 Shawn Lin <shawn.lin@rock-chips.com> wrote: > On 2018/10/24 13:54, David Miller wrote: > > From: Shawn Lin <shawn.lin@rock-chips.com> > > Date: Wed, 24 Oct 2018 13:48:55 +0800 > > > >> Hi David, > >> > >> On 2018/10/24 10:19, David Miller wrote: > >>> From: Shawn Lin <shawn.lin@rock-chips.com> > >>> Date: Wed, 24 Oct 2018 09:46:47 +0800 > >>> > >>>> It's found my r8169 ethernet card at hand has a device ID > >>>> of 0x0000 which wasn't on the list of rtl8169_pci_tbl. Add > >>>> a new entry to make it work: > >>> ... > >>>> 01:00.0 Class 0200: 10ec:0000 > >>> I don't know about this. > >>> A value of zero could mean the device is mis-responding to > >>> PCI config space requests or something like that. > >> > >> It was working fine on my retired Windows XP home PC with same devcice > >> ID listed, so I guess r8169 driver for windows system knows 0x0000 is > >> also valid. > > > > It is also possible the device comes up in a different state. > > > > Under windows does it show with that device ID of zero? > > yup. More precisely, I checked how BIOS enumerate it by PCIe analyzer > and see it does report 0x0000 as device ID. > > > > > > > > Look at device manager properties of the device in Windows? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] r8169: Add new device ID support [not found] <1540345607-110155-1-git-send-email-shawn.lin@rock-chips.com> 2018-10-24 2:19 ` [PATCH] r8169: Add new device ID support David Miller @ 2018-10-24 21:22 ` David Miller 2018-10-24 21:44 ` Heiner Kallweit 1 sibling, 1 reply; 7+ messages in thread From: David Miller @ 2018-10-24 21:22 UTC (permalink / raw) To: shawn.lin; +Cc: nic_swsd, netdev, hkallweit1 From: Shawn Lin <shawn.lin@rock-chips.com> Date: Wed, 24 Oct 2018 09:46:47 +0800 > It's found my r8169 ethernet card at hand has a device ID > of 0x0000 which wasn't on the list of rtl8169_pci_tbl. Add > a new entry to make it work: > > [2.165785] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded > [2.165863] r8169 0000:01:00.0: enabling device (0000 -> 0003) > [2.167110] r8169 0000:01:00.0 eth0: RTL8168c/8111c at 0xffffff80089be000, > 00:e0:4c:21:00:17, XID 1c4000c0 IRQ 208 > [2.167128] r8169 0000:01:00.0 eth0: jumbo features [frames: 6128 > bytes, tx checksumming: ko] > > [root@rk1808:/]# lspci > 00:00.0 Class 0604: 1d87:1808 > 01:00.0 Class 0200: 10ec:0000 > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> I'm stil not terribly confident in this change, a device ID of zero is really unusual. Heiner, what do you think? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] r8169: Add new device ID support 2018-10-24 21:22 ` David Miller @ 2018-10-24 21:44 ` Heiner Kallweit 0 siblings, 0 replies; 7+ messages in thread From: Heiner Kallweit @ 2018-10-24 21:44 UTC (permalink / raw) To: David Miller, shawn.lin; +Cc: nic_swsd, netdev On 24.10.2018 23:22, David Miller wrote: > From: Shawn Lin <shawn.lin@rock-chips.com> > Date: Wed, 24 Oct 2018 09:46:47 +0800 > >> It's found my r8169 ethernet card at hand has a device ID >> of 0x0000 which wasn't on the list of rtl8169_pci_tbl. Add >> a new entry to make it work: >> >> [2.165785] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded >> [2.165863] r8169 0000:01:00.0: enabling device (0000 -> 0003) >> [2.167110] r8169 0000:01:00.0 eth0: RTL8168c/8111c at 0xffffff80089be000, >> 00:e0:4c:21:00:17, XID 1c4000c0 IRQ 208 >> [2.167128] r8169 0000:01:00.0 eth0: jumbo features [frames: 6128 >> bytes, tx checksumming: ko] >> >> [root@rk1808:/]# lspci >> 00:00.0 Class 0604: 1d87:1808 >> 01:00.0 Class 0200: 10ec:0000 >> >> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > > I'm stil not terribly confident in this change, a device ID of zero is > really unusual. > > Heiner, what do you think? > A PCI device ID of zero definitely is a mistake of the card vendor. Or maybe the card was just a sample and not meant to retail? If some vendor of cards with a different Realtek network chip makes the same mistake, then we're in trouble. I don't think we should accept this risk just to support a broken ancient card. This card most likely is at least 10 years old, and that we get the first report only now seems to indicate that it's not something affecting a lot of people. The reporter found a way to make the card work on his system, so I don't see a need for any further action. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-25 6:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1540345607-110155-1-git-send-email-shawn.lin@rock-chips.com>
2018-10-24 2:19 ` [PATCH] r8169: Add new device ID support David Miller
2018-10-24 5:48 ` Shawn Lin
2018-10-24 5:54 ` David Miller
2018-10-24 6:29 ` Shawn Lin
2018-10-24 15:47 ` Stephen Hemminger
2018-10-24 21:22 ` David Miller
2018-10-24 21:44 ` Heiner Kallweit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).