From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helge Deller Subject: Re: [PATCH] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF Date: Fri, 3 Jun 2016 23:09:41 +0200 Message-ID: <5751F215.6080207@gmx.de> References: <20160603171805.GA3664@ls3530.box> <4cec14e5-2950-be26-1ffa-8d604bdb2fb5@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "linux-parisc@vger.kernel.org" To: Sergei Shtylyov , Craig Gallek , Alexei Starovoitov , "David S. Miller" , "netdev@vger.kernel.org" Return-path: In-Reply-To: <4cec14e5-2950-be26-1ffa-8d604bdb2fb5@cogentembedded.com> Sender: linux-parisc-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 03.06.2016 20:11, Sergei Shtylyov wrote: > Hello. > > On 06/03/2016 08:18 PM, Helge Deller wrote: > >> Commit 538950a ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") > > At least 12 digits must be specified for SHA1. checkpatch.pl should've caught this. Ok. >> missed to add the compat case for the SO_ATTACH_REUSEPORT_CBPF >> setsockoption() option. >> >> Since both SO_ATTACH_FILTER and SO_ATTACH_REUSEPORT_CBPF use a struct >> sock_fprog let's combine the handling of both. >> >> Signed-off-by: Helge Deller >> >> diff --git a/net/compat.c b/net/compat.c >> index 5cfd26a..7e2aac9 100644 >> --- a/net/compat.c >> +++ b/net/compat.c >> @@ -309,7 +309,7 @@ void scm_detach_fds_compat(struct msghdr *kmsg, struct scm_cookie *scm) >> __scm_destroy(scm); >> } >> >> -static int do_set_attach_filter(struct socket *sock, int level, int optname, >> +static int do_sockopt_fix_sock_fprog(struct socket *sock, int level, int optname, >> char __user *optval, unsigned int optlen) > > You need to realign this line now. Sure, I will send an updated patch. Any idea for a better naming than "do_sockopt_fix_sock_fprog()" ? Helge