netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Du, Fan" <fan.du@intel.com>
To: Yuval Mintz <Yuval.Mintz@qlogic.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: GSO packets on lower MTU retaining gso_size?
Date: Tue, 07 Jun 2016 14:46:06 +0800	[thread overview]
Message-ID: <57566DAE.4010609@intel.com> (raw)
In-Reply-To: <CO2PR11MB008861B24F9DA5CBA56F58C8975D0@CO2PR11MB0088.namprd11.prod.outlook.com>



On 2016/6/7 14:05, Yuval Mintz wrote:
> While experimenting with Vxlan tunnels, I've reached a topology where the
> Vxlan interface's MTU was 1500 while base-interface was smaller [600].
>
> While 'regular' packets broke via ip-fragmentation, GSO SKBs passing from
> the vxlan interface to the base interface remained whole, and their
> `gso_size' remained matching to that of the vxlan-interface's MTU;
> This caused the HW to drop said packets, as it would have resulted with
> the device sending to the line packets with length larger than the mtu.
>
> Is this broken on the udp-tunnel transmit path, the setup or the driver [qede]?

I believe it's identical to issue I met before[1], the owner of the 
offending code
believe a host can't generate packet size larger than the underlying NIC 
MTU and
refuse to do the GSO here.

[1]: https://patchwork.ozlabs.org/patch/415791/

      reply	other threads:[~2016-06-07  6:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07  6:05 GSO packets on lower MTU retaining gso_size? Yuval Mintz
2016-06-07  6:46 ` Du, Fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57566DAE.4010609@intel.com \
    --to=fan.du@intel.com \
    --cc=Yuval.Mintz@qlogic.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).