From: John Fastabend <john.fastabend@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: sched: fix tc_should_offload for specific clsact classes
Date: Tue, 7 Jun 2016 08:31:10 -0700 [thread overview]
Message-ID: <5756E8BE.7090503@gmail.com> (raw)
In-Reply-To: <6eb47dcc252d843d7338ce2c9b98f667b45c8450.1465245985.git.daniel@iogearbox.net>
On 16-06-06 01:50 PM, Daniel Borkmann wrote:
> When offloading classifiers such as u32 or flower to hardware, and the
> qdisc is clsact (TC_H_CLSACT), then we need to differentiate its classes,
> since not all of them handle ingress, therefore we must leave those in
> software path. Add a .tcf_cl_offload() callback, so we can generically
> handle them, tested on ixgbe.
>
> Fixes: 10cbc6843446 ("net/sched: cls_flower: Hardware offloaded filters statistics support")
> Fixes: 5b33f48842fa ("net/flower: Introduce hardware offload support")
> Fixes: a1b7c5fd7fe9 ("net: sched: add cls_u32 offload hooks for netdevs")
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> ---
Looks good to me. Thanks!
Acked-by: John Fastabend <john.r.fastabend@intel.com>
next prev parent reply other threads:[~2016-06-07 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 20:50 [PATCH net] net: sched: fix tc_should_offload for specific clsact classes Daniel Borkmann
2016-06-07 15:31 ` John Fastabend [this message]
2016-06-08 0:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756E8BE.7090503@gmail.com \
--to=john.fastabend@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).