From: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
netdev@vger.kernel.org, hideaki@yoshifuji.org
Cc: hideaki.yoshifuji@miraclelinux.com
Subject: Re: [PATCH] ping: ICMP error replies while errno < 0 is a hard error
Date: Wed, 8 Jun 2016 10:53:43 +0900 [thread overview]
Message-ID: <57577AA7.10005@miraclelinux.com> (raw)
In-Reply-To: <20160607120522.9474-1-Jason@zx2c4.com>
Hi,
Jason A. Donenfeld wrote:
> There are some odd conditions in which a device will return an error for
> sendto, while at the same time an ICMP error response is generated. In
> this case, with the current code, the packet is retransmitted in a
> flood, which is not what anybody wants. In fact, when these two
> conditions occur, we want to treat the packet as a "hard local error"
> and do the ordinary pause as before. The reasoning is that if we did
> receive an ICMP error message, then the packet was transmitted, and so
> it should be accounted for. But, since we also received an errno, this
> should be reported to the user, as something is wonky with their network
> interface.
>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Applied. Thank you.
--
Hideaki Yoshifuji <hideaki.yoshifuji@miraclelinux.com>
Technical Division, MIRACLE LINUX CORPORATION
prev parent reply other threads:[~2016-06-08 1:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 12:05 [PATCH] ping: ICMP error replies while errno < 0 is a hard error Jason A. Donenfeld
2016-06-08 1:53 ` YOSHIFUJI Hideaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57577AA7.10005@miraclelinux.com \
--to=hideaki.yoshifuji@miraclelinux.com \
--cc=Jason@zx2c4.com \
--cc=hideaki@yoshifuji.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).