From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com, fw@strlen.de
Subject: Re: [net-next PATCH v2 1/1] net sched actions: skbedit add support for mod-ing skb pkt_type
Date: Mon, 13 Jun 2016 17:52:47 -0400 [thread overview]
Message-ID: <575F2B2F.2030104@mojatatu.com> (raw)
In-Reply-To: <575EA537.9010807@iogearbox.net>
On 16-06-13 08:21 AM, Daniel Borkmann wrote:
>
> Looks like nft_meta_set_eval() can already do that, but restricted
> via pkt_type_ok(), so we can't play bad games with PACKET_LOOPBACK
> et al. Wasn't aware of that. Hm, so if you want to make use of this
> from tc as well, probably it makes sense to add a generic helper as
> in skb_pkt_type_mangle() and place it into skbuff.h?
>
Ok, will do with next update.
cheers,
jamal
prev parent reply other threads:[~2016-06-13 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 21:24 [net-next PATCH v2 1/1] net sched actions: skbedit add support for mod-ing skb pkt_type Jamal Hadi Salim
2016-06-13 8:00 ` Daniel Borkmann
2016-06-13 11:52 ` Jamal Hadi Salim
2016-06-13 12:21 ` Daniel Borkmann
2016-06-13 21:52 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575F2B2F.2030104@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).