From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next 00/10] net_sched: defer skb freeing while changing qdiscs
Date: Wed, 15 Jun 2016 07:43:03 -0400 [thread overview]
Message-ID: <57613F47.9060106@mojatatu.com> (raw)
In-Reply-To: <1465874519-25494-1-git-send-email-edumazet@google.com>
On 16-06-13 11:21 PM, Eric Dumazet wrote:
> qdiscs/classes are changed under RTNL protection and often
> while blocking BH and root qdisc spinlock.
>
> When lots of skbs need to be dropped, we free
> them under these locks causing TX/RX freezes,
> and more generally latency spikes.
>
> I saw spikes of 50+ ms on quite fast hardware...
>
> This patch series adds a simple queue protected by RTNL
> where skbs can be placed until RTNL is released.
>
> Note that this might also serve in the future for optional
> reinjection of packets when a qdisc is replaced.
>
Nice optimization Eric.
cheers,
jamal
next prev parent reply other threads:[~2016-06-15 11:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 3:21 [PATCH net-next 00/10] net_sched: defer skb freeing while changing qdiscs Eric Dumazet
2016-06-14 3:21 ` [PATCH net-next 01/10] net_sched: add the ability to defer skb freeing Eric Dumazet
2016-06-15 12:33 ` Jesper Dangaard Brouer
2016-06-15 12:39 ` Eric Dumazet
2016-06-14 3:21 ` [PATCH net-next 02/10] net_sched: sch_choke: " Eric Dumazet
2016-06-14 3:21 ` [PATCH net-next 03/10] net_sched: sch_codel: defer skb freeing in codel_change() Eric Dumazet
2016-06-14 3:21 ` [PATCH net-next 04/10] net_sched: sch_fq: defer skb freeing Eric Dumazet
2016-06-14 3:21 ` [PATCH net-next 05/10] net_sched: fq_codel: " Eric Dumazet
2016-06-14 3:21 ` [PATCH net-next 06/10] net_sched: sch_hhf: " Eric Dumazet
2016-06-14 3:21 ` [PATCH net-next 07/10] net_sched: sch_htb: " Eric Dumazet
2016-06-14 3:21 ` [PATCH net-next 08/10] net_sched: sch_netem: " Eric Dumazet
2016-06-14 3:21 ` [PATCH net-next 09/10] net_sched: sch_pie: " Eric Dumazet
2016-06-14 3:21 ` [PATCH net-next 10/10] net_sched: sch_fq: " Eric Dumazet
2016-06-15 2:13 ` [PATCH net-next 00/10] net_sched: defer skb freeing while changing qdiscs Cong Wang
2016-06-15 4:20 ` Eric Dumazet
2016-06-15 11:43 ` Jamal Hadi Salim [this message]
2016-06-15 21:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57613F47.9060106@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).