From: peter enderborg <peter.enderborg@sonymobile.com>
To: "open list:PTP HARDWARE CLOCK SUPPORT" <netdev@vger.kernel.org>
Subject: [PATCH resend] net: sock: Add option for memory optimized hints.
Date: Fri, 17 Jun 2016 15:58:28 +0200 [thread overview]
Message-ID: <57640204.9070300@sonymobile.com> (raw)
From: Peter Enderborg <peter.enderborg@sonymobile.com>
When sending data the socket allocates memory for
payload on a cache or a page alloc. The page alloc
then might trigger compation that takes long time.
This can be avoided with smaller chunks. But
userspace can not know what is the right size for
the smaller sends. For this we add a SIZEHINT
getsocketopt where the userspace can get the size
for send that will fit into one page (order 0) or
the max for a slab cache allocation.
Signed-off-by: Peter Enderborg <peter.enderborg@sonymobile.com>
---
include/uapi/asm-generic/socket.h | 2 ++
include/uapi/linux/socket.h | 9 +++++++++
net/core/sock.c | 17 +++++++++++++++++
3 files changed, 28 insertions(+)
diff --git a/include/uapi/asm-generic/socket.h b/include/uapi/asm-generic/socket.h
index 67d632f..f6a4921 100644
--- a/include/uapi/asm-generic/socket.h
+++ b/include/uapi/asm-generic/socket.h
@@ -92,4 +92,6 @@
#define SO_CNX_ADVICE 53
+#define SO_SIZEHINT 54
+
#endif /* __ASM_GENERIC_SOCKET_H */
diff --git a/include/uapi/linux/socket.h b/include/uapi/linux/socket.h
index 76ab0c6..16db7e8 100644
--- a/include/uapi/linux/socket.h
+++ b/include/uapi/linux/socket.h
@@ -1,6 +1,8 @@
#ifndef _UAPI_LINUX_SOCKET_H
#define _UAPI_LINUX_SOCKET_H
+#include <linux/types.h>
+
/*
* Desired design of maximum size and alignment (see RFC2553)
*/
@@ -18,4 +20,11 @@ struct __kernel_sockaddr_storage {
/* _SS_MAXSIZE value minus size of ss_family */
} __attribute__ ((aligned(_K_SS_ALIGNSIZE))); /* force desired alignment */
+struct sock_sizehint {
+ __u32 order_zero_size;
+ /* max payload size that can fit into one page in kernel */
+ __u32 cache_size;
+ /* max payload size that can fit in socket slab cache */
+};
+
#endif /* _UAPI_LINUX_SOCKET_H */
diff --git a/net/core/sock.c b/net/core/sock.c
index 7e73c26..4c9cd92 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1254,6 +1254,23 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
v.val = sk->sk_incoming_cpu;
break;
+ case SO_SIZEHINT:
+ {
+ struct sock_sizehint hint;
+
+ if (len > sizeof(hint))
+ len = sizeof(hint);
+
+ hint.order_zero_size = PAGE_SIZE -
+ SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
+ hint.cache_size = KMALLOC_MAX_CACHE_SIZE -
+ SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
+
+ if (copy_to_user(optval, &hint, len))
+ return -EFAULT;
+ goto lenout;
+ }
+
default:
/* We implement the SO_SNDLOWAT etc to not be settable
* (1003.1g 7).
--
2.4.2
next reply other threads:[~2016-06-17 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 13:58 peter enderborg [this message]
2016-06-17 14:14 ` [PATCH resend] net: sock: Add option for memory optimized hints Eric Dumazet
2016-06-17 14:39 ` peter enderborg
2016-06-17 16:03 ` Eric Dumazet
2016-06-17 16:07 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57640204.9070300@sonymobile.com \
--to=peter.enderborg@sonymobile.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).