From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats Date: Fri, 17 Jun 2016 10:54:34 -0400 Message-ID: <57640F2A.7090003@mojatatu.com> References: <1466066237-7719-1-git-send-email-jiri@resnulli.us> <20160616.172632.1759391103978744570.davem@davemloft.net> <20160617082411.GA1981@nanopsycho.orion> <20160617140512.GB1981@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, nogahf@mellanox.com, idosch@mellanox.com, eladr@mellanox.com, yotamg@mellanox.com, ogerlitz@mellanox.com, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, linville@tuxdriver.com, tgraf@suug.ch, gospo@cumulusnetworks.com, sfeldma@gmail.com, sd@queasysnail.net, eranbe@mellanox.com, ast@plumgrid.com, edumazet@google.com, hannes@stressinduktion.org, f.fainelli@gmail.com To: Jiri Pirko , David Ahern Return-path: Received: from mail-io0-f193.google.com ([209.85.223.193]:35600 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbcFQOyq (ORCPT ); Fri, 17 Jun 2016 10:54:46 -0400 Received: by mail-io0-f193.google.com with SMTP id n127so10732961iof.2 for ; Fri, 17 Jun 2016 07:54:45 -0700 (PDT) In-Reply-To: <20160617140512.GB1981@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: On 16-06-17 10:05 AM, Jiri Pirko wrote: > Fri, Jun 17, 2016 at 03:48:35PM CEST, dsa@cumulusnetworks.com wrote: >> On 6/17/16 2:24 AM, Jiri Pirko wrote: >>> > > That is problematic. Existing apps depend on rtnetlink stats. But if we > don't count offloaded forwarded packets, the apps don't see anything. > Therefore I believe that this patchset approach is better. The existing > apps continue to work and future apps can use newly introduces sw_stats > to query slowpath traffic. Makes sense to me. > I agree with Jiri. It is a bad idea to depend on ethtool for any of this stuff. Is there a way we can tag netlink stats instead to indicate they are hardware or software? We already have a use case with the tc where someone could get/set hardware and/or software. cheers, jamal