From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
Stephen Hemminger <shemming@brocade.com>
Cc: Phil Sutter <phil@nwl.cc>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
julien.floret@6wind.com
Subject: Re: [iproute PATCH 1/3] Use C99 style initializers everywhere
Date: Fri, 17 Jun 2016 18:58:14 +0200 [thread overview]
Message-ID: <57642C26.6060105@6wind.com> (raw)
In-Reply-To: <5764295E.7070103@iogearbox.net>
Le 17/06/2016 18:46, Daniel Borkmann a écrit :
> On 06/17/2016 06:34 PM, Stephen Hemminger wrote:
>> On Fri, 17 Jun 2016 16:09:20 +0000
>> Daniel Borkmann <daniel@iogearbox.net> wrote:
>>
>>> Please have a look at commit 8f80d450c3cb ("tc: fix compilation with old gcc
>>> (< 4.6)") ...
>>>
>>> Your changes effectively revert them again. Here, and some other parts of the
>>> bpf frontend
>>> code bits.
>>
>> GCC 4.6 is 3 years old. So perhaps it is time to move on.
>> Maybe add a GCC version check in the makefile, to fail cleanly.
>
> Well, you don't have to ask me but rather the patch submitters (Cc).
>
> I haven't used RHEL in quite a while, but I could imagine it might
> be related to built it there perhaps.
Yes. For some specific arch, we have only old toolchains.
The rule was always to be backward compatible with old kernels. It implies to
also support the compilation with old toolchains ;-)
next prev parent reply other threads:[~2016-06-17 16:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 15:56 [iproute PATCH 0/3] Big C99 style initializer rework Phil Sutter
2016-06-17 15:56 ` [iproute PATCH 1/3] Use C99 style initializers everywhere Phil Sutter
2016-06-17 16:09 ` Daniel Borkmann
2016-06-18 0:02 ` Phil Sutter
2016-06-18 0:21 ` Stephen Hemminger
2016-06-20 3:39 ` David Ahern
[not found] ` <ddef688e6e3f4a1a895880de1f9f069d@HQ1WP-EXMB11.corp.brocade.com>
2016-06-17 16:34 ` Stephen Hemminger
2016-06-17 16:46 ` Daniel Borkmann
2016-06-17 16:58 ` Nicolas Dichtel [this message]
[not found] ` <9e1c05c7b4894137a80bdb3d2a361bbc@HQ1WP-EXMB11.corp.brocade.com>
2016-06-17 18:57 ` Stephen Hemminger
2016-06-17 20:15 ` David Ahern
2016-06-17 20:36 ` Daniel Borkmann
2016-06-17 20:47 ` David Ahern
2016-06-17 15:56 ` [iproute PATCH 2/3] Replace malloc && memset by calloc Phil Sutter
2016-06-17 15:56 ` [iproute PATCH 3/3] No need to initialize rtattr fields before parsing Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57642C26.6060105@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=daniel@iogearbox.net \
--cc=julien.floret@6wind.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).