From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
David Ahern <dsa@cumulusnetworks.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Nogah Frankel <nogahf@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>, Elad Raz <eladr@mellanox.com>,
Yotam Gigi <yotamg@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
John Linville <linville@tuxdriver.com>,
Thomas Graf <tgraf@suug.ch>,
Andy Gospodarek <gospo@cumulusnetworks.com>,
Scott Feldman <sfeldma@gmail.com>,
sd@queasysnail.net, eranbe@mellanox.com,
Alexei Starovoitov <ast@plumgrid.com>,
Eric Dumazet <edumazet@google.com>,
"hannes@stressinduktion.org" <hannes@stressinduktion.org>
Subject: Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats
Date: Mon, 20 Jun 2016 08:28:31 -0400 [thread overview]
Message-ID: <5767E16F.2040902@mojatatu.com> (raw)
In-Reply-To: <CAJieiUhFRp6wE_gt-0q9KYQTYdEyg5yFUYa89K+ovaQr7QE5Zg@mail.gmail.com>
On 16-06-19 11:14 PM, Roopa Prabhu wrote:
> On Fri, Jun 17, 2016 at 10:12 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> I have also mentioned this before, the default api must provide
> accumulated (hw and sw) stats...,
> because this is the api that the user queries on an interface.
Sorry - I missed those discussions.
What is current practise? Do people request for one via ip link
stats and the other via ethtool?
What do you guys do in your implementation?
Yes, it would be more accurate to provide aggregated stats but
it may break backward compat if expectation is both are read
separately today.
Maybe it makes sense to have a brand new TLV for these aggregated
stats as Jiri was suggesting.That means two new TLVs not one.
1) TLV for aggregated stats - which cant be current one
2) TLV for h/w stats
The existing stat implies s/ware only.
cheers,
jamal
next prev parent reply other threads:[~2016-06-20 12:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 8:37 [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats Jiri Pirko
2016-06-16 8:37 ` [patch net-next v4 1/4] netdevice: add SW statistics ndo Jiri Pirko
2016-06-16 8:37 ` [patch net-next v4 2/4] rtnetlink: add HW/SW stats distinction in rtnl_fill_stats Jiri Pirko
2016-06-16 8:37 ` [patch net-next v4 3/4] net: core: add SW stats to if_stats_msg Jiri Pirko
2016-06-17 0:20 ` David Miller
2016-06-17 7:32 ` Jiri Pirko
2016-06-16 8:37 ` [patch net-next v4 4/4] mlxsw: spectrum: Implement SW stats ndo and expose HW stats by default Jiri Pirko
2016-06-17 0:26 ` [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats David Miller
2016-06-17 8:24 ` Jiri Pirko
2016-06-17 13:48 ` David Ahern
2016-06-17 14:05 ` Jiri Pirko
2016-06-17 14:54 ` Jamal Hadi Salim
2016-06-17 14:57 ` Jiri Pirko
2016-06-17 15:35 ` David Ahern
2016-06-17 15:42 ` Jiri Pirko
2016-06-17 17:12 ` Florian Fainelli
2016-06-18 8:00 ` Jiri Pirko
2016-06-18 13:58 ` Jamal Hadi Salim
2016-06-19 10:57 ` Jiri Pirko
2016-06-20 3:14 ` Roopa Prabhu
2016-06-20 12:28 ` Jamal Hadi Salim [this message]
2016-06-20 13:09 ` Jiri Pirko
2016-06-22 14:30 ` Roopa Prabhu
2016-06-20 3:06 ` Roopa Prabhu
2016-06-20 2:57 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5767E16F.2040902@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=edumazet@google.com \
--cc=eladr@mellanox.com \
--cc=eranbe@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=gospo@cumulusnetworks.com \
--cc=hannes@stressinduktion.org \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=sd@queasysnail.net \
--cc=sfeldma@gmail.com \
--cc=tgraf@suug.ch \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).