From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 810ABC2F421 for ; Mon, 21 Jan 2019 16:14:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50D132089F for ; Mon, 21 Jan 2019 16:14:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KTm1OxTF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730454AbfAUQO4 (ORCPT ); Mon, 21 Jan 2019 11:14:56 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:44934 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729413AbfAUQOz (ORCPT ); Mon, 21 Jan 2019 11:14:55 -0500 Received: by mail-pf1-f195.google.com with SMTP id u6so10325313pfh.11 for ; Mon, 21 Jan 2019 08:14:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lhDnO6qJzKhZdDasJBbynyLkcxlvMcw7EXpornijm3Q=; b=KTm1OxTFvXHNmWhjHuzS1r9EG2v7lVwn/ZRir4QWmJfukasbW4IIthpxBRKqhXqawM 4KIYpxUsK/CE/GV4hyMrKPqQdrlDmeZ8fJ9c5w/qxQD0IkJuTMRQhnRG8hzftGNHNDig jMmcJ9D6PYAYSUPDvuoFLhC0hxhp+BK/IVO+reRyyLO210BJGh6O1Aq7Oeqc1NQxyGbe eHJu6FK16K7r4QZCBlYoXHedhU2S15MOsx17gAc5R1/u/EDrJxN3bf6rsV6saUk1ipkD 5FqQjvbmo4dmxDZtNLjQBSlr7QHOJc3JKcU2h5bTHwAk5BC2MupHTAyPqv2qkdnfi1Kv TOlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lhDnO6qJzKhZdDasJBbynyLkcxlvMcw7EXpornijm3Q=; b=Yht3zdPWtrz0hj9sg4ed1eZIFYL1c/M/XLY1jk7nc1GCY4095uCQPQyBERxbVrK9HV PvgzqCFlWDWCL6U5Z0Pm0BTaqVXRGyO0460jqPxUFI/t11LB9BCMbuuRGHLgEo/insAA Sexpj8i4dyJ29ca4Dqy4hbAOjO5mF0NqieDdjxpLxXspa/ZmTJ41AUYU9ACDLOssBbAQ suBxG1b3KnTr82rr5J7o0E+uSOrzHtL791LXt1fS9leoYp6H2R2DkZpFHCWl3mfBRaEy gRrKpWliknX9jf3CbCWhzbZUFZTtTqy12Lao1uBBSeERCzJ46QP2LJbNiYFXRWYth4Tf btuA== X-Gm-Message-State: AJcUukfIgg2om0ofGNWaOKOhQHqyY/Xz7ont1JCBN4hnaDqE7tN0DEka pjeY8Esbd+3tPznRSDY9FqOS5nD6 X-Google-Smtp-Source: ALg8bN7ZjrTEZ9z4Lh0O7NmUuW/CsDX2mBG8mcAOueqf23EfZEMW1npeDRGuq0dZs/a3K3AJ6+wBVw== X-Received: by 2002:a63:5d20:: with SMTP id r32mr28921052pgb.329.1548087295177; Mon, 21 Jan 2019 08:14:55 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:d58c:9df2:49cf:9a2a? ([2601:282:800:fd80:d58c:9df2:49cf:9a2a]) by smtp.googlemail.com with ESMTPSA id m9sm31433190pgd.32.2019.01.21.08.14.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 08:14:54 -0800 (PST) Subject: Re: [PATCH v2 iproute2] ip: support for xfrm interfaces To: Matt Ellison , netdev@vger.kernel.org Cc: stephen@networkplumber.org References: <20190117094037.36ea8631@aquamarine> From: David Ahern Message-ID: <5767ec25-88ac-88f9-3ea8-31a90c0659d7@gmail.com> Date: Mon, 21 Jan 2019 09:14:52 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190117094037.36ea8631@aquamarine> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/17/19 7:40 AM, Matt Ellison wrote: > +static int xfrm_parse_opt(struct link_util *lu, int argc, char **argv, > + struct nlmsghdr *n) > +{ > + unsigned int link = 0; > + __u32 if_id = 0; > + > + while (argc > 0) { > + if (!matches(*argv, "dev")) { > + NEXT_ARG(); > + link = ll_name_to_index(*argv); > + if (!link) > + exit(nodev(*argv)); > + } else if (!matches(*argv, "if_id")) { > + NEXT_ARG(); > + if (get_u32(&if_id, *argv, 0)) > + invarg("if_id", *argv); > + } else { > + xfrm_print_help(lu, argc, argv, stderr); > + return -1; > + } > + argc--; argv++; > + } > + > + addattr32(n, 1024, IFLA_XFRM_IF_ID, if_id); You always add IF_ID even if not set by user. The kernel code does not appear to require it so why pass a default value? > + > + if (link) { > + addattr32(n, 1024, IFLA_XFRM_LINK, link); > + } else { > + fprintf(stderr, "must specify physical device\n"); > + return -1; > + } The kernel code does appear to require this parameter, so why have this requirement in iproute2? > + > + return 0; > +} > + > +static void xfrm_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) > +{ > + > + if (!tb) > + return; > + > + if (tb[IFLA_XFRM_IF_ID]) { > + __u32 id = rta_getattr_u32(tb[IFLA_XFRM_IF_ID]); > + > + print_0xhex(PRINT_ANY, "if_id", "if_id %#llx ", id); > + > + } What about IFLA_XFRM_LINK? > diff --git a/testsuite/tests/ip/link/add_type_xfrm.t b/testsuite/tests/ip/link/add_type_xfrm.t > new file mode 100755 > index 00000000..78ce28e0 > --- /dev/null > +++ b/testsuite/tests/ip/link/add_type_xfrm.t > @@ -0,0 +1,32 @@ > +#!/bin/sh > + > +. lib/generic.sh > + > +ts_log "[Testing Add XFRM Interface, With IF-ID]" > + > +PHYS_DEV="lo" > +NEW_DEV="$(rand_dev)" > +IF_ID="0xf" > + > +ts_ip "$0" "Add $NEW_DEV xfrm interface" link add dev $NEW_DEV type xfrm dev $PHYS_DEV if_id $IF_ID > + > +ts_ip "$0" "Show $NEW_DEV xfrm interface" -d link show dev $NEW_DEV > +test_on "$NEW_DEV" > +test_on "if_id $IF_ID" > + > +ts_ip "$0" "Del $NEW_DEV xfrm interface" link del dev $NEW_DEV > + > + > +ts_log "[Testing Add XFRM Interface, No IF-ID]" > + > +PHYS_DEV="lo" > +NEW_DEV="$(rand_dev)" > +IF_ID="0xf" > + > +ts_ip "$0" "Add $NEW_DEV xfrm interface" link add dev $NEW_DEV type xfrm dev $PHYS_DEV > + > +ts_ip "$0" "Show $NEW_DEV xfrm interface" -d link show dev $NEW_DEV > +test_on "$NEW_DEV" > +test_on_not "if_id $IF_ID" > + > +ts_ip "$0" "Del $NEW_DEV xfrm interface" link del dev $NEW_DEV > Thanks for adding test cases!