From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: khoroshilov@ispras.ru
Subject: Re: [Patch net 1/2] act_ife: only acquire tcf_lock for existing actions
Date: Thu, 23 Jun 2016 07:10:29 -0400 [thread overview]
Message-ID: <576BC3A5.3070509@mojatatu.com> (raw)
In-Reply-To: <1466455039-23268-2-git-send-email-xiyou.wangcong@gmail.com>
On 16-06-20 04:37 PM, Cong Wang wrote:
> Alexey reported that we have GFP_KERNEL allocation when
> holding the spinlock tcf_lock. Actually we don't have
> to take that spinlock for all the cases, especially
> for the new one we just create. To modify the existing
> actions, we still need this spinlock to make sure
> the whole update is atomic.
>
> For net-next, we can get rid of this spinlock because
> we already hold the RTNL lock on slow path, and on fast
> path we can use RCU to protect the metalist.
>
> Joint work with Jamal.
>
> Reported-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
next prev parent reply other threads:[~2016-06-23 11:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 20:37 [Patch net 0/2] net_sched: bug fixes for ife action Cong Wang
2016-06-20 20:37 ` [Patch net 1/2] act_ife: only acquire tcf_lock for existing actions Cong Wang
2016-06-23 11:10 ` Jamal Hadi Salim [this message]
2016-06-20 20:37 ` [Patch net 2/2] act_ife: acquire ife_mod_lock before reading ifeoplist Cong Wang
2016-06-23 11:11 ` Jamal Hadi Salim
2016-06-23 16:02 ` [Patch net 0/2] net_sched: bug fixes for ife action David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576BC3A5.3070509@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=khoroshilov@ispras.ru \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).