From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov via Bridge Subject: Re: [PATCH net-next] net: bridge: add support for IGMP/MLD stats and export them via netlink Date: Tue, 28 Jun 2016 14:02:07 +0200 Message-ID: <5772673F.8010808@cumulusnetworks.com> References: <1467051048-32604-1-git-send-email-nikolay@cumulusnetworks.com> <20160628110321.GA3221@otheros> Reply-To: Nikolay Aleksandrov Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, davem@davemloft.net To: =?UTF-8?Q?Linus_L=c3=bcssing?= Return-path: In-Reply-To: <20160628110321.GA3221@otheros> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 28/06/16 13:03, Linus L=C3=BCssing wrote: > On Mon, Jun 27, 2016 at 08:10:48PM +0200, Nikolay Aleksandrov via Bridg= e wrote: >> These are invaluable when monitoring or debugging complex multicast se= tups >> with bridges. >=20 > Indeed! Great patch :). Especially if people are unable to provide > pcap files for debugging (due to whatever reason). Hopefully that > will help with bugzilla ticket #99081, too... >=20 > I know it might not quite fit into your current patch, which simply > stores the ICMPv6 and IGMP type in the bridge private skb->cb, but > do you think you could count and export the following two more > things, too: >=20 > * MLDv1 vs. MLDv2 querier (and IGMP accordingly) > * Number of (potential) MLD/IGMP parse errors > (e.g. beginning of br_multicast_ipv{4,6}_rcv(): > http://lxr.free-electrons.com/source/net/bridge/br_multicast.c?v=3D4= .5#L1588 and > http://lxr.free-electrons.com/source/net/bridge/br_multicast.c?v=3D4= .5#L1634) >=20 > The former would help to know how the network is expected to > behave (for instance whether you should see MLDv2 reports at all or > whether / how much report suppression to expect). >=20 > The latter would help to spot either potential IGMP/MLD parsing bugs in > the bridge or malformed IGMP/MLD messages send by someone else. >=20 >=20 > Ideally, there would be per port counters again for the overall > IPv4/IPv6 multicast traffic. That would help for multicast streams > for instance, to easily see whether multicast counters increase > rapidly on the ports you would expect them to. And whether snooping > is working in general for such streames, without needing to check > each port individually via tcpdump, for instance. >=20 >=20 > Just some thoughts, would love to hear what you think about them. >=20 > Regards, Linus >=20 Hi Linus, I think these are all reasonable and helpful things to export in addition= . I will definitely look into extending the stats with them. If this patch is acce= pted as-is I'll just do it as a follow-up. Thanks for the good suggestions! Cheers, Nik