From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vijay Khemka Subject: Re: [PATCH net-next v4] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command Date: Wed, 10 Oct 2018 17:19:11 +0000 Message-ID: <57729D0A-A210-41F4-BAF8-3BDB2FCBF1B5@fb.com> References: <7c7f95baba3a467e89aabf726a5230f7@AUSX13MPS302.AMER.DELL.COM> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "linux-aspeed@lists.ozlabs.org" , "netdev@vger.kernel.org" , "openbmc@lists.ozlabs.org" , Amithash Prasad , "christian@cmd.nu" To: "Justin.Lee1@Dell.com" , "sam@mendozajonas.com" , "joel@jms.id.au" Return-path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:40414 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726822AbeJKAml (ORCPT ); Wed, 10 Oct 2018 20:42:41 -0400 In-Reply-To: <7c7f95baba3a467e89aabf726a5230f7@AUSX13MPS302.AMER.DELL.COM> Content-Language: en-US Content-ID: Sender: netdev-owner@vger.kernel.org List-ID: SGkgSnVzdGluLA0KUGxlYXNlIHNlZSBtaW5vciBjb21tZW50cyBiZWxvdy4NCg0KUmVnYXJkcw0K LVZpamF5DQoNCu+7v09uIDEwLzEwLzE4LCA5OjAxIEFNLCAiSnVzdGluLkxlZTFARGVsbC5jb20i IDxKdXN0aW4uTGVlMUBEZWxsLmNvbT4gd3JvdGU6DQoNCiAgICBUaGUgbmV3IGNvbW1hbmQgKE5D U0lfQ01EX1NFTkRfQ01EKSBpcyBhZGRlZCB0byBhbGxvdyB1c2VyIHNwYWNlIGFwcGxpY2F0aW9u DQogICAgdG8gc2VuZCBOQy1TSSBjb21tYW5kIHRvIHRoZSBuZXR3b3JrIGNhcmQuDQogICAgQWxz bywgYWRkIGEgbmV3IGF0dHJpYnV0ZSAoTkNTSV9BVFRSX0RBVEEpIGZvciB0cmFuc2ZlcnJpbmcg cmVxdWVzdCBhbmQgcmVzcG9uc2UuDQogICAgDQogICAgVGhlIHdvcmsgZmxvdyBpcyBhcyBiZWxv dy4gDQogICAgDQogICAgUmVxdWVzdDoNCiAgICBVc2VyIHNwYWNlIGFwcGxpY2F0aW9uDQogICAg CS0+IE5ldGxpbmsgaW50ZXJmYWNlIChtc2cpDQogICAgCS0+IG5ldyBOZXRsaW5rIGhhbmRsZXIg LSBuY3NpX3NlbmRfY21kX25sKCkNCiAgICAJLT4gbmNzaV94bWl0X2NtZCgpDQogICAgDQogICAg UmVzcG9uc2U6DQogICAgUmVzcG9uc2UgcmVjZWl2ZWQgLSBuY3NpX3Jjdl9yc3AoKQ0KICAgIAkt PiBpbnRlcm5hbCByZXNwb25zZSBoYW5kbGVyIC0gbmNzaV9yc3BfaGFuZGxlcl94eHgoKQ0KICAg IAktPiBuY3NpX3JzcF9oYW5kbGVyX25ldGxpbmsoKQ0KICAgIAktPiBuY3NpX3NlbmRfbmV0bGlu a19yc3AgKCkNCiAgICAJLT4gTmV0bGluayBpbnRlcmZhY2UgKG1zZykNCiAgICAJLT4gdXNlciBz cGFjZSBhcHBsaWNhdGlvbg0KICAgIA0KICAgIENvbW1hbmQgdGltZW91dCAtIG5jc2lfcmVxdWVz dF90aW1lb3V0KCkNCiAgICAJLT4gbmNzaV9zZW5kX25ldGxpbmtfdGltZW91dCAoKQ0KICAgIAkt PiBOZXRsaW5rIGludGVyZmFjZSAobXNnIHdpdGggemVybyBkYXRhIGxlbmd0aCkNCiAgICAJLT4g dXNlciBzcGFjZSBhcHBsaWNhdGlvbg0KICAgIA0KICAgIEVycm9yOg0KICAgIEVycm9yIGRldGVj dGVkDQogICAgCS0+IG5jc2lfc2VuZF9uZXRsaW5rX2VyciAoKQ0KICAgIAktPiBOZXRsaW5rIGlu dGVyZmFjZSAoZXJyIG1zZykNCiAgICAJLT4gdXNlciBzcGFjZSBhcHBsaWNhdGlvbg0KICAgIA0K ICAgIA0KICAgIFNpZ25lZC1vZmYtYnk6IEp1c3RpbiBMZWUgPGp1c3Rpbi5sZWUxQGRlbGwuY29t PiANCiAgICANCiAgICANCiAgICAtLS0NCiAgICBWNDogVXBkYXRlIGNvbW1lbnRzIGFuZCByZW1v dmUgc29tZSBkZWJ1ZyBtZXNzYWdlLg0KICAgIFYzOiBCYXNlZCBvbiBodHRwczovL3VybGRlZmVu c2UucHJvb2Zwb2ludC5jb20vdjIvdXJsP3U9aHR0cC0zQV9fcGF0Y2h3b3JrLm96bGFicy5vcmdf cGF0Y2hfOTc5Njg4XyZkPUR3SUdhUSZjPTVWRDBSVHRObFRoM3ljZDQxYjNNVXcmcj12OU1VMEtp OXBXblRYQ1d3akhQVmdwbkNSODB2WGtrY3JJYXFVN1VTbDVnJm09MzhLU3JGX1RodW9SbW91THgt eEtLa2twazlFZmhORkVFcVhiZHVRcVFwRSZzPUdSWFIxc0lFek5vN3hES3lVV1M5dDFJdGE2dnhF WF9sbHpNeDJhenVlVmMmZT0gdG8gcmVtb3ZlIHRoZSBkdXBsaWNhdGVkIGNvZGUuDQogICAgVjI6 IFJlbW92ZSBub24tcmVsYXRlZCBkZWJ1ZyBtZXNzYWdlIGFuZCBjbGVhbiB1cCB0aGUgY29kZS4N CiAgICANCiAgICANCiAgICAtLS0gYS9uZXQvbmNzaS9pbnRlcm5hbC5oDQogICAgKysrIGIvbmV0 L25jc2kvaW50ZXJuYWwuaA0KICAgIEBAIC0xNzUsNiArMTc1LDggQEAgc3RydWN0IG5jc2lfcGFj a2FnZTsNCiAgICAgI2RlZmluZSBOQ1NJX1JFU0VSVkVEX0NIQU5ORUwJMHgxZg0KICAgICAjZGVm aW5lIE5DU0lfQ0hBTk5FTF9JTkRFWChjKQkoKGMpICYgKCgxIDw8IE5DU0lfUEFDS0FHRV9TSElG VCkgLSAxKSkNCiAgICAgI2RlZmluZSBOQ1NJX1RPX0NIQU5ORUwocCwgYykJKCgocCkgPDwgTkNT SV9QQUNLQUdFX1NISUZUKSB8IChjKSkNCiAgICArI2RlZmluZSBOQ1NJX01BWF9QQUNLQUdFCTgN CiAgICArI2RlZmluZSBOQ1NJX01BWF9DSEFOTkVMCTMyDQogICAgIA0KICAgICBzdHJ1Y3QgbmNz aV9jaGFubmVsIHsNCiAgICAgCXVuc2lnbmVkIGNoYXIgICAgICAgICAgICAgICBpZDsNCiAgICBA QCAtMjE5LDEyICsyMjEsMTcgQEAgc3RydWN0IG5jc2lfcmVxdWVzdCB7DQogICAgIAl1bnNpZ25l ZCBjaGFyICAgICAgICBpZDsgICAgICAvKiBSZXF1ZXN0IElEIC0gMCB0byAyNTUgICAgICAgICAg ICovDQogICAgIAlib29sICAgICAgICAgICAgICAgICB1c2VkOyAgICAvKiBSZXF1ZXN0IHRoYXQg aGFzIGJlZW4gYXNzaWduZWQgICovDQogICAgIAl1bnNpZ25lZCBpbnQgICAgICAgICBmbGFnczsg ICAvKiBOQ1NJIHJlcXVlc3QgcHJvcGVydHkgICAgICAgICAgICovDQogICAgLSNkZWZpbmUgTkNT SV9SRVFfRkxBR19FVkVOVF9EUklWRU4JMQ0KICAgICsjZGVmaW5lIE5DU0lfUkVRX0ZMQUdfRVZF TlRfRFJJVkVOCQkxDQogIA0KICBXaHkgZXh0cmEgc3BhY2UgYWRkZWQgYWJvdmU/DQoNCiAgICAr I2RlZmluZSBOQ1NJX1JFUV9GTEFHX05FVExJTktfRFJJVkVOCTINCiAgICAgCXN0cnVjdCBuY3Np X2Rldl9wcml2ICpuZHA7ICAgIC8qIEFzc29jaWF0ZWQgTkNTSSBkZXZpY2UgICAgICAgICAgKi8N CiAgICAgCXN0cnVjdCBza19idWZmICAgICAgICpjbWQ7ICAgIC8qIEFzc29jaWF0ZWQgTkNTSSBj b21tYW5kIHBhY2tldCAgKi8NCiAgICAgCXN0cnVjdCBza19idWZmICAgICAgICpyc3A7ICAgIC8q IEFzc29jaWF0ZWQgTkNTSSByZXNwb25zZSBwYWNrZXQgKi8NCiAgICAgCXN0cnVjdCB0aW1lcl9s aXN0ICAgIHRpbWVyOyAgIC8qIFRpbWVyIG9uIHdhaXRpbmcgZm9yIHJlc3BvbnNlICAgKi8NCiAg ICAgCWJvb2wgICAgICAgICAgICAgICAgIGVuYWJsZWQ7IC8qIFRpbWUgaGFzIGJlZW4gZW5hYmxl ZCBvciBub3QgICAgKi8NCiAgICArDQogICAgKwl1MzIgICAgICAgICAgICAgICAgICBzbmRfc2Vx OyAgICAgLyogbmV0bGluayBzZW5kaW5nIHNlcXVlbmNlIG51bWJlciAqLw0KICAgICsJdTMyICAg ICAgICAgICAgICAgICAgc25kX3BvcnRpZDsgIC8qIG5ldGxpbmsgcG9ydGlkIG9mIHNlbmRlciAg ICAgICAgKi8NCiAgICArCXN0cnVjdCBubG1zZ2hkciAgICAgIG5saGRyOyAgICAgICAvKiBuZXRs aW5rIG1lc3NhZ2UgaGVhZGVyICAgICAgICAgICovDQogICAgIH07DQogICAgIA0KICBFeHRyYSBs aW5lIGluc2lkZSBzdHJ1Y3R1cmUgbWF5IG5vdCBiZSByZXF1aXJlZC4NCg0KICAgICBlbnVtIHsN CiAgICBAQCAtMzEwLDYgKzMxNyw3IEBAIHN0cnVjdCBuY3NpX2NtZF9hcmcgew0KICAgICAJCXVu c2lnbmVkIGludCAgIGR3b3Jkc1s0XTsNCiAgICAgCX07DQogICAgIAl1bnNpZ25lZCBjaGFyICAg ICAgICAqZGF0YTsgICAgICAgLyogTkNTSSBPRU0gZGF0YSAgICAgICAgICAgICAgICAgKi8NCiAg ICArCXN0cnVjdCBnZW5sX2luZm8gICAgICppbmZvOyAgICAgICAvKiBOZXRsaW5rIGluZm9ybWF0 aW9uICAgICAgICAgICAqLw0KICAgICB9Ow0KICAgICANCiAgICBkaWZmIC0tZ2l0IGEvbmV0L25j c2kvbmNzaS1uZXRsaW5rLmMgYi9uZXQvbmNzaS9uY3NpLW5ldGxpbmsuYw0KICAgIGluZGV4IDQ1 ZjMzZDYuLjYyZTE5MWYgMTAwNjQ0DQogICAgLS0tIGEvbmV0L25jc2kvbmNzaS1uZXRsaW5rLmMN CiAgICArKysgYi9uZXQvbmNzaS9uY3NpLW5ldGxpbmsuYw0KICAgIEBAIC0yMCw2ICsyMCw3IEBA DQogICAgICNpbmNsdWRlIDx1YXBpL2xpbnV4L25jc2kuaD4NCiAgICAgDQogICAgICNpbmNsdWRl ICJpbnRlcm5hbC5oIg0KICAgICsjaW5jbHVkZSAibmNzaS1wa3QuaCINCiAgICAgI2luY2x1ZGUg Im5jc2ktbmV0bGluay5oIg0KICAgICANCiAgICAgc3RhdGljIHN0cnVjdCBnZW5sX2ZhbWlseSBu Y3NpX2dlbmxfZmFtaWx5Ow0KICAgIEBAIC0yOSw2ICszMCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgbmxhX3BvbGljeSBuY3NpX2dlbmxfcG9saWN5W05DU0lfQVRUUl9NQVggKyAxXSA9IHsNCiAg ICAgCVtOQ1NJX0FUVFJfUEFDS0FHRV9MSVNUXSA9CXsgLnR5cGUgPSBOTEFfTkVTVEVEIH0sDQog ICAgIAlbTkNTSV9BVFRSX1BBQ0tBR0VfSURdID0JeyAudHlwZSA9IE5MQV9VMzIgfSwNCiAgICAg CVtOQ1NJX0FUVFJfQ0hBTk5FTF9JRF0gPQl7IC50eXBlID0gTkxBX1UzMiB9LA0KICAgICsJW05D U0lfQVRUUl9EQVRBXSA9CQl7IC50eXBlID0gTkxBX0JJTkFSWSwgLmxlbiA9IDIwNDggfSwNCiAg ICAgfTsNCiAgICAgDQogICAgIHN0YXRpYyBzdHJ1Y3QgbmNzaV9kZXZfcHJpdiAqbmRwX2Zyb21f aWZpbmRleChzdHJ1Y3QgbmV0ICpuZXQsIHUzMiBpZmluZGV4KQ0KICAgIEBAIC0zNjYsNiArMzY4 LDE5OCBAQCBzdGF0aWMgaW50IG5jc2lfY2xlYXJfaW50ZXJmYWNlX25sKHN0cnVjdCBza19idWZm ICptc2csIHN0cnVjdCBnZW5sX2luZm8gKmluZm8pDQogICAgIAlyZXR1cm4gMDsNCiAgICAgfQ0K ICAgICANCiAgICArc3RhdGljIGludCBuY3NpX3NlbmRfY21kX25sKHN0cnVjdCBza19idWZmICpt c2csIHN0cnVjdCBnZW5sX2luZm8gKmluZm8pDQogICAgK3sNCiAgICArCXN0cnVjdCBuY3NpX2Rl dl9wcml2ICpuZHA7DQogICAgKw0KICAgICsJc3RydWN0IG5jc2lfY21kX2FyZyBuY2E7DQogICAg KwlzdHJ1Y3QgbmNzaV9wa3RfaGRyICpoZHI7DQogICAgKw0KICAgICsJdTMyIHBhY2thZ2VfaWQs IGNoYW5uZWxfaWQ7DQogICAgKwl1bnNpZ25lZCBjaGFyICpkYXRhOw0KICAgICsJaW50IGxlbiwg cmV0Ow0KICAgICsNCiAgICArCWlmICghaW5mbyB8fCAhaW5mby0+YXR0cnMpIHsNCiAgICArCQly ZXQgPSAtRUlOVkFMOw0KICAgICsJCWdvdG8gb3V0Ow0KICAgICsJfQ0KICAgICsNCiAgICArCWlm ICghaW5mby0+YXR0cnNbTkNTSV9BVFRSX0lGSU5ERVhdKSB7DQogICAgKwkJcmV0ID0gLUVJTlZB TDsNCiAgICArCQlnb3RvIG91dDsNCiAgICArCX0NCiAgICArDQogICAgKwlpZiAoIWluZm8tPmF0 dHJzW05DU0lfQVRUUl9QQUNLQUdFX0lEXSkgew0KICAgICsJCXJldCA9IC1FSU5WQUw7DQogICAg KwkJZ290byBvdXQ7DQogICAgKwl9DQogICAgKw0KICAgICsJaWYgKCFpbmZvLT5hdHRyc1tOQ1NJ X0FUVFJfQ0hBTk5FTF9JRF0pIHsNCiAgICArCQlyZXQgPSAtRUlOVkFMOw0KICAgICsJCWdvdG8g b3V0Ow0KICAgICsJfQ0KICAgICsNCiAgICArCW5kcCA9IG5kcF9mcm9tX2lmaW5kZXgoZ2V0X25l dChzb2NrX25ldChtc2ctPnNrKSksDQogICAgKwkJCSAgICAgICBubGFfZ2V0X3UzMihpbmZvLT5h dHRyc1tOQ1NJX0FUVFJfSUZJTkRFWF0pKTsNCiAgICArCWlmICghbmRwKSB7DQogICAgKwkJcmV0 ID0gLUVOT0RFVjsNCiAgICArCQlnb3RvIG91dDsNCiAgICArCX0NCiAgICArDQogICAgKwlwYWNr YWdlX2lkID0gbmxhX2dldF91MzIoaW5mby0+YXR0cnNbTkNTSV9BVFRSX1BBQ0tBR0VfSURdKTsN CiAgICArCWNoYW5uZWxfaWQgPSBubGFfZ2V0X3UzMihpbmZvLT5hdHRyc1tOQ1NJX0FUVFJfQ0hB Tk5FTF9JRF0pOw0KICAgICsNCiAgICArCWlmIChwYWNrYWdlX2lkID49IE5DU0lfTUFYX1BBQ0tB R0UgfHwgY2hhbm5lbF9pZCA+PSBOQ1NJX01BWF9DSEFOTkVMKSB7DQogICAgKwkJcmV0ID0gLUVS QU5HRTsNCiAgICArCQlnb3RvIG91dF9uZXRsaW5rOw0KICAgICsJfQ0KICAgICsNCiAgICArCWxl biA9IG5sYV9sZW4oaW5mby0+YXR0cnNbTkNTSV9BVFRSX0RBVEFdKTsNCiAgICArCWlmIChsZW4g PCBzaXplb2Yoc3RydWN0IG5jc2lfcGt0X2hkcikpIHsNCiAgICArCQluZXRkZXZfaW5mbyhuZHAt Pm5kZXYuZGV2LCAiTkNTSTogbm8gY29tbWFuZCB0byBzZW5kICV1XG4iLA0KICAgICsJCQkgICAg cGFja2FnZV9pZCk7DQogICAgKwkJcmV0ID0gLUVJTlZBTDsNCiAgICArCQlnb3RvIG91dF9uZXRs aW5rOw0KICAgICsJfSBlbHNlIHsNCiAgICArCQlkYXRhID0gKHVuc2lnbmVkIGNoYXIgKilubGFf ZGF0YShpbmZvLT5hdHRyc1tOQ1NJX0FUVFJfREFUQV0pOw0KICAgICsJfQ0KICAgICsNCiAgICAr CWhkciA9IChzdHJ1Y3QgbmNzaV9wa3RfaGRyICopZGF0YTsNCiAgICArDQogICAgKwluY2EubmRw ID0gbmRwOw0KICAgICsJbmNhLnBhY2thZ2UgPSAodW5zaWduZWQgY2hhcilwYWNrYWdlX2lkOw0K ICAgICsJbmNhLmNoYW5uZWwgPSAodW5zaWduZWQgY2hhciljaGFubmVsX2lkOw0KICAgICsJbmNh LnR5cGUgPSBoZHItPnR5cGU7DQogICAgKwluY2EucmVxX2ZsYWdzID0gTkNTSV9SRVFfRkxBR19O RVRMSU5LX0RSSVZFTjsNCiAgICArCW5jYS5pbmZvID0gaW5mbzsNCiAgICArCW5jYS5wYXlsb2Fk ID0gbnRvaHMoaGRyLT5sZW5ndGgpOw0KICAgICsJbmNhLmRhdGEgPSBkYXRhICsgc2l6ZW9mKCpo ZHIpOw0KICAgICsNCiAgICArCXJldCA9IG5jc2lfeG1pdF9jbWQoJm5jYSk7DQogICAgK291dF9u ZXRsaW5rOg0KICAgICsJaWYgKHJldCAhPSAwKSB7DQogICAgKwkJbmV0ZGV2X2VycihuZHAtPm5k ZXYuZGV2LA0KICAgICsJCQkgICAiTkNTSTogRXJyb3IgJWQgc2VuZGluZyBPRU0gY29tbWFuZFxu IiwNCiAgICArCQkJICAgcmV0KTsNCiAgICArCQluY3NpX3NlbmRfbmV0bGlua19lcnIobmRwLT5u ZGV2LmRldiwNCiAgICArCQkJCSAgICAgIGluZm8tPnNuZF9zZXEsDQogICAgKwkJCQkgICAgICBp bmZvLT5zbmRfcG9ydGlkLA0KICAgICsJCQkJICAgICAgaW5mby0+bmxoZHIsDQogICAgKwkJCQkg ICAgICByZXQpOw0KICAgICsJfQ0KDQogIE9FTSBzaG91bGQgYmUgcmVtb3ZlZCBmcm9tIGFib3Zl IG1lc3NhZ2UuDQoNCiAgICArb3V0Og0KICAgICsJcmV0dXJuIHJldDsNCiAgICArfQ0KICAgICsN CiAgICAgDQogICAgDQogICAgDQoNCg==