From: Lino Sanfilippo <lsanfil@marvell.com>
To: Sony Chacko <sony.chacko@qlogic.com>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <Dept_NX_Linux_NIC_Driver@qlogic.com>
Subject: Re: [PATCH 1/1] qlcnic: add wmb() call in transmit data path.
Date: Thu, 30 Jun 2016 17:32:31 +0200 [thread overview]
Message-ID: <57753B8F.9020302@marvell.com> (raw)
In-Reply-To: <1467237094-23088-2-git-send-email-sony.chacko@qlogic.com>
Hi,
On 29.06.2016 23:51, Sony Chacko wrote:
> + /* Ensure writes are complete before HW fetches Tx descriptors */
> + wmb();
> qlcnic_update_cmd_producer(tx_ring);
>
> return NETDEV_TX_OK;
>
Would not an mmiowb be more appropriate in this case?
Regards,
Lino
next prev parent reply other threads:[~2016-06-30 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 21:51 [PATCH 0/1] qlcnic: add wmb() call in transmit data path Sony Chacko
2016-06-29 21:51 ` [PATCH 1/1] " Sony Chacko
2016-06-30 15:32 ` Lino Sanfilippo [this message]
2016-06-30 15:41 ` Lino Sanfilippo
2016-06-30 18:48 ` Sony Chacko
2016-07-01 9:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57753B8F.9020302@marvell.com \
--to=lsanfil@marvell.com \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).