From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com, daniel@iogearbox.net
Subject: Re: [PATCH net-next 1/1] net sched actions: mirred add support for setting Dst MAC address
Date: Sat, 2 Jul 2016 10:26:21 -0400 [thread overview]
Message-ID: <5777CF0D.4020509@mojatatu.com> (raw)
In-Reply-To: <5777CCD1.8090404@mojatatu.com>
On 16-07-02 10:16 AM, Jamal Hadi Salim wrote:
> On 16-07-02 10:07 AM, Nikolay Aleksandrov wrote:
>> On 02/07/16 16:02, Jamal Hadi Salim wrote:
>>> On 16-07-02 09:49 AM, Nikolay Aleksandrov wrote:
>
>>>> Also a minor suggestion - maybe err out on a
>>>> zero mac address, otherwise the user might think the operation was
>>>> successful.
>>>>
>>>
>>> Is a zero mac address wrong? What if that was policy intent?
>>>
>>
>> If you mean that you give the user ability to get rid of the mac, then
>> okay. I said it
>> because it will seem like a successful operation and then the mac will
>> not be dumped
>> or overwritten which will look like it wasn't set at all.
>>
>
> I mean a MAC address of all zeros.
> The destination MAC itself is optional attribute; if user doesnt pass it
> we (dont care and) never use it. Dumping will not see it and therefore
> not display it.
>
Actually it makes sense not to allow a MAC address of all zeros.
So I will add that check. Posting v2 shortly.
cheers,
jamal
prev parent reply other threads:[~2016-07-02 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 13:26 [PATCH net-next 1/1] net sched actions: mirred add support for setting Dst MAC address Jamal Hadi Salim
2016-07-02 13:49 ` Nikolay Aleksandrov
2016-07-02 14:02 ` Jamal Hadi Salim
2016-07-02 14:07 ` Nikolay Aleksandrov
2016-07-02 14:16 ` Jamal Hadi Salim
2016-07-02 14:26 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5777CF0D.4020509@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox