netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vegard Nossum <vegard.nossum@oracle.com>
To: Andy Gospodarek <gospo@cumulusnetworks.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, Dinesh Dutt <ddutt@cumulusnetworks.com>,
	Scott Feldman <sfeldma@gmail.com>
Subject: Re: [PATCH] net: check for NULL net_device in FIB tables
Date: Mon, 4 Jul 2016 15:50:23 +0200	[thread overview]
Message-ID: <577A699F.9030909@oracle.com> (raw)
In-Reply-To: <1467636446-6771-1-git-send-email-vegard.nossum@oracle.com>

On 07/04/2016 02:47 PM, Vegard Nossum wrote:
> struct fib_nh->nh_dev can be NULL, so we should check it before calling
> __in_dev_get_rcu on it.

That should say __in_dev_get_rtnl(), obviously.

>
> Multiple places seem to want this (and check the return value), so we can
> add a convenience wrapper for this.
>
> This fixes a crash in AF_NETLINK sendmsg().
>
> Please double check that I caught all the callers that need the NULL
> guard.
>
> Fixes: 0eeb075fad73 ("net: ipv4 sysctl option to ignore routes when nexthop link is down")
> Cc: Andy Gospodarek <gospo@cumulusnetworks.com>
> Cc: Dinesh Dutt <ddutt@cumulusnetworks.com>
> Cc: Scott Feldman <sfeldma@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>

I guess we could also add:

Cc: stable@vger.kernel.org


Vegard

  reply	other threads:[~2016-07-04 13:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 12:47 [PATCH] net: check for NULL net_device in FIB tables Vegard Nossum
2016-07-04 13:50 ` Vegard Nossum [this message]
2016-07-04 19:45 ` Julian Anastasov
2016-07-04 19:56   ` Vegard Nossum
2016-07-04 21:24     ` Julian Anastasov
2016-07-04 22:02       ` Vegard Nossum
2016-07-04 22:15         ` Julian Anastasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577A699F.9030909@oracle.com \
    --to=vegard.nossum@oracle.com \
    --cc=davem@davemloft.net \
    --cc=ddutt@cumulusnetworks.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).