From: Vegard Nossum <vegard.nossum@oracle.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: Andy Gospodarek <gospo@cumulusnetworks.com>,
davem@davemloft.net, netdev@vger.kernel.org,
Dinesh Dutt <ddutt@cumulusnetworks.com>,
Scott Feldman <sfeldma@gmail.com>
Subject: Re: [PATCH] net: check for NULL net_device in FIB tables
Date: Tue, 5 Jul 2016 00:02:09 +0200 [thread overview]
Message-ID: <577ADCE1.6010506@oracle.com> (raw)
In-Reply-To: <alpine.LFD.2.11.1607050014000.2228@ja.home.ssi.bg>
On 07/04/2016 11:24 PM, Julian Anastasov wrote:
>
> Hello,
>
> On Mon, 4 Jul 2016, Vegard Nossum wrote:
>
>> Alright.
>>
>> Thanks for the review! I can submit a new patch to only check the one
>> place above that actually crashed. Otherwise, if you think it's better
>> to go with your fc_flags suggestion, feel free to send a patch for that.
>> As you can tell, I am not very familiar with this code :-) If you do
>> send a patch, I can test it easily.
>
> Of course, here is untested version. May be I'll do some
> testing this weekend and will submit with proper commit
> message...
>
> [PATCH RFC] ipv4: reject RTNH_F_LINKDOWN for incompatible routes
>
> The RTNH_F_LINKDOWN flag is used only for link routes.
> Reject it for error routes and local routes.
>
> Signed-off-by: Julian Anastasov <ja@ssi.bg>
Tested your patch, it fixes the problem for me. I haven't tested if it
breaks anything else :-)
Vegard
next prev parent reply other threads:[~2016-07-04 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 12:47 [PATCH] net: check for NULL net_device in FIB tables Vegard Nossum
2016-07-04 13:50 ` Vegard Nossum
2016-07-04 19:45 ` Julian Anastasov
2016-07-04 19:56 ` Vegard Nossum
2016-07-04 21:24 ` Julian Anastasov
2016-07-04 22:02 ` Vegard Nossum [this message]
2016-07-04 22:15 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577ADCE1.6010506@oracle.com \
--to=vegard.nossum@oracle.com \
--cc=davem@davemloft.net \
--cc=ddutt@cumulusnetworks.com \
--cc=gospo@cumulusnetworks.com \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).