From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
vivien.didelot@savoirfairelinux.com
Subject: Re: [PATCH net-next v2 3/4] net: dsa: Suffix function manipulating device_node with _dn
Date: Tue, 5 Jul 2016 15:43:35 -0700 [thread overview]
Message-ID: <577C3817.1070908@gmail.com> (raw)
In-Reply-To: <20160705223612.GC28825@lunn.ch>
On 07/05/2016 03:36 PM, Andrew Lunn wrote:
> On Tue, Jul 05, 2016 at 03:07:12PM -0700, Florian Fainelli wrote:
>> Make it clear that these functions take a device_node structure pointer
>
> Hi Florian
>
> Didn't we agree that we would only support a single device via a C
> coded platform data structure?
That is true for the devices I know about, both in and out of tree,
however, while discussing offline with Vivien it seemed like there was a
potential need for having a x86-based platform which could need that,
Vivien do you think this platform could be in-tree one day (if not already)?
>
> All the functions you are renaming will never be called in that
> case. So i think they can retain there names. You have no need to add
> none device node equivalents.
>
> So lets drop this patch.
>
> Andrew
>
--
Florian
next prev parent reply other threads:[~2016-07-05 22:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 22:07 [PATCH net-next v2 0/4] net: dsa: Preparatory patches for pdata Florian Fainelli
2016-07-05 22:07 ` [PATCH net-next v2 1/4] net: dsa: Pass device pointer to dsa_register_switch Florian Fainelli
2016-07-05 22:23 ` Andrew Lunn
2016-07-05 22:07 ` [PATCH net-next v2 2/4] net: dsa: Make most functions take a dsa_port argument Florian Fainelli
2016-07-05 22:30 ` Andrew Lunn
2016-07-05 22:07 ` [PATCH net-next v2 3/4] net: dsa: Suffix function manipulating device_node with _dn Florian Fainelli
2016-07-05 22:36 ` Andrew Lunn
2016-07-05 22:43 ` Florian Fainelli [this message]
2016-07-05 22:52 ` Andrew Lunn
2016-07-06 1:59 ` Vivien Didelot
2016-07-07 17:57 ` Florian Fainelli
2016-07-05 22:07 ` [PATCH net-next v2 4/4] net: dsa: Move ports assignment closer to error checking Florian Fainelli
2016-07-05 22:37 ` Andrew Lunn
2016-07-06 11:50 ` Sergei Shtylyov
2016-07-07 2:00 ` [PATCH net-next v2 0/4] net: dsa: Preparatory patches for pdata Vivien Didelot
-- strict thread matches above, loose matches on Subject: below --
2017-01-26 18:45 [PATCH net-next v2 0/4] net: dsa: Preparatory patches Florian Fainelli
2017-01-26 18:45 ` [PATCH net-next v2 3/4] net: dsa: Suffix function manipulating device_node with _dn Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577C3817.1070908@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).