From: Florian Fainelli <f.fainelli@gmail.com>
To: Philippe Reynes <tremyfr@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings
Date: Thu, 7 Jul 2016 18:29:40 -0700 [thread overview]
Message-ID: <577F0204.9070601@gmail.com> (raw)
In-Reply-To: <577C2189.8090604@gmail.com>
On 07/05/2016 02:07 PM, Philippe Reynes wrote:
> Hi Florian,
>
> On 05/07/16 06:30, Florian Fainelli wrote:
>> Le 04/07/2016 16:03, David Miller a écrit :
>>> From: Philippe Reynes<tremyfr@gmail.com>
>>> Date: Sun, 3 Jul 2016 17:33:57 +0200
>>>
>>>> There are two generics functions phy_ethtool_{get|set}_link_ksettings,
>>>> so we can use them instead of defining the same code in the driver.
>>>>
>>>> Signed-off-by: Philippe Reynes<tremyfr@gmail.com>
>>>
>>> Applied.
>>>
>>
>> The transformation is not equivalent, we lost the checks on
>> netif_running() in the process, and those are here for a reason, if the
>> interface is down and therefore clock gated, MDIO accesses to the PHY
>> will simply fail outright and cause bus errors.
>
> Oh, I see, I've missed this. Sorry for this mistake.
> We should revert this path.
Can you send such a revert please? Thanks!
--
Florian
next prev parent reply other threads:[~2016-07-08 1:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 15:33 [PATCH 1/2] net: ethernet: bcmgenet: use phydev from struct net_device Philippe Reynes
2016-07-03 15:33 ` [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings Philippe Reynes
2016-07-04 23:03 ` David Miller
2016-07-05 4:30 ` Florian Fainelli
2016-07-05 21:07 ` Philippe Reynes
2016-07-05 21:15 ` Florian Fainelli
2016-07-05 21:40 ` Ben Hutchings
2016-07-10 22:50 ` Philippe Reynes
2016-07-11 2:30 ` Florian Fainelli
2016-07-08 1:29 ` Florian Fainelli [this message]
2016-07-04 23:02 ` [PATCH 1/2] net: ethernet: bcmgenet: use phydev from struct net_device David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577F0204.9070601@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).