From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A31BC43381 for ; Mon, 25 Feb 2019 16:55:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9FE220842 for ; Mon, 25 Feb 2019 16:55:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728327AbfBYQzs (ORCPT ); Mon, 25 Feb 2019 11:55:48 -0500 Received: from smtprelay0025.hostedemail.com ([216.40.44.25]:47251 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728028AbfBYQzr (ORCPT ); Mon, 25 Feb 2019 11:55:47 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id E0A1B52A8; Mon, 25 Feb 2019 16:55:45 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: fight18_6c0890960a238 X-Filterd-Recvd-Size: 2976 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Mon, 25 Feb 2019 16:55:42 +0000 (UTC) Message-ID: <57807dca3bf554d0a07356ba1e53fae4d58cfb51.camel@perches.com> Subject: Re: INFO: task hung in rtnetlink_rcv_msg From: Joe Perches To: Jesper Dangaard Brouer , Daniel Borkmann Cc: Jakub Kicinski , syzbot , ast@kernel.org, christian@brauner.io, davem@davemloft.net, dsahern@gmail.com, hawk@kernel.org, idosch@mellanox.com, john.fastabend@gmail.com, kafai@fb.com, ktkhai@virtuozzo.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, petrm@mellanox.com, roopa@cumulusnetworks.com, songliubraving@fb.com, syzkaller-bugs@googlegroups.com, xdp-newbies@vger.kernel.org, yhs@fb.com Date: Mon, 25 Feb 2019 08:55:40 -0800 In-Reply-To: <20190225093933.748ceab4@carbon> References: <000000000000c07a5805827e85d5@google.com> <20190222120129.1f2f1c17@cakuba.netronome.com> <20190222134511.13eb7a82@cakuba.netronome.com> <279c5bae-0b18-b03a-2858-4749e18afa26@iogearbox.net> <20190225093933.748ceab4@carbon> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 2019-02-25 at 09:39 +0100, Jesper Dangaard Brouer wrote: > On Sat, 23 Feb 2019 01:47:00 +0100 > Daniel Borkmann wrote: > > > On 02/22/2019 10:45 PM, Jakub Kicinski wrote: > > > On Fri, 22 Feb 2019 12:14:57 -0800, Joe Perches wrote: > > > > On Fri, 2019-02-22 at 12:01 -0800, Jakub Kicinski wrote: > > > > > Hi! > > > > > > > > > > Seems like something funny is going on with get_maintainer.pl since XDP > > > > > entry got added. We seem to have been CCed on: > > > > > > > > I suggest removing the MAINTAINERS line with > > > > > > > > K: xdp > > > > > > > > as xdp is a pretty generic file/patch content > > > > regex match for the K: type > > > > > > > > $ git grep --name-only xdp | wc -l > > > > 236 > > I'm unsure how K: works, but you grep definitely selects some wrong files. > > I tried with "xdp_": > git grep --name-only xdp_ > > That does catch all the driver that have XDP support, which is the > point of the exercise (to catch drivers). > > It does contain a couple of false-positives: > drivers/net/ethernet/neterion/vxge/vxge-traffic.c > drivers/thunderbolt/tb_msgs.h > drivers/thunderbolt/xdomain.c > sound/soc/codecs/rt5670.c > > Via the pattern '[^a-z]xdp_' I'm only left with the thunderbolt > false-positive, as it have a data struct's called tb_xdp_*. Then it's probably better to use K: \Wxdp_ and if XDP_ is also to be matched, maybe K: (?i:\Wxdp_)