Re: [PATCH net-next 1/7] bnxt_en: Skip ethtool RSS context configuration in ifdown state

[Jacob Keller <jacob.e.keller@intel.com>]

On 4/9/2024 4:51 PM, Michael Chan wrote:
> On Tue, Apr 9, 2024 at 4:26 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
>>
>>
>>
>> On 4/9/2024 2:54 PM, Michael Chan wrote:
>>> From: Pavan Chebbi <pavan.chebbi@broadcom.com>
>>>
>>> The current implementation requires the ifstate to be up when
>>> configuring the RSS contexts.  It will try to fetch the RX ring
>>> IDs and will crash if it is in ifdown state.  Return error if
>>> !netif_running() to prevent the crash.
>>>
>>> An improved implementation is in the works to allow RSS contexts
>>> to be changed while in ifdown state.
>>>
>>> Fixes: b3d0083caf9a ("bnxt_en: Support RSS contexts in ethtool .{get|set}_rxfh()")
>>> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>>> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
>>> Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
>>> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
>>> ---
>>
>> Makes sense, though I think you could send this fix directly to net as
>> its clearly a bug fix and preventing a crash is good.
> 
> This RSS context feature in the driver is new and is only in net-next,
> so the patch only applies to net-next.  Thanks.

Ah, even better fixing it before it hits a stable.

Thanks,
Jake