From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dongpo Li Subject: Re: [PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver Date: Fri, 15 Jul 2016 17:02:52 +0800 Message-ID: <5788A6BC.5020603@hisilicon.com> References: <1468571195-59763-1-git-send-email-lidongpo@hisilicon.com> <20917223.X0KrqBAbxT@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , , , , , , , , , , To: Arnd Bergmann Return-path: In-Reply-To: <20917223.X0KrqBAbxT@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Arnd, On 2016/7/15 16:41, Arnd Bergmann wrote: > On Friday, July 15, 2016 4:26:32 PM CEST Dongpo Li wrote: >> This patch set adds a Hisilicon MDIO bus driver and >> a Fast Ethernet MAC(FEMAC) driver. >> We also abstract a general interface "of_phy_get_and_connect" >> for PHY connect. User will have no bother with getting >> "phy-mode" and "phy-handle" any more. >> >> Changes in v1: >> - Pass private data structure instead of struct mii_bus >> in MDIO read and write operation. >> - Return the error which devm_clk_get() gives when MDIO probe. >> - Leave the clock unprepared and disabled on error when MDIO probe. >> - Abstract a general interface "of_phy_get_and_connect" for PHY connect. >> - Remove the "_reset" suffixes in "reset-names" property. >> - Enable tx per-packet interrupt when tx fifo full. >> - Remove pointless compatible and add SoC specific compatible. >> - Declare only one clock in MAC dts documentation. >> - Add standard unit suffixes for "phy-reset-delays". >> - Use a smaller NAPI poll weight 16 for our Fast Ethernet MAC. >> - Use phy_ethtool_{get|set}_link_ksettings for ethtool ops. >> - Use phydev from struct net_device in MAC driver. >> > > Looks all good to me now, > > Reviewed-by: Arnd Bergmann > > One comment on the submission format: we normally count the initial > submission as "v1", so after [PATCH 0/3], the following version is > [PATCH v2 0/3], not [PATCH v1 0/3]. > > No need to re-send for this now, and if you end up having to make > other changes, just continue with "v2" for this driver, just follow > the normal scheme if you send another driver. > Okay, many thanks for your friendly reminder. :) > Arnd > > . > Regards, Dongpo . -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html