netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ivan <khorivan@gmail.com>
To: netdev@vger.kernel.org
Cc: kan.liang@intel.com, David Miller <davem@davemloft.net>
Subject: [RFC] ethtool bandwidth per-queue commands
Date: Wed, 20 Jul 2016 23:00:31 +0300	[thread overview]
Message-ID: <578FD85F.7080508@gmail.com> (raw)

Hi everyone.

The ethtool interface has ETHTOOL_PERQUEUE command that is used to
read/set per-queue parameters for multiqueue Ethernet devices.

I want to apply additional per-queue commands like per-queue bandwidth
and per-queue number of descriptors (like number of rings).

Currently only ETHTOOL_G/SCOALESCE sub commands are added for
per-queue interface (but I haven't seen counterpart for ethtool util).

Using ETHTOOL_G/SCOALESCE per-queue command as an example,
I'm going to add 2 additional and 2 known commands for ethtool
per-queue interface:

ETHTOOL_G/SBANDWIDTH     /* Get/Set ethtool per queue bandwidth.
Bandwidth can be set with % or absolute in Mb/s */

ETHTOOL_G/SRINGPARAM     /* is going to be used to control number of
descriptors per queue in my driver */

It's not clear how PERQUEUE command splits rx and tx queues, as
they can have different enumeration and different parameters.

Actually, there are several questions:
- how to split enumeration of rx / tx queues in per queue command,
   as it uses linear bitmap to mirror affected channels.
- where is ethtool util counterpart for per queue command?
- is it correct way to use ethtool to configure h/w shaper?

In my case, by default, multi queue h/w shaper is working in
priority mode. The setting of bandwidth for queues can be used
to switch shaper to throughput aware mode when every queue can be
bandwidth limited.

-- 
Regards,
Ivan Khoronzhuk

             reply	other threads:[~2016-07-20 20:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 20:00 ivan [this message]
2016-07-20 20:51 ` [RFC] ethtool bandwidth per-queue commands Liang, Kan
2016-07-21  1:06 ` John Fastabend

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578FD85F.7080508@gmail.com \
    --to=khorivan@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kan.liang@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).