From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D9AC43381 for ; Tue, 19 Feb 2019 08:09:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03E6121903 for ; Tue, 19 Feb 2019 08:09:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727426AbfBSIJs (ORCPT ); Tue, 19 Feb 2019 03:09:48 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:4218 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725768AbfBSIJr (ORCPT ); Tue, 19 Feb 2019 03:09:47 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 1BD6771BBC384BBB2E57; Tue, 19 Feb 2019 16:09:45 +0800 (CST) Received: from [127.0.0.1] (10.177.96.96) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.408.0; Tue, 19 Feb 2019 16:09:42 +0800 Subject: Re: [PATCH] net: ns83820: drop pointless static qualifier in ns83820_probe_phy() To: Julia Lawall References: <20190219080659.89732-1-maowenan@huawei.com> CC: , , , , , , From: maowenan Message-ID: <578c4208-956d-b905-6a50-5ad04620a349@huawei.com> Date: Tue, 19 Feb 2019 16:09:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.96.96] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/2/19 16:01, Julia Lawall wrote: > > > On Tue, 19 Feb 2019, Mao Wenan wrote: > >> There is no need to have the 'int first' static >> since new value always be assigned before use it. >> The old codes of first dereferencing this variable have >> been commented out. So it is useless with 'static int first'. >> /* >> if (!first) { >> ... >> } >> */ >> first = 1; > > Do you need the variable at all? > > In the code, the commenting out is actually done with #if 0. It could be > good for the commit log to reflect the code more accurately. > OK, the original codes are using #if 0 to comment out, but when I generate patch the "#if 0" has been removed, so I use "/*...*/" to reflect that. > Can the #if 0 and code be removed? Apparently it predates git. > > A commented out printk below also predates git. > I think all the "#if 0" comment out codes and printk codes can be removed, shall I send v2 to do this? > julia > >> >> Signed-off-by: Mao Wenan >> --- >> drivers/net/ethernet/natsemi/ns83820.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c >> index 958fced4dacf..fb064df3a1a6 100644 >> --- a/drivers/net/ethernet/natsemi/ns83820.c >> +++ b/drivers/net/ethernet/natsemi/ns83820.c >> @@ -1869,7 +1869,7 @@ static unsigned ns83820_mii_write_reg(struct ns83820 *dev, unsigned phy, unsigne >> static void ns83820_probe_phy(struct net_device *ndev) >> { >> struct ns83820 *dev = PRIV(ndev); >> - static int first; >> + int first; >> int i; >> #define MII_PHYIDR1 0x02 >> #define MII_PHYIDR2 0x03 >> -- >> 2.20.1 >> >> > > . >