Re: [PATCH net-next-2.6 v2] bonding: introduce primary_reselect option

[Jay Vosburgh <fubar@us.ibm.com>]

Jiri Pirko <jpirko@redhat.com> wrote:

>Fri, Sep 25, 2009 at 09:47:25AM CEST, billfink@mindspring.com wrote:
>>On Thu, 24 Sep 2009, Jay Vosburgh wrote:
>>
>>> 
>>> From: Jiri Pirko <jpirko@redhat.com>
>>> 
>>> In some cases there is not desirable to switch back to primary interface when
>>> it's link recovers and rather stay with currently active one. We need to avoid
>>> packetloss as much as we can in some cases. This is solved by introducing
>>> primary_reselect option. Note that enslaved primary slave is set as current
>>> active no matter what.
>>> 
>>> Patch modified by Jay Vosburgh as follows: fixed bug in action
>>> after change of option setting via sysfs, revised the documentation
>>> update, and bumped the bonding version number.
>>> 
>>> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>>> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
>>> ---
>>> 
>>> 	Note that this patch depends on the "make ab_arp select active
>>> slaves as other modes" patch recently approved, but not yet appearing in
>>> net-next-2.6 as I write this.  http://patchwork.ozlabs.org/patch/32684/
>>> 
>>>  Documentation/networking/bonding.txt |   42 +++++++++++++++++++++-
>>>  drivers/net/bonding/bond_main.c      |   66 +++++++++++++++++++++++++++++++---
>>>  drivers/net/bonding/bond_main.c.rej  |   18 +++++++++
>>>  drivers/net/bonding/bond_sysfs.c     |   53 +++++++++++++++++++++++++++
>>>  drivers/net/bonding/bonding.h        |   11 +++++-
>>>  5 files changed, 182 insertions(+), 8 deletions(-)
>>>  create mode 100644 drivers/net/bonding/bond_main.c.rej
>>
>>I doubt you intended to include a patch reject file in your patch.
>
>Noticed - I'm about to resend...

	Thanks, guys.

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com