From: Arnd Bergmann <arnd@arndb.de>
To: netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>,
Sunil Goutham <sgoutham@cavium.com>,
Maciej Czekaj <mjc@semihalf.com>,
David Daney <david.daney@cavium.com>,
Sunil Goutham <sgoutham@cavium.com>,
Ganapatrao Kulkarni <ganapatrao.kulkarni@caviumnetworks.com>,
Aleksey Makarov <aleksey.makarov@caviumnetworks.com>,
Tomasz Nowicki <tomasz.nowicki@linaro.org>,
Robert Richter <rrichter@cavium.com>,
Kamil Rytarowski <kamil@semihalf.com>,
Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>,
Sruthi Vangala <svangala@cavium.com>
Subject: [PATCH] net: thunderx: add 64-bit dependency
Date: Thu, 28 May 2015 16:00:46 +0200 [thread overview]
Message-ID: <5799754.oCDa9qX0W8@wuerfel> (raw)
The thunderx ethernet driver fails to build on architectures
that do not have an atomic readq() and writeq() function for
64-bit PCI bus access:
drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_reg_read':
include/asm-generic/io.h:195:23: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
It seems impossible to get this driver to work on most 32-bit
hardware, so it's better to add an explicit dependency, in
order to let us keep building 'allmodconfig' kernels on
all architectures.
As the driver is meant for the internal hardware on an arm64 SoC, this
is not a problem for usability. Allowing the build on all 64-bit
architectures rather than just CONFIG_ARM64 on the other hand means that
we get the benefit of build testing on x86.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/net/ethernet/cavium/Kconfig b/drivers/net/ethernet/cavium/Kconfig
index 6365fb4242be..fc3d8e3ee807 100644
--- a/drivers/net/ethernet/cavium/Kconfig
+++ b/drivers/net/ethernet/cavium/Kconfig
@@ -4,7 +4,7 @@
config NET_VENDOR_CAVIUM
tristate "Cavium ethernet drivers"
- depends on PCI
+ depends on PCI && 64BIT
---help---
Enable support for the Cavium ThunderX Network Interface
Controller (NIC). The NIC provides the controller and DMA
next reply other threads:[~2015-05-28 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 14:00 Arnd Bergmann [this message]
2015-05-28 15:49 ` [PATCH] net: thunderx: add 64-bit dependency David Daney
2015-05-31 6:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5799754.oCDa9qX0W8@wuerfel \
--to=arnd@arndb.de \
--cc=aleksey.makarov@caviumnetworks.com \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=ganapatrao.kulkarni@caviumnetworks.com \
--cc=kamil@semihalf.com \
--cc=mjc@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=rrichter@cavium.com \
--cc=sgoutham@cavium.com \
--cc=svangala@cavium.com \
--cc=tomasz.nowicki@linaro.org \
--cc=tsrinivasulu@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox