From: Daniel Borkmann <daniel@iogearbox.net>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, xiyou.wangcong@gmail.com
Subject: Re: [PATCH v3 net-next 1/1] net_sched: Introduce skbmod action
Date: Mon, 29 Aug 2016 13:00:59 +0200 [thread overview]
Message-ID: <57C415EB.80806@iogearbox.net> (raw)
In-Reply-To: <b075631d-92cc-d016-3786-aaacb3d5c13a@mojatatu.com>
On 08/29/2016 12:38 PM, Jamal Hadi Salim wrote:
> On 16-08-28 12:07 PM, Eric Dumazet wrote:
>
>> Adding an action with a spinlock held in fast path in 2016 is
>> a way to tell people : It is a toy, do not use it for real.
>>
>> Sorry guys. Friends do not let friends do that anymore.
>
> Generally agree.
> Cong says he is working on generic patches. Let me see if i can
> try something. Trickery with RCU is not one of my virtues -
> so i may get it wrong but hope you can comment.
You could probably just keep these meta data in a separate struct
managed by RCU that tcf_skbmod points to.
One more thing I commented on your last patch already is that you
would also need f.e. skb_ensure_writable() before mangling.
next prev parent reply other threads:[~2016-08-29 11:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 12:19 [PATCH v3 net-next 1/1] net_sched: Introduce skbmod action Jamal Hadi Salim
2016-08-28 14:48 ` Alexei Starovoitov
2016-08-29 10:35 ` Jamal Hadi Salim
2016-08-28 16:07 ` Eric Dumazet
2016-08-29 5:10 ` Cong Wang
2016-08-29 13:27 ` Eric Dumazet
2016-08-29 10:38 ` Jamal Hadi Salim
2016-08-29 11:00 ` Daniel Borkmann [this message]
2016-08-29 11:40 ` Jamal Hadi Salim
2016-08-29 11:55 ` Jamal Hadi Salim
2016-08-29 11:35 ` Jamal Hadi Salim
2016-08-29 18:20 ` Eric Dumazet
2016-08-30 11:12 ` Jamal Hadi Salim
2016-08-30 11:57 ` Jamal Hadi Salim
2016-08-30 12:35 ` Eric Dumazet
2016-09-06 12:03 ` Jamal Hadi Salim
2016-08-30 12:44 ` Eric Dumazet
2016-09-06 12:08 ` Jamal Hadi Salim
2016-09-06 14:25 ` Eric Dumazet
2016-09-08 10:38 ` Jamal Hadi Salim
2016-09-08 16:02 ` Eric Dumazet
2016-09-08 16:11 ` Eric Dumazet
2016-09-09 12:33 ` Jamal Hadi Salim
2016-08-30 12:20 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C415EB.80806@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).