From: Saeed Mahameed <saeedm@mellanox.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Huy Nguyen <huyn@mellanox.com>
Subject: Re: [PATCH net-next 6/6] net/mlx5: Add handling for port module event
Date: Wed, 31 Aug 2016 14:05:27 +0300 [thread overview]
Message-ID: <57C6B9F7.306@mellanox.com> (raw)
In-Reply-To: <CAJ3xEMg9d58BwLR3QAK_WjmLM1Sz2RrCDUJxQbeLzPAW7Hwp2Q@mail.gmail.com>
On 8/30/2016 11:24 PM, Or Gerlitz wrote:
> On Tue, Aug 30, 2016 at 2:29 PM, Saeed Mahameed <saeedm@mellanox.com> wrote:
>> From: Huy Nguyen <huyn@mellanox.com>
>> +++ b/include/linux/mlx5/device.h
>> @@ -543,6 +544,15 @@ struct mlx5_eqe_vport_change {
>> __be32 rsvd1[6];
>> } __packed;
>>
>> +struct mlx5_eqe_port_module {
>> + u8 rsvd0[1];
>> + u8 module;
>> + u8 rsvd1[1];
>> + u8 module_status;
>> + u8 rsvd2[2];
>> + u8 error_type;
>> +};
>> +
> Saeed, any reason for this struct and friends not to be @ the FW IFC file?
Yes, those structures are accessed from irq context, we need to keep it
as fast as possible,
although for this case it is not that critical. But in order to keep the
code uniform, all eqes are built this way.
prev parent reply other threads:[~2016-09-01 7:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 11:29 [PATCH net-next 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support Saeed Mahameed
2016-08-30 11:29 ` [PATCH net-next 1/6] net/mlx5e: Support DCBX CEE API Saeed Mahameed
2016-08-30 20:33 ` Or Gerlitz
2016-08-30 11:29 ` [PATCH net-next 2/6] net/mlx5e: Read ETS settings directly from firmware Saeed Mahameed
2016-08-30 20:34 ` Or Gerlitz
2016-08-30 11:29 ` [PATCH net-next 3/6] net/mlx5: Add DCBX firmware commands support Saeed Mahameed
2016-08-31 11:24 ` zhuyj
2016-08-31 14:49 ` Huy Nguyen
2016-08-31 16:08 ` Saeed Mahameed
2016-08-30 11:29 ` [PATCH net-next 4/6] net/mlx5e: ConnectX-4 firmware support for DCBX Saeed Mahameed
2016-08-30 11:29 ` [PATCH net-next 5/6] net/mlx5e: Add DCBX control interface Saeed Mahameed
2016-08-30 11:29 ` [PATCH net-next 6/6] net/mlx5: Add handling for port module event Saeed Mahameed
2016-08-30 20:24 ` Or Gerlitz
2016-08-31 11:05 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C6B9F7.306@mellanox.com \
--to=saeedm@mellanox.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=huyn@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).