From: John Fastabend <john.fastabend@gmail.com>
To: Hadar Hen Zion <hadarh@mellanox.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Jiri Benc <jbenc@redhat.com>, Jamal Hadi Salim <jhs@mojatatu.com>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
Tom Herbert <tom@herbertland.com>,
Eric Dumazet <edumazet@google.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Amir Vadai <amirva@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>
Subject: Re: [PATCH net-next] net/sched: act_tunnel_key: Remove rcu_read_lock protection
Date: Mon, 12 Sep 2016 07:09:20 -0700 [thread overview]
Message-ID: <57D6B710.1080001@gmail.com> (raw)
In-Reply-To: <1473682762-8150-1-git-send-email-hadarh@mellanox.com>
On 16-09-12 05:19 AM, Hadar Hen Zion wrote:
> Remove rcu_read_lock protection from tunnel_key_dump and use
> rtnl_dereference, dump operation is protected by rtnl lock.
>
> Also, remove rcu_read_lock from tunnel_key_release and use
> rcu_dereference_protected.
>
> Both operations are running exclusively and a writer couldn't modify
> t->params while those functions are executed.
>
> Fixes: 54d94fd89d90 ('net/sched: Introduce act_tunnel_key')
> Signed-off-by: Hadar Hen Zion <hadarh@mellanox.com>
> ---
Thanks for cleaning this up.
Acked-by: John Fastabend <john.r.fastabend@intel.com>
next prev parent reply other threads:[~2016-09-12 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 12:19 [PATCH net-next] net/sched: act_tunnel_key: Remove rcu_read_lock protection Hadar Hen Zion
2016-09-12 14:09 ` John Fastabend [this message]
2016-09-12 14:17 ` Eric Dumazet
2016-09-15 23:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D6B710.1080001@gmail.com \
--to=john.fastabend@gmail.com \
--cc=amirva@mellanox.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hadarh@mellanox.com \
--cc=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=shmulik.ladkani@gmail.com \
--cc=tom@herbertland.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).