From: John Fastabend <john.fastabend@gmail.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, hariprasad@chelsio.com, leedom@chelsio.com,
nirranjan@chelsio.com, indranil@chelsio.com
Subject: Re: [PATCH net-next v2 3/5] cxgb4: add parser to translate u32 filters to internal spec
Date: Thu, 15 Sep 2016 07:27:24 -0700 [thread overview]
Message-ID: <57DAAFCC.8000207@gmail.com> (raw)
In-Reply-To: <ccd36e66281e2302cb46c7351be22a3ca276c07e.1473759872.git.rahul.lakkireddy@chelsio.com>
On 16-09-13 04:42 AM, Rahul Lakkireddy wrote:
> Parse information sent by u32 into internal filter specification.
> Add support for parsing several fields in IPv4, IPv6, TCP, and UDP.
>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
> ---
Looks good to me. Also curious if you would find it worthwhile to
have a cls_u32 mode that starts at L2 instead of the IP header? The
use case would be to use cls_u32 with various encapsulation protocols
in front of the IP header.
Reviewed-by: John Fastabend <john.r.fastabend@intel.com>
next prev parent reply other threads:[~2016-09-15 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 11:42 [PATCH net-next v2 0/5] cxgb4: add support for offloading TC u32 filters Rahul Lakkireddy
2016-09-13 11:42 ` [PATCH net-next v2 1/5] cxgb4: move common filter code to separate file Rahul Lakkireddy
2016-09-13 11:42 ` [PATCH net-next v2 2/5] cxgb4: add common api support for configuring filters Rahul Lakkireddy
2016-09-16 0:18 ` David Miller
2016-09-13 11:42 ` [PATCH net-next v2 3/5] cxgb4: add parser to translate u32 filters to internal spec Rahul Lakkireddy
2016-09-15 14:27 ` John Fastabend [this message]
2016-09-17 8:40 ` Rahul Lakkireddy
2016-09-13 11:42 ` [PATCH net-next v2 4/5] cxgb4: add support for offloading u32 filters Rahul Lakkireddy
2016-09-13 11:42 ` [PATCH net-next v2 5/5] cxgb4: add support for drop and redirect actions Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57DAAFCC.8000207@gmail.com \
--to=john.fastabend@gmail.com \
--cc=davem@davemloft.net \
--cc=hariprasad@chelsio.com \
--cc=indranil@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).