From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA9E3C43381 for ; Fri, 22 Mar 2019 16:17:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80655218A2 for ; Fri, 22 Mar 2019 16:17:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j6r6Fb5G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbfCVQR6 (ORCPT ); Fri, 22 Mar 2019 12:17:58 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:33614 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726649AbfCVQR6 (ORCPT ); Fri, 22 Mar 2019 12:17:58 -0400 Received: by mail-pg1-f193.google.com with SMTP id b12so1870812pgk.0 for ; Fri, 22 Mar 2019 09:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=l3t90qdPoGlgpEpt0oAf7vrt786KFT2pPgbCiCoB5mM=; b=j6r6Fb5G1d3QDEf9y1U9TWX+UvxhoMEXZCDEvXqvepLUK7mROlt+gacrNEoCP9+ip9 hAy/c3jWip/2NqBPJTwRktRrXRnXX7y+lwsKLoxncKVs7aDqVUDc0V46Jbt7y2pPmWoY YFONKdmolFU/EmN74Dx4LdLv5OrWhQ8GrW+Zlbk3ecWSGjzbqrkmKpkudNKOGtpt44x3 t6bsijjMmyoUaHm6Gw4Qsn4gWP1OW5CbJL10moeOit8Fl1xYHRTw9fnfzYIdwLAb6U8p Ynvj0ff2lxstM2m1pBTLKuHTtYZd+osMDQq9kAMK4y6rFUTh+oGHHHBm1fEuuCuf47VA 4mjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=l3t90qdPoGlgpEpt0oAf7vrt786KFT2pPgbCiCoB5mM=; b=a0zZ/xvWBPAqLJh5TTltEyCWibHLo9VHRfe+bVjqJDw4pec+MHfy6iVXkREsM8DMiY Spg3ALmvX+78lnta3HuTLJOHZxNsrf2WE8yh8lOJ62mv1drywiuw2GcjXVqPUqiosA9g OpMlRf3U5NNKlQ+4qRG34H0xq4IJ10qKfwAh6IQRn/xm2O4t9ILr/RWUoVXVncTU9M1q gZg6AyC4woMQb19Vjga92hKdS3JvFomy+2AL+I8fiNCJmuEzsN9XSYr/72p3DTEhXMa5 TfLowwURSA3MPhh0t3GPCUYa/7pDDpucZCyGZlEwo75NcAXc7DVaH1voauDkxe140Sw6 c+rg== X-Gm-Message-State: APjAAAUernkOcLK+6Gy0L/BqKQcUe5pnhpFOgutoaPgHYZ088Pgdv8zq mOVs92I7hTUqEvO+m2lGzVeBcKlY X-Google-Smtp-Source: APXvYqyUF6DPHOsO5SiLVKZIAQOqB1MqAV7iUFgMO9h/t+7QUYWwgN3MRs6E3KtCMJi3k6V3FU8iWw== X-Received: by 2002:a63:e848:: with SMTP id a8mr9308246pgk.357.1553271476803; Fri, 22 Mar 2019 09:17:56 -0700 (PDT) Received: from [172.27.227.215] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id 26sm1561286pfj.93.2019.03.22.09.17.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Mar 2019 09:17:56 -0700 (PDT) Subject: Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file To: Alexei Starovoitov , David Ahern Cc: davem@davemloft.net, netdev@vger.kernel.org References: <20190322130609.11655-1-dsahern@kernel.org> <20190322161423.anyrhc3i5wtbuamp@ast-mbp.dhcp.thefacebook.com> From: David Ahern Message-ID: <57a656dc-5be4-830a-2a54-550d0a62a475@gmail.com> Date: Fri, 22 Mar 2019 17:17:52 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190322161423.anyrhc3i5wtbuamp@ast-mbp.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/22/19 5:14 PM, Alexei Starovoitov wrote: > On Fri, Mar 22, 2019 at 06:06:09AM -0700, David Ahern wrote: >> From: David Ahern >> >> The number of stubs is growing and has nothing to do with addrconf. >> Move the definition of the stubs to a separate header file and update >> users. In the move, drop the vxlan specific comment before ipv6_stub. >> >> Code move only; no functional change intended. >> >> Signed-off-by: David Ahern > > nack. > why this code churn? This is a prep patch for nexthops as separate objects. I will be adding 4 more functions to the stubs, and I hit a bit of a header nightmare with it in addrconf.h. And this has no impact on ipv6 built in or as a module; it has only to do with a proper header file for a definition.