From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF53C433DB for ; Fri, 26 Mar 2021 14:57:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18DEF61A13 for ; Fri, 26 Mar 2021 14:57:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230080AbhCZO4x (ORCPT ); Fri, 26 Mar 2021 10:56:53 -0400 Received: from mga03.intel.com ([134.134.136.65]:7103 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230107AbhCZO4e (ORCPT ); Fri, 26 Mar 2021 10:56:34 -0400 IronPort-SDR: iyvF05gvgaxzBtQ1BbiFdZnxvmJbfvUjDyFWj4bBBWwUWCK8diISiv3aUDcDt4UDaH8nS0dCl4 6FBr5Kcfg4Iw== X-IronPort-AV: E=McAfee;i="6000,8403,9935"; a="191190186" X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="191190186" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 07:56:32 -0700 IronPort-SDR: y5xzsowtxRPpCx5Ebncn0Rq0WdahODTCTS+cN9vRGCjcbw7H5J9eG2/0Kk53p2RMA9N6VbejfG D+hM+XxyDMHg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="409931622" Received: from irsmsx603.ger.corp.intel.com ([163.33.146.9]) by fmsmga008.fm.intel.com with ESMTP; 26 Mar 2021 07:56:31 -0700 Received: from irsmsx604.ger.corp.intel.com (163.33.146.137) by irsmsx603.ger.corp.intel.com (163.33.146.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 26 Mar 2021 14:56:30 +0000 Received: from irsmsx604.ger.corp.intel.com ([163.33.146.137]) by IRSMSX604.ger.corp.intel.com ([163.33.146.137]) with mapi id 15.01.2106.013; Fri, 26 Mar 2021 14:56:30 +0000 From: "Loftus, Ciara" To: Magnus Karlsson CC: Network Development , bpf , "Karlsson, Magnus" , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: RE: [PATCH bpf 2/3] libbpf: restore umem state after socket create failure Thread-Topic: [PATCH bpf 2/3] libbpf: restore umem state after socket create failure Thread-Index: AQHXILxCnHStPP+HDEC7SfbsYlrgKKqV/SSAgABLrpA= Date: Fri, 26 Mar 2021 14:56:30 +0000 Message-ID: <57b4dcd5cc4544e380442dad0588a84d@intel.com> References: <20210324141337.29269-1-ciara.loftus@intel.com> <20210324141337.29269-3-ciara.loftus@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [163.33.253.164] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org PiANCj4gT24gV2VkLCBNYXIgMjQsIDIwMjEgYXQgMzo0NiBQTSBDaWFyYSBMb2Z0dXMgPGNpYXJh LmxvZnR1c0BpbnRlbC5jb20+DQo+IHdyb3RlOg0KPiA+DQo+ID4gSWYgdGhlIGNhbGwgdG8gc29j a2V0X2NyZWF0ZSBmYWlscywgdGhlIHVzZXIgbWF5IHdhbnQgdG8gcmV0cnkgdGhlDQo+ID4gc29j a2V0IGNyZWF0aW9uIHVzaW5nIHRoZSBzYW1lIHVtZW0uIEVuc3VyZSB0aGF0IHRoZSB1bWVtIGlz IGluIHRoZQ0KPiA+IHNhbWUgc3RhdGUgb24gZXhpdCBpZiB0aGUgY2FsbCBmYWlsZWQgYnkgcmVz dG9yaW5nIHRoZSBfc2F2ZSBwb2ludGVycw0KPiA+IGFuZCBub3QgdW5tYXBwaW5nIHRoZSBzZXQg b2YgdW1lbSByaW5ncyBpZiB0aG9zZSBwb2ludGVycyBhcmUgbm9uIE5VTEwuDQo+ID4NCj4gPiBG aXhlczogMmY2MzI0YTM5MzdmICgibGliYnBmOiBTdXBwb3J0IHNoYXJlZCB1bWVtcyBiZXR3ZWVu IHF1ZXVlcyBhbmQNCj4gZGV2aWNlcyIpDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBDaWFyYSBM b2Z0dXMgPGNpYXJhLmxvZnR1c0BpbnRlbC5jb20+DQo+ID4gLS0tDQo+ID4gIHRvb2xzL2xpYi9i cGYveHNrLmMgfCAyOSArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQ0KPiA+ICAxIGZpbGUg Y2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pDQo+ID4NCj4gPiBkaWZm IC0tZ2l0IGEvdG9vbHMvbGliL2JwZi94c2suYyBiL3Rvb2xzL2xpYi9icGYveHNrLmMNCj4gPiBp bmRleCA0NDNiMGNmYjQ1ZTguLmVjM2MyMzI5OTMyOSAxMDA2NDQNCj4gPiAtLS0gYS90b29scy9s aWIvYnBmL3hzay5jDQo+ID4gKysrIGIvdG9vbHMvbGliL2JwZi94c2suYw0KPiA+IEBAIC03NDMs MjEgKzc0MywyMyBAQCBzdGF0aWMgc3RydWN0IHhza19jdHggKnhza19nZXRfY3R4KHN0cnVjdA0K PiB4c2tfdW1lbSAqdW1lbSwgaW50IGlmaW5kZXgsDQo+ID4gICAgICAgICByZXR1cm4gTlVMTDsN Cj4gPiAgfQ0KPiA+DQo+ID4gLXN0YXRpYyB2b2lkIHhza19wdXRfY3R4KHN0cnVjdCB4c2tfY3R4 ICpjdHgpDQo+ID4gK3N0YXRpYyB2b2lkIHhza19wdXRfY3R4KHN0cnVjdCB4c2tfY3R4ICpjdHgs IGJvb2wgdW5tYXApDQo+ID4gIHsNCj4gPiAgICAgICAgIHN0cnVjdCB4c2tfdW1lbSAqdW1lbSA9 IGN0eC0+dW1lbTsNCj4gPiAgICAgICAgIHN0cnVjdCB4ZHBfbW1hcF9vZmZzZXRzIG9mZjsNCj4g PiAgICAgICAgIGludCBlcnI7DQo+ID4NCj4gPiAgICAgICAgIGlmICgtLWN0eC0+cmVmY291bnQg PT0gMCkgew0KPiA+IC0gICAgICAgICAgICAgICBlcnIgPSB4c2tfZ2V0X21tYXBfb2Zmc2V0cyh1 bWVtLT5mZCwgJm9mZik7DQo+ID4gLSAgICAgICAgICAgICAgIGlmICghZXJyKSB7DQo+ID4gLSAg ICAgICAgICAgICAgICAgICAgICAgbXVubWFwKGN0eC0+ZmlsbC0+cmluZyAtIG9mZi5mci5kZXNj LA0KPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvZmYuZnIuZGVzYyArIHVtZW0t PmNvbmZpZy5maWxsX3NpemUgKg0KPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICBz aXplb2YoX191NjQpKTsNCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICBtdW5tYXAoY3R4LT5j b21wLT5yaW5nIC0gb2ZmLmNyLmRlc2MsDQo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIG9mZi5jci5kZXNjICsgdW1lbS0+Y29uZmlnLmNvbXBfc2l6ZSAqDQo+ID4gLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHNpemVvZihfX3U2NCkpOw0KPiA+ICsgICAgICAgICAgICAg ICBpZiAodW5tYXApIHsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBlcnIgPSB4c2tfZ2V0 X21tYXBfb2Zmc2V0cyh1bWVtLT5mZCwgJm9mZik7DQo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgaWYgKCFlcnIpIHsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG11bm1h cChjdHgtPmZpbGwtPnJpbmcgLSBvZmYuZnIuZGVzYywNCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBvZmYuZnIuZGVzYyArIHVtZW0tPmNvbmZpZy5maWxsX3NpemUg Kg0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZW9mKF9fdTY0KSk7DQo+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtdW5tYXAoY3R4LT5jb21wLT5yaW5n IC0gb2ZmLmNyLmRlc2MsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgb2ZmLmNyLmRlc2MgKyB1bWVtLT5jb25maWcuY29tcF9zaXplICoNCj4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHNpemVvZihfX3U2NCkpOw0KPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgIH0NCj4gPiAgICAgICAgICAgICAgICAgfQ0KPiANCj4gQnkgbm90IHVubWFwcGlu ZyB0aGVzZSByaW5ncyB3ZSBhY3R1YWxseSBsZWF2ZSBtb3JlIHN0YXRlIGFmdGVyIGENCj4gZmFp bGVkIHNvY2tldCBjcmVhdGlvbi4gU28gaG93IGFib3V0IHNraXBwaW5nIHRoaXMgbG9naWMgKGFu ZA0KDQpJbiB0aGUgY2FzZSBvZiB0aGUgX3NhdmUgcmluZ3MsIHRoZSBtYXBzIGV4aXN0ZWQgYmVm b3JlIHRoZSBjYWxsIHRvDQp4c2tfc29ja2V0X19jcmVhdGUuIFRoZXkgd2VyZSBjcmVhdGVkIGR1 cmluZyB4c2tfdW1lbV9fY3JlYXRlLg0KU28gd2Ugc2hvdWxkIHByZXNlcnZlIHRoZXNlIG1hcHMg aW4gZXZlbnQgb2YgZmFpbHVyZS4NCkkgd2FzIHVzaW5nIHRoZSB3cm9uZyBjb25kaXRpb24gdG8g dHJpZ2dlciB0aGUgdW5tYXAgaW4gdjEgaG93ZXZlci4NCldlIHNob3VsZCB1bm1hcCAnZmlsbCcg b25seSBpZg0KICAgICAgICB1bWVtLT5maWxsX3NhdmUgIT0gZmlsbA0KSSB3aWxsIHVwZGF0ZSB0 aGlzIGluIGEgdjIuDQoNCj4gZXZlcnl0aGluZyBiZWxvdykgYW5kIGFsd2F5cyB1bm1hcCB0aGUg cmluZ3MgYXQgZmFpbHVyZSBhcyBiZWZvcmUsIGJ1dA0KPiB3ZSBtb3ZlIHRoZSBmaWxsX3NhdmUg PSBOVUxMIGFuZCBjb21wX3NhdmUgPSBOVUxMIGZyb20geHNrX2NyZWF0ZV9jdHgNCj4gdG8gdGhl IGVuZCBvZiB4c2tfc29ja2V0X19jcmVhdGVfc2hhcmVkIGp1c3QgYmVmb3JlIHRoZSAicmV0dXJu IDAiDQo+IHdoZXJlIHdlIGtub3cgdGhhdCB0aGUgd2hvbGUgb3BlcmF0aW9uIGhhcyBzdWNjZWVk ZWQuIFRoaXMgd2F5IHRoZQ0KDQpJIHRoaW5rIG1vdmluZyB0aGVzZSBzdGlsbCBtYWtlcyBzZW5z ZSBhbmQgd2lsbCBhZGQgdGhpcyBpbiB0aGUgbmV4dCByZXYuDQoNClRoYW5rcyBmb3IgdGhlIGZl ZWRiYWNrIGFuZCBzdWdnZXN0aW9ucyENCg0KQ2lhcmENCg0KPiBtYXBwaW5ncyB3b3VsZCBiZSBy ZWRvbmUgZHVyaW5nIHRoZSBuZXh0IHhza19zb2NrZXRfX2NyZWF0ZSBhbmQgaWYNCj4gc29tZW9u ZSBkZWNpZGVzIG5vdCB0byByZXRyeSAoZm9yIHNvbWUgcmVhc29uKSB3ZSBkbyBub3QgbGVhdmUg dHdvDQo+IG1hcHBpbmdzIGJlaGluZC4gV291bGQgc2ltcGxpZnkgdGhpbmdzLiBXaGF0IGRvIHlv dSB0aGluaz8NCg0KPiANCj4gPg0KPiA+ICAgICAgICAgICAgICAgICBsaXN0X2RlbCgmY3R4LT5s aXN0KTsNCj4gPiBAQCAtODU0LDYgKzg1Niw5IEBAIGludCB4c2tfc29ja2V0X19jcmVhdGVfc2hh cmVkKHN0cnVjdCB4c2tfc29ja2V0DQo+ICoqeHNrX3B0ciwNCj4gPiAgICAgICAgIHN0cnVjdCB4 c2tfc29ja2V0ICp4c2s7DQo+ID4gICAgICAgICBzdHJ1Y3QgeHNrX2N0eCAqY3R4Ow0KPiA+ICAg ICAgICAgaW50IGVyciwgaWZpbmRleDsNCj4gPiArICAgICAgIHN0cnVjdCB4c2tfcmluZ19wcm9k ICpmc2F2ZSA9IHVtZW0tPmZpbGxfc2F2ZTsNCj4gPiArICAgICAgIHN0cnVjdCB4c2tfcmluZ19j b25zICpjc2F2ZSA9IHVtZW0tPmNvbXBfc2F2ZTsNCj4gPiArICAgICAgIGJvb2wgdW5tYXAgPSAh ZnNhdmU7DQo+ID4NCj4gPiAgICAgICAgIGlmICghdW1lbSB8fCAheHNrX3B0ciB8fCAhKHJ4IHx8 IHR4KSkNCj4gPiAgICAgICAgICAgICAgICAgcmV0dXJuIC1FRkFVTFQ7DQo+ID4gQEAgLTEwMDUs NyArMTAxMCw5IEBAIGludCB4c2tfc29ja2V0X19jcmVhdGVfc2hhcmVkKHN0cnVjdCB4c2tfc29j a2V0DQo+ICoqeHNrX3B0ciwNCj4gPiAgICAgICAgICAgICAgICAgbXVubWFwKHJ4X21hcCwgb2Zm LnJ4LmRlc2MgKw0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgeHNrLT5jb25maWcucnhfc2l6 ZSAqIHNpemVvZihzdHJ1Y3QgeGRwX2Rlc2MpKTsNCj4gPiAgb3V0X3B1dF9jdHg6DQo+ID4gLSAg ICAgICB4c2tfcHV0X2N0eChjdHgpOw0KPiA+ICsgICAgICAgdW1lbS0+ZmlsbF9zYXZlID0gZnNh dmU7DQo+ID4gKyAgICAgICB1bWVtLT5jb21wX3NhdmUgPSBjc2F2ZTsNCj4gPiArICAgICAgIHhz a19wdXRfY3R4KGN0eCwgdW5tYXApOw0KPiA+ICBvdXRfc29ja2V0Og0KPiA+ICAgICAgICAgaWYg KC0tdW1lbS0+cmVmY291bnQpDQo+ID4gICAgICAgICAgICAgICAgIGNsb3NlKHhzay0+ZmQpOw0K PiA+IEBAIC0xMDcxLDcgKzEwNzgsNyBAQCB2b2lkIHhza19zb2NrZXRfX2RlbGV0ZShzdHJ1Y3Qg eHNrX3NvY2tldCAqeHNrKQ0KPiA+ICAgICAgICAgICAgICAgICB9DQo+ID4gICAgICAgICB9DQo+ ID4NCj4gPiAtICAgICAgIHhza19wdXRfY3R4KGN0eCk7DQo+ID4gKyAgICAgICB4c2tfcHV0X2N0 eChjdHgsIHRydWUpOw0KPiA+DQo+ID4gICAgICAgICB1bWVtLT5yZWZjb3VudC0tOw0KPiA+ICAg ICAgICAgLyogRG8gbm90IGNsb3NlIGFuIGZkIHRoYXQgYWxzbyBoYXMgYW4gYXNzb2NpYXRlZCB1 bWVtIGNvbm5lY3RlZA0KPiA+IC0tDQo+ID4gMi4xNy4xDQo+ID4NCg==