From: Timur Tabi <timur@codeaurora.org>
To: David Miller <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] net: qcom/emac: enable flow control if requested
Date: Tue, 1 Nov 2016 14:05:32 -0500 [thread overview]
Message-ID: <5818E77C.7060604@codeaurora.org> (raw)
In-Reply-To: <1478025055-13167-2-git-send-email-timur@codeaurora.org>
On 11/01/2016 01:30 PM, Timur Tabi wrote:
> + if (!phydev->pause && phydev->asym_pause)
> + mac |= TXFC;
I think this might be wrong, and nb8800_pause_config() has it right.
This should be:
if (!phydev->pause != !phydev->asym_pause)
which is a logical-xor.
Do you concur?
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-11-01 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 18:30 [PATCH 1/2] net: qcom/emac: configure the external phy to allow pause frames Timur Tabi
2016-11-01 18:30 ` [PATCH 2/2] net: qcom/emac: enable flow control if requested Timur Tabi
2016-11-01 18:34 ` Florian Fainelli
2016-11-01 19:05 ` Timur Tabi [this message]
2016-11-01 18:33 ` [PATCH 1/2] net: qcom/emac: configure the external phy to allow pause frames Florian Fainelli
2016-11-01 18:34 ` Timur Tabi
2016-11-01 18:40 ` [PATCH 0/2] net: qcom/emac: the emac driver requires " Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5818E77C.7060604@codeaurora.org \
--to=timur@codeaurora.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).