From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Frias Subject: [PATCH v3 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Date: Fri, 4 Nov 2016 19:22:30 +0100 Message-ID: <581CD1E6.60801@laposte.net> References: <581CD1AF.6030300@laposte.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: LKML , Mason , Andrew Lunn To: =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= , "David S. Miller" , netdev Return-path: In-Reply-To: <581CD1AF.6030300@laposte.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org The delay can be applied at PHY or MAC level, but since PHY drivers will apply the delay at PHY level when using one of the "internal delay" declinations of RGMII mode (like PHY_INTERFACE_MODE_RGMII_TXID), applying it again at MAC level causes issues. Signed-off-by: Sebastian Frias --- drivers/net/ethernet/aurora/nb8800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c index b59aa35..d2855c9 100644 --- a/drivers/net/ethernet/aurora/nb8800.c +++ b/drivers/net/ethernet/aurora/nb8800.c @@ -1282,7 +1282,7 @@ static int nb8800_tangox_init(struct net_device *dev) break; case PHY_INTERFACE_MODE_RGMII_TXID: - pad_mode = PAD_MODE_RGMII | PAD_MODE_GTX_CLK_DELAY; + pad_mode = PAD_MODE_RGMII; break; default: -- 1.7.11.2