[bug report] net: enetc: reimplement RFS/RSS memory clearing as PCI quirk

[Dan Carpenter <dan.carpenter@linaro.org>]

Hello Vladimir Oltean,

The patch f0168042a212: "net: enetc: reimplement RFS/RSS memory
clearing as PCI quirk" from Aug 3, 2023 (linux-next), leads to the
following Smatch static checker warning:

	drivers/net/ethernet/freescale/enetc/enetc_pf.c:1405 enetc_fixup_clear_rss_rfs()
	warn: 'si' is an error pointer or valid

drivers/net/ethernet/freescale/enetc/enetc_pf.c
    1393 static void enetc_fixup_clear_rss_rfs(struct pci_dev *pdev)
    1394 {
    1395         struct device_node *node = pdev->dev.of_node;
    1396         struct enetc_si *si;
    1397 
    1398         /* Only apply quirk for disabled functions. For the ones
    1399          * that are enabled, enetc_pf_probe() will apply it.
    1400          */
    1401         if (node && of_device_is_available(node))
    1402                 return;
    1403 
    1404         si = enetc_psi_create(pdev);
--> 1405         if (si)

I guess this should be if (!IS_ERR(si)) {?

    1406                 enetc_psi_destroy(pdev);
    1407 }

regards,
dan carpenter