From: Timur Tabi <timur@codeaurora.org>
To: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] [RFC] net: phy: phy drivers should not set SUPPORTED_Pause or SUPPORTED_Asym_Pause
Date: Tue, 8 Nov 2016 14:43:31 -0600 [thread overview]
Message-ID: <582238F3.30906@codeaurora.org> (raw)
In-Reply-To: <5820AC1D.4040408@codeaurora.org>
On 11/07/2016 10:30 AM, Timur Tabi wrote:
>
> I'm still don't understand 100% how these flags really work, because I
> just can't shake the feeling that they should not be set for every phy.
> If these flags are supposed to be turned on universally, then why are
> they even an option?
So I've been giving this more thought. Can you tell me if the following
is correct:
1) PHY drivers and/or phylib sets the SUPPORTED_Pause |
SUPPORTED_AsymPause bits in phydev->supported. This indicates that the
PHY supports pause frames.
2) The MAC driver checks phydev->supported before it calls phy_start().
If (SUPPORTED_Pause | SUPPORTED_AsymPause) is set, then it sets those
bits in phydev->advertising if it wants to enable pause frame support.
3) When the link state changes, the MAC driver checks
phydev->advertising, and if the bits are set, then it enables those
features in the MAC.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-11-08 20:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 17:18 [PATCH] [RFC] net: phy: phy drivers should not set SUPPORTED_Pause or SUPPORTED_Asym_Pause Timur Tabi
2016-11-01 18:35 ` Florian Fainelli
2016-11-01 18:45 ` Timur Tabi
2016-11-01 19:03 ` Florian Fainelli
2016-11-01 19:19 ` Timur Tabi
2016-11-07 16:30 ` Timur Tabi
2016-11-08 20:43 ` Timur Tabi [this message]
2016-11-09 17:06 ` Florian Fainelli
2016-11-09 17:34 ` Timur Tabi
2016-11-09 17:55 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582238F3.30906@codeaurora.org \
--to=timur@codeaurora.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).