From: John Fastabend <john.fastabend@gmail.com>
To: David Miller <davem@davemloft.net>, stefanha@redhat.com
Cc: netdev@vger.kernel.org, cavery@redhat.com,
imbrenda@linux.vnet.ibm.com, jhansen@vmware.com
Subject: Re: [PATCH] VSOCK: add loopback to virtio_transport
Date: Sat, 19 Nov 2016 19:14:15 -0800 [thread overview]
Message-ID: <58311507.7070707@gmail.com> (raw)
In-Reply-To: <20161119.220804.755313313976863187.davem@davemloft.net>
On 16-11-19 07:08 PM, David Miller wrote:
> From: Stefan Hajnoczi <stefanha@redhat.com>
> Date: Thu, 17 Nov 2016 15:49:23 +0000
>
>> @@ -159,6 +199,10 @@ virtio_transport_send_pkt(struct virtio_vsock_pkt *pkt)
>> return -ENODEV;
>> }
>>
>> + if (le32_to_cpu(pkt->hdr.dst_cid) == vsock->guest_cid) {
>> + return virtio_transport_send_pkt_loopback(vsock, pkt);
>> + }
>> +
>
> A single-statement basic block should get surrounding curly
> braces.
>
Should _not_ get curly braces in case it wasn't obvious ;)
next prev parent reply other threads:[~2016-11-20 3:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 15:49 [PATCH] VSOCK: add loopback to virtio_transport Stefan Hajnoczi
2016-11-20 3:08 ` David Miller
2016-11-20 3:14 ` John Fastabend [this message]
2016-11-20 3:16 ` David Miller
2016-11-21 13:40 ` Stefan Hajnoczi
2016-11-21 12:40 ` Jorgen S. Hansen
2016-11-21 18:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58311507.7070707@gmail.com \
--to=john.fastabend@gmail.com \
--cc=cavery@redhat.com \
--cc=davem@davemloft.net \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=jhansen@vmware.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).