From: Daniel Borkmann <daniel@iogearbox.net>
To: Josef Bacik <jbacik@fb.com>,
davem@davemloft.net, netdev@vger.kernel.org, ast@kernel.org,
jannh@google.com, kernel-team@fb.com
Subject: Re: [PATCH net-next] bpf: add test for the verifier equal logic bug
Date: Tue, 29 Nov 2016 20:06:40 +0100 [thread overview]
Message-ID: <583DD1C0.1010209@iogearbox.net> (raw)
In-Reply-To: <1480440919-3252-1-git-send-email-jbacik@fb.com>
On 11/29/2016 06:35 PM, Josef Bacik wrote:
> This is a test to verify that
>
> bpf: fix states equal logic for varlen access
>
> actually fixed the problem. The problem was if the register we added to our map
> register was UNKNOWN in both the false and true branches and the only thing that
> changed was the range then we'd incorrectly assume that the true branch was
> valid, which it really wasnt. This tests this case and properly fails without
> my fix in place and passes with it in place.
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Thanks a lot for the test case! They are always useful to have ... which
just reminds me: it seems we didn't add anything for f23cc643f9ba ("bpf:
fix range arithmetic for bpf map access"). ;-)
next prev parent reply other threads:[~2016-11-29 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 17:35 [PATCH net-next] bpf: add test for the verifier equal logic bug Josef Bacik
2016-11-29 18:54 ` Alexei Starovoitov
2016-11-29 19:06 ` Daniel Borkmann [this message]
2016-11-29 19:50 ` Josef Bacik
2016-11-29 20:23 ` Daniel Borkmann
2016-11-30 19:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583DD1C0.1010209@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=jannh@google.com \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).