From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Lahav Schlesinger <lschlesinger@drivenets.com>,
netdev@vger.kernel.org, dsahern@kernel.org, davem@davemloft.net
Subject: Re: [PATCH] vrf: Reset skb conntrack connection on VRF rcv
Date: Mon, 16 Aug 2021 17:28:49 -0600 [thread overview]
Message-ID: <58456069-ede2-bd22-e219-807c21a646fc@gmail.com> (raw)
In-Reply-To: <20210816144119.6f4ae667@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 8/16/21 3:41 PM, Jakub Kicinski wrote:
> On Mon, 16 Aug 2021 12:08:00 -0600 David Ahern wrote:
>> On 8/15/21 6:00 AM, Lahav Schlesinger wrote:
>>> To fix the "reverse-NAT" for replies.
>>
>> Thanks for the detailed explanation and use case.
>>
>> Looks correct to me.
>> Reviewed-by: David Ahern <dsahern@kernel.org>
>
> I get a sense this is a fix.
It is. I missed the lack of Fixes tag.
>
> Fixes: 73e20b761acf ("net: vrf: Add support for PREROUTING rules on vrf device")
> ?
This one.
Thanks,
>
> Or maybe it fixes commit a0f37efa8225 ("net: vrf: Fix NAT within a
> VRF")?
>
next prev parent reply other threads:[~2021-08-16 23:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-15 12:00 [PATCH] vrf: Reset skb conntrack connection on VRF rcv Lahav Schlesinger
2021-08-16 18:08 ` David Ahern
2021-08-16 21:41 ` Jakub Kicinski
2021-08-16 23:28 ` David Ahern [this message]
2021-08-16 23:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58456069-ede2-bd22-e219-807c21a646fc@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=lschlesinger@drivenets.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).