From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E677FC4338F for ; Mon, 16 Aug 2021 23:28:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC6CC60F35 for ; Mon, 16 Aug 2021 23:28:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234391AbhHPX30 (ORCPT ); Mon, 16 Aug 2021 19:29:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232618AbhHPX3Z (ORCPT ); Mon, 16 Aug 2021 19:29:25 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1917DC061764 for ; Mon, 16 Aug 2021 16:28:53 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id r26so3215178oij.2 for ; Mon, 16 Aug 2021 16:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nmCLMn2P55xtJTPoRJrmzPxbXh28AvLZqgEcmssugzA=; b=oDetirFtVVVJ3eZZxO2r3F1IuNKmUwoayHjp6hjMhQ+DBXZo6Yp9dlckJeMqGwN2/Z bhxOpVw4LUS8ZR1XHhiX13Sv3kHE18Se63q8ptxHWjwXsGgW5IhrlGTBT3Kl5a2MhBOh EWFNpjWfjHrf5FH9AjNhRc32mBEZl2vJR4qYFRBc/NUsYu94PsP/whrmApvHeuaMQiJw D2OuUlKU5Lhsr6ZNFYgjiaTrw7WfMh5j2MqUSBr2rtYPTuKUsIpunnWbpRh7EjvC4dT2 UP4uGi4X3efxDyk53EITb9AtrZ8hjTCZ7C21XiP+hYtb+/GS1gy++c38CqofA+n7KIVD EDhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nmCLMn2P55xtJTPoRJrmzPxbXh28AvLZqgEcmssugzA=; b=UzkLMSjle/48h/yTKZpgncHF52u35lFjp/lRavBX1oyI5168q8F8eHbgqrikRdPkZX 6UIUk65w5p+axcsJ0pyIevG38eSuRIBBc3j7CYxCXnGDcSwOpkVgK7UUg+4aDa1VuyHF UfaQDvk6NkX0gHcq2SqVV4iZWNmrI5KGuQ52xRs0WoLcNz46yUn2ZG3IittBBinl5b9z RD7ke0eccwAAWbHMoMZHdGEuDK5xEwG/c2eBdl/k3WRimtn2VgCTy0biTkHMZdpljktK aXDmyKIjb3K4/brO4RvY+6lXU2/mCaRYhdo3tt47B4n4tFJ5vguZzBkBCrGrdD/+za+H ciOw== X-Gm-Message-State: AOAM531HOlDbG0Yy7hVMBh9J3tz+Q5LYGmpk5BG1sEZN6UjDpXTzRl5k 2efIiJCgysjiKZZDiqRbO84X8IKFC84= X-Google-Smtp-Source: ABdhPJyr//1dedvsgK6zo3gEcqixU76TAOVoRTFU/mC85hyVe4FDjNl8hgzf52dx8aOuTqqETmizKQ== X-Received: by 2002:a05:6808:b21:: with SMTP id t1mr242123oij.165.1629156532539; Mon, 16 Aug 2021 16:28:52 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.45]) by smtp.googlemail.com with ESMTPSA id 17sm91500oiy.50.2021.08.16.16.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Aug 2021 16:28:52 -0700 (PDT) Subject: Re: [PATCH] vrf: Reset skb conntrack connection on VRF rcv To: Jakub Kicinski Cc: Lahav Schlesinger , netdev@vger.kernel.org, dsahern@kernel.org, davem@davemloft.net References: <20210815120002.2787653-1-lschlesinger@drivenets.com> <20210816144119.6f4ae667@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: David Ahern Message-ID: <58456069-ede2-bd22-e219-807c21a646fc@gmail.com> Date: Mon, 16 Aug 2021 17:28:49 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210816144119.6f4ae667@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/16/21 3:41 PM, Jakub Kicinski wrote: > On Mon, 16 Aug 2021 12:08:00 -0600 David Ahern wrote: >> On 8/15/21 6:00 AM, Lahav Schlesinger wrote: >>> To fix the "reverse-NAT" for replies. >> >> Thanks for the detailed explanation and use case. >> >> Looks correct to me. >> Reviewed-by: David Ahern > > I get a sense this is a fix. It is. I missed the lack of Fixes tag. > > Fixes: 73e20b761acf ("net: vrf: Add support for PREROUTING rules on vrf device") > ? This one. Thanks, > > Or maybe it fixes commit a0f37efa8225 ("net: vrf: Fix NAT within a > VRF")? >