From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [net-next PATCH v5 5/6] virtio_net: add XDP_TX support Date: Thu, 8 Dec 2016 13:51:38 -0800 Message-ID: <5849D5EA.2040402@gmail.com> References: <20161207200139.28121.4811.stgit@john-Precision-Tower-5810> <20161207201245.28121.95418.stgit@john-Precision-Tower-5810> <20161208080647-mutt-send-email-mst@kernel.org> <5849A3EE.7090603@gmail.com> <20161208231708-mutt-send-email-mst@kernel.org> <5849CFD4.60103@gmail.com> <20161208234513-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: daniel@iogearbox.net, shm@cumulusnetworks.com, davem@davemloft.net, tgraf@suug.ch, alexei.starovoitov@gmail.com, john.r.fastabend@intel.com, netdev@vger.kernel.org, brouer@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:33151 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752186AbcLHVvz (ORCPT ); Thu, 8 Dec 2016 16:51:55 -0500 Received: by mail-pg0-f67.google.com with SMTP id 3so27989950pgd.0 for ; Thu, 08 Dec 2016 13:51:54 -0800 (PST) In-Reply-To: <20161208234513-mutt-send-email-mst@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: On 16-12-08 01:45 PM, Michael S. Tsirkin wrote: > On Thu, Dec 08, 2016 at 01:25:40PM -0800, John Fastabend wrote: >> On 16-12-08 01:18 PM, Michael S. Tsirkin wrote: >>> On Thu, Dec 08, 2016 at 10:18:22AM -0800, John Fastabend wrote: >>>>> I guess this helps because it just slows down the guest. >>>>> I don't much like it ... >>>> >>>> I left it like this copying the pattern in balloon and input drivers. I >>>> can change it back to the previous pattern where it is only called if >>>> there is no errors. It has been running fine with the old pattern now >>>> for an hour or so. >>>> >>>> .John >>> >>> I'd prefer internal consistency. Could be a patch on top >>> if this helps. I'm happy it isn't actually buggy. >>> Let me know whether you want to post v6 or >>> want me to ack this one. >>> >> >> I think because DaveM has closed net-next ACK'ing this set would be >> great to get it in Dave's tree. Then I can post a small "fix" so that it >> is consistent between normal stack and xdp tx path after that. >> >> Thanks, >> John > > I can merge it through my tree too - I don't think there's > any dependency on net-next, is there? > Its all changes to virtio_net except for patch 2 which is against filter.c/filter.h which I guess you could possibly get a merge conflict on. But it would be fairly trivial. I don't have a preference on which tree it goes through whichever makes the most sense. .John