From: Stephen Hemminger <stephen.hemminger@vyatta.com>
To: Antoine Reversat <a.reversat@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 001/001] forcedeth: Don't enable hardware vlan support on hardware that doesn't support it
Date: Wed, 15 Jun 2011 13:53:00 -0700 (PDT) [thread overview]
Message-ID: <585670083.71238.1308171180725.JavaMail.root@tahiti.vyatta.com> (raw)
In-Reply-To: <25664046.71236.1308171027618.JavaMail.root@tahiti.vyatta.com>
> In the forcedeth driver hardware vlan support is used even on hardware
> that doesn't support it leading to incorrect tagging of some packets
> when using vlan.
>
> Signed-off-by: Antoine Reversat <a.reversat@gmail.com>
> ---
> --- linux-2.6.39/drivers/net/forcedeth.c 2011-05-19 00:06:34.000000000
> -0400 +++ linux-2.6.39-fixed/drivers/net/forcedeth.c 2011-06-15
> 15:57:45.331158001 -0400
> @@ -4915,6 +4915,10 @@ static void nv_vlan_rx_register(struct n
> { struct fe_priv *np = get_nvpriv(dev);
>
> + /* Don't do anything if device doesn't support VLAN */
> + if (!(np->driver_data & DEV_HAS_VLAN))
> + return;
> + spin_lock_irq(&np->lock);
>
> /* save vlan group */
This shouldn't be necessary. rx_register should not be called
unless NETIF_F_HW_VLAN_RX is set; and device should not be setting
NETIF_F_HW_VLAN_RX unless DEV_HAS_VLAN is set.
The real problem is vlan_dev.c, and applies to all devices.
next parent reply other threads:[~2011-06-15 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <25664046.71236.1308171027618.JavaMail.root@tahiti.vyatta.com>
2011-06-15 20:53 ` Stephen Hemminger [this message]
2011-06-15 21:08 ` [PATCH 001/001] forcedeth: Don't enable hardware vlan support on hardware that doesn't support it Antoine Reversat
2011-06-16 15:42 ` Stephen Hemminger
2011-06-15 20:17 Antoine Reversat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585670083.71238.1308171180725.JavaMail.root@tahiti.vyatta.com \
--to=stephen.hemminger@vyatta.com \
--cc=a.reversat@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox