From: John Fastabend <john.fastabend@gmail.com>
To: David Miller <davem@davemloft.net>, daniel@iogearbox.net
Cc: xiyou.wangcong@gmail.com, shahark@mellanox.com,
gerlitz.or@gmail.com, roid@mellanox.com, jiri@mellanox.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net, sched: fix soft lockup in tc_classify
Date: Thu, 22 Dec 2016 09:50:54 -0800 [thread overview]
Message-ID: <585C127E.7040509@gmail.com> (raw)
In-Reply-To: <20161222.115326.376675148706578174.davem@davemloft.net>
On 16-12-22 08:53 AM, David Miller wrote:
> From: Daniel Borkmann <daniel@iogearbox.net>
> Date: Wed, 21 Dec 2016 22:07:48 +0100
>
>> Ok, you mean for net. In that case I prefer the smaller sized fix to
>> be honest. It also covers everything from the point where we fetch
>> the chain via cops->tcf_chain() to the end of the function, which is
>> where most of the complexity resides, and only the two mentioned
>> commits do the relock, so as a fix I think it's fine as-is. As
>> mentioned, if there's need to refactor tc_ctl_tfilter() net-next
>> would be better, imho.
>
> Please, can you two work towards an agreement as to what fix should
> go in at this time?
>
> Thanks.
>
Thanks for fixing this!
I have a slight preference to push this patch into net as its been
tested already by Shahar and is not particularly invasive. Then for
net-next do a larger cleanup to get rid of some of the complexity per
Cong's suggestion.
.John
next prev parent reply other threads:[~2016-12-22 17:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 17:04 [PATCH net] net, sched: fix soft lockup in tc_classify Daniel Borkmann
2016-12-21 17:37 ` Eric Dumazet
2016-12-21 18:51 ` Cong Wang
2016-12-21 19:10 ` Cong Wang
2016-12-21 20:02 ` Daniel Borkmann
2016-12-21 20:47 ` Cong Wang
2016-12-21 21:07 ` Daniel Borkmann
2016-12-22 16:53 ` David Miller
2016-12-22 17:50 ` John Fastabend [this message]
2016-12-22 23:21 ` Daniel Borkmann
2016-12-22 19:05 ` Cong Wang
2016-12-23 0:26 ` Daniel Borkmann
2016-12-24 7:34 ` Cong Wang
2016-12-24 21:03 ` Daniel Borkmann
2016-12-21 19:16 ` Daniel Borkmann
2016-12-22 13:16 ` Shahar Klein
2016-12-22 23:20 ` Daniel Borkmann
2016-12-26 16:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585C127E.7040509@gmail.com \
--to=john.fastabend@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roid@mellanox.com \
--cc=shahark@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).